{"id":9872,"url":"https://patchwork.libcamera.org/api/1.1/covers/9872/?format=json","web_url":"https://patchwork.libcamera.org/cover/9872/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/1.1/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20200930132707.19367-1-jacopo@jmondi.org>","date":"2020-09-30T13:26:58","name":"[libcamera-devel,v4,0/9] android: camera_device: Add support for internal buffers","submitter":{"id":3,"url":"https://patchwork.libcamera.org/api/1.1/people/3/?format=json","name":"Jacopo Mondi","email":"jacopo@jmondi.org"},"mbox":"https://patchwork.libcamera.org/cover/9872/mbox/","series":[{"id":1340,"url":"https://patchwork.libcamera.org/api/1.1/series/1340/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=1340","date":"2020-09-30T13:26:58","name":"android: camera_device: Add support for internal buffers","version":4,"mbox":"https://patchwork.libcamera.org/series/1340/mbox/"}],"comments":"https://patchwork.libcamera.org/api/covers/9872/comments/","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id E8113C3B5B\n\tfor ;\n\tWed, 30 Sep 2020 13:23:17 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 505CB622EE;\n\tWed, 30 Sep 2020 15:23:17 +0200 (CEST)","from relay6-d.mail.gandi.net (relay6-d.mail.gandi.net\n\t[217.70.183.198])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id DC43860364\n\tfor ;\n\tWed, 30 Sep 2020 15:23:15 +0200 (CEST)","from uno.lan (93-34-118-233.ip49.fastwebnet.it [93.34.118.233])\n\t(Authenticated sender: jacopo@jmondi.org)\n\tby relay6-d.mail.gandi.net (Postfix) with ESMTPSA id CC5CBC0007;\n\tWed, 30 Sep 2020 13:23:14 +0000 (UTC)"],"X-Originating-IP":"93.34.118.233","From":"Jacopo Mondi ","To":"libcamera-devel@lists.libcamera.org","Date":"Wed, 30 Sep 2020 15:26:58 +0200","Message-Id":"<20200930132707.19367-1-jacopo@jmondi.org>","X-Mailer":"git-send-email 2.28.0","MIME-Version":"1.0","Subject":"[libcamera-devel] [PATCH v4 0/9] android: camera_device: Add\n\tsupport for internal buffers","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"hanlinchen@chromium.org","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"Addressed latest comments from Laurent and Kieran.\n\nThe only missing part is to settle on the owership of the allocator and\nthe buffer queue management, which this series still has in the CameraDevice.\n\nAs detailed in replies to v3 and private discussions, I don't think it's worth\nmoving them in the CameraStream as it will undergo reworks and in the near\nfuture, and moving allocator_ there would require marginally redesigning it.\n\nAs this series adds a missing feature and actually fixes several tests, I think\nit's good to go in its current form. Although I agree we're piling a design\ndebt which needs to be addressed by moving CameraStream to become a first class\ncitizen of the HAL and not a CameraDevice internal component.\n\nThanks\n j\n\nJacopo Mondi (9):\n android: camera_device: Add CameraStream::Type\n android: camera_device: Add frame allocator\n libcamera: frame_buffer_allocator: Add freeAll()\n android: camera_device: Clear allocator\n android: camera_device: Clear streams_ in close()\n android: camera_device: Allocate buffer pools\n android: camera_device: Add methods to get and return buffers\n android: camera_device: Use libcamera buffer pool\n android: camera_device: Add stream mapping log\n\n include/libcamera/framebuffer_allocator.h | 1 +\n src/android/camera_device.cpp | 166 +++++++++++++++++++---\n src/android/camera_device.h | 102 ++++++++++++-\n src/libcamera/framebuffer_allocator.cpp | 8 ++\n 4 files changed, 254 insertions(+), 23 deletions(-)\n\n--\n2.28.0"}