{"id":9078,"url":"https://patchwork.libcamera.org/api/1.1/covers/9078/?format=json","web_url":"https://patchwork.libcamera.org/cover/9078/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/1.1/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20200730111134.641-1-david.plowman@raspberrypi.com>","date":"2020-07-30T11:11:31","name":"[libcamera-devel,0/3] Raspberry Pi ALSC improvements","submitter":{"id":42,"url":"https://patchwork.libcamera.org/api/1.1/people/42/?format=json","name":"David Plowman","email":"david.plowman@raspberrypi.com"},"mbox":"https://patchwork.libcamera.org/cover/9078/mbox/","series":[{"id":1165,"url":"https://patchwork.libcamera.org/api/1.1/series/1165/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=1165","date":"2020-07-30T11:11:31","name":"Raspberry Pi ALSC improvements","version":1,"mbox":"https://patchwork.libcamera.org/series/1165/mbox/"}],"comments":"https://patchwork.libcamera.org/api/covers/9078/comments/","headers":{"Return-Path":"<libcamera-devel-bounces@lists.libcamera.org>","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 37A73BD878\n\tfor <parsemail@patchwork.libcamera.org>;\n\tThu, 30 Jul 2020 11:11:42 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 766826185C;\n\tThu, 30 Jul 2020 13:11:41 +0200 (CEST)","from mail-wr1-x436.google.com (mail-wr1-x436.google.com\n\t[IPv6:2a00:1450:4864:20::436])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 42D15605B2\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tThu, 30 Jul 2020 13:11:40 +0200 (CEST)","by mail-wr1-x436.google.com with SMTP id f1so23945792wro.2\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tThu, 30 Jul 2020 04:11:40 -0700 (PDT)","from pi4-davidp.lan (plowpeople3.plus.com. [80.229.223.72])\n\tby smtp.gmail.com with ESMTPSA id\n\tl10sm9526651wru.3.2020.07.30.04.11.38\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tThu, 30 Jul 2020 04:11:39 -0700 (PDT)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=raspberrypi.com header.i=@raspberrypi.com\n\theader.b=\"Y3+amo7s\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=raspberrypi.com; s=google;\n\th=from:to:cc:subject:date:message-id:mime-version\n\t:content-transfer-encoding;\n\tbh=4RuG19fv8lTEF+VP7d5J+vetxo7SLFfqfWlyL2Fudt8=;\n\tb=Y3+amo7sIMRyYX+SCdEuzs5Tj5+pEkMMviuBI9buvXNtu8fzzWFhLDvLzkp7snv9aW\n\tL6wDWOk+NOWpsHTaYO8MwNZn8IYDO4Pwt9NaKJFAwWSubIFVkN8/ag9OswmWvrVUcqWc\n\tCYYCR2Oohn/jnSwFBrTrzrcOfomiDVvL2x/kwHiLaioKAuEw0nltXFZAEiySu/32HEdP\n\tGGS3eVPynRcDdRoiZFU3h9JqjJAzto4vGfnGLGSFBfvueTYMyz6CFClgFWJgWUzD6d6j\n\tQ2JI3RowJ5/NNUAFgbcihPA2rUH8Qd7/xoLmNdUDrqSdvYB5IJorhY7iUVg3orhnnMpU\n\tiVVQ==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version\n\t:content-transfer-encoding;\n\tbh=4RuG19fv8lTEF+VP7d5J+vetxo7SLFfqfWlyL2Fudt8=;\n\tb=EIGWTHeL5bRv12i92AKPM80h5UI3oZ5uLZlPOX9HBUwrbUfzGQnxHiiJ6OhUQBOPqK\n\tPwYnuXHde9hHzQB5eEOc+PWYxZJxMmNWODsao6GZSz/LpRlb+zHh5LlXkzEMnCtmPuPE\n\tc8xbm03NIshfHEI3WFW2RLiMKAGulUgopmSQdKBTLzi1V3dYWF8512gaNex/kQ2iDzFn\n\t6OZrvsLlsUDprbMpcCfEombmNtlN22HCzfCwcSFIbharmfWJopGP0S3ZmYrAIqx85hGX\n\tgb54lCNTc0DlOZQWQv3vfNm49VZfEko5jfC/inrIyKbD2rpsx08dbPTcvjA97qKrcfH0\n\tpEyw==","X-Gm-Message-State":"AOAM530v/9q+JnhBhgGHryW/sXi8+IX7BRe+wDxUmpqNNKqdKJarpKes\n\tP94L9DOFbR3g7teS+h1sx7oP6DQH5tECTQ==","X-Google-Smtp-Source":"ABdhPJwitz0lrQLSz1M7q00GB598t0xDfQjrmyZJl2KJs+GBAkTe0FrFBmWdA2LrAR5Gk2qDMZYNyA==","X-Received":"by 2002:adf:d08d:: with SMTP id\n\ty13mr35722498wrh.313.1596107499599; \n\tThu, 30 Jul 2020 04:11:39 -0700 (PDT)","From":"David Plowman <david.plowman@raspberrypi.com>","To":"libcamera-devel@lists.libcamera.org","Date":"Thu, 30 Jul 2020 12:11:31 +0100","Message-Id":"<20200730111134.641-1-david.plowman@raspberrypi.com>","X-Mailer":"git-send-email 2.20.1","MIME-Version":"1.0","Subject":"[libcamera-devel] [PATCH 0/3] Raspberry Pi ALSC improvements","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"<libcamera-devel.lists.libcamera.org>","List-Unsubscribe":"<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>","List-Archive":"<https://lists.libcamera.org/pipermail/libcamera-devel/>","List-Post":"<mailto:libcamera-devel@lists.libcamera.org>","List-Help":"<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>","List-Subscribe":"<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>"},"content":"Hi\n\nWhile working on something else (namely transforms), I noticed a bug in\nour ALSC algorithm, as well as a couple of other perhaps overdue\nimprovements. As was pointed out, better to get these out of the way\nfirst and come back to transforms later!\n\nThere are 3 patches, the first being trivial.\n\n* The second patch resamples the luminance correction table, which\n  previously we weren't doing. This could have caused artifacts if any\n  camera modes were cropping heavily from the sensor.\n\n* The final patch improves switching between modes that crop very\n  differently from one another, effectively causing the algorithm to\n  start over and generate new initial tables (though without the\n  adaptive algorithm).\n\nHope that makes sense!\n\nThanks and best regards\nDavid\n\nDavid Plowman (3):\n  libcamera: ipa: raspberrypi: ALSC: Camera mode does not need to be\n    atomic\n  libcamera: ipa: raspberrypi: ALSC: Resample luminance table\n  libcamera: ipa: raspberrypi: ALSC: Improve behaviour when camera mode\n    changes\n\n src/ipa/raspberrypi/controller/rpi/alsc.cpp | 89 ++++++++++++++-------\n src/ipa/raspberrypi/controller/rpi/alsc.hpp |  5 +-\n 2 files changed, 64 insertions(+), 30 deletions(-)"}