{"id":8660,"url":"https://patchwork.libcamera.org/api/1.1/covers/8660/?format=json","web_url":"https://patchwork.libcamera.org/cover/8660/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/1.1/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20200706230240.2482100-1-kieran.bingham@ideasonboard.com>","date":"2020-07-06T23:02:32","name":"[libcamera-devel,v5,0/8] android: Multi-stream support","submitter":{"id":4,"url":"https://patchwork.libcamera.org/api/1.1/people/4/?format=json","name":"Kieran Bingham","email":"kieran.bingham@ideasonboard.com"},"mbox":"https://patchwork.libcamera.org/cover/8660/mbox/","series":[{"id":1089,"url":"https://patchwork.libcamera.org/api/1.1/series/1089/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=1089","date":"2020-07-06T23:02:32","name":"android: Multi-stream support","version":5,"mbox":"https://patchwork.libcamera.org/series/1089/mbox/"}],"comments":"https://patchwork.libcamera.org/api/covers/8660/comments/","headers":{"Return-Path":"<libcamera-devel-bounces@lists.libcamera.org>","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id EAA10BD792\n\tfor <parsemail@patchwork.libcamera.org>;\n\tMon,  6 Jul 2020 23:02:46 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 449BA60E56;\n\tTue,  7 Jul 2020 01:02:46 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id CE8F5603AD\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tTue,  7 Jul 2020 01:02:44 +0200 (CEST)","from Q.local (cpc89242-aztw30-2-0-cust488.18-1.cable.virginm.net\n\t[86.31.129.233])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 4985AAC6;\n\tTue,  7 Jul 2020 01:02:44 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"SP136cdl\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1594076564;\n\tbh=BXzRJUFsOY5XeGYC+LouveOuY0aRKM8q2s+wNnzhjIY=;\n\th=From:To:Cc:Subject:Date:From;\n\tb=SP136cdl/3Y4rzfXmp4DFeGORaw/7gqPYDDQznjgcyom2UpzJFzowG8DIbfBvAfy7\n\tMH5l5dgjZPkuYkvszfvAMR5St9GocnnJ0anGYvEEVVf+3QfMNOGdK4YtcCQezmefr8\n\tRWsZrx4YfYAnrhsD1OeHOguaQs8dQNjd/THpeO+E=","From":"Kieran Bingham <kieran.bingham@ideasonboard.com>","To":"libcamera devel <libcamera-devel@lists.libcamera.org>","Date":"Tue,  7 Jul 2020 00:02:32 +0100","Message-Id":"<20200706230240.2482100-1-kieran.bingham@ideasonboard.com>","X-Mailer":"git-send-email 2.25.1","MIME-Version":"1.0","Subject":"[libcamera-devel] [PATCH v5 0/8] android: Multi-stream support","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"<libcamera-devel.lists.libcamera.org>","List-Unsubscribe":"<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>","List-Archive":"<https://lists.libcamera.org/pipermail/libcamera-devel/>","List-Post":"<mailto:libcamera-devel@lists.libcamera.org>","List-Help":"<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>","List-Subscribe":"<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>"},"content":"A (final?) spin for the multi-stream support in the Android Camera HAL\ndue to v4 being a complete flop and causing a double-free of the\nRequest, where I'm afraid to say I had forgotten that the internal core\nhandles the cleanup of that object.\n\nAnyway, that's corrected in \"Create the Request and\nCamera3RequestDescriptor together\", and now the multiple-streams are\noperating again for me, where with some initial JPEG support on top, I\ncan successfully launch the native camera application again.\n\nKieran Bingham (8):\n  libcamera: camera: Allow unspecified roles for generateConfiguration\n  android: camera_device: Provide a toPixelFormat helper\n  android: camera_device: Support multiple stream configurations\n  android: camera_device: Simplify FrameBuffer construction from a\n    buffer_handle_t\n  android: camera_device: Create the Request and\n    Camera3RequestDescriptor together\n  android: camera_device: Maintain a vector of CameraStream\n  android: camera_device: Add buffers for each stream to Requests\n  android: camera_device: Remove single buffer restriction.\n\n include/libcamera/camera.h    |   2 +-\n src/android/camera_device.cpp | 183 +++++++++++++++++++++-------------\n src/android/camera_device.h   |  13 +++\n 3 files changed, 125 insertions(+), 73 deletions(-)"}