{"id":8481,"url":"https://patchwork.libcamera.org/api/1.1/covers/8481/?format=json","web_url":"https://patchwork.libcamera.org/cover/8481/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/1.1/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20200628190920.3206340-1-niklas.soderlund@ragnatech.se>","date":"2020-06-28T19:09:18","name":"[libcamera-devel,v3,0/2] libcamera: geometry: Add isNull() function to Size class","submitter":{"id":5,"url":"https://patchwork.libcamera.org/api/1.1/people/5/?format=json","name":"Niklas Söderlund","email":"niklas.soderlund@ragnatech.se"},"mbox":"https://patchwork.libcamera.org/cover/8481/mbox/","series":[{"id":1053,"url":"https://patchwork.libcamera.org/api/1.1/series/1053/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=1053","date":"2020-06-28T19:09:18","name":"libcamera: geometry: Add isNull() function to Size class","version":3,"mbox":"https://patchwork.libcamera.org/series/1053/mbox/"}],"comments":"https://patchwork.libcamera.org/api/covers/8481/comments/","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 60A93C2E69\n\tfor ;\n\tSun, 28 Jun 2020 19:09:31 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id A7D5C609E8;\n\tSun, 28 Jun 2020 21:09:30 +0200 (CEST)","from bin-mail-out-06.binero.net (bin-mail-out-06.binero.net\n\t[195.74.38.229])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 35EE8603B5\n\tfor ;\n\tSun, 28 Jun 2020 21:09:29 +0200 (CEST)","from bismarck.berto.se (p4fca2eca.dip0.t-ipconnect.de\n\t[79.202.46.202]) by bin-vsp-out-03.atm.binero.net (Halon) with ESMTPA\n\tid cc6f1397-b972-11ea-86ee-0050569116f7;\n\tSun, 28 Jun 2020 21:08:52 +0200 (CEST)"],"X-Halon-ID":"cc6f1397-b972-11ea-86ee-0050569116f7","Authorized-sender":"niklas@soderlund.pp.se","From":"=?utf-8?q?Niklas_S=C3=B6derlund?= ","To":"libcamera-devel@lists.libcamera.org","Date":"Sun, 28 Jun 2020 21:09:18 +0200","Message-Id":"<20200628190920.3206340-1-niklas.soderlund@ragnatech.se>","X-Mailer":"git-send-email 2.27.0","MIME-Version":"1.0","Subject":"[libcamera-devel] [PATCH v3 0/2] libcamera: geometry: Add isNull()\n\tfunction to Size class","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Content-Type":"text/plain; charset=\"utf-8\"","Content-Transfer-Encoding":"base64","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"Hi,\n\nThis is mainly Laurent's work I have just collected the tags and added a \nsmall patch on-top to make use of it in the IPU3 pipeline handler. I \nknow the name of the helper (isNull vs isZero vs isValid vs isEmpty) is \nstill debated but I did not wish to lose track of where in the CIO2 the \nhelper should be used disregarding its final name.\n\nIf I understand things correctly Laurent and myself prefer isNull() \nwhile Jacopo and Kieran seems fine with isNull() but would prefer \nisValid() and isZero() respectively. In other words the perfect bikeshed \nis almost built :-)\n\nLaurent Pinchart (1):\n libcamera: geometry: Add isNull() function to Size class\n\nNiklas Söderlund (1):\n libcamera: ipu3: cio2: Use Size::isNull()\n\n include/libcamera/geometry.h | 1 +\n src/libcamera/geometry.cpp | 6 ++++++\n src/libcamera/pipeline/ipu3/cio2.cpp | 2 +-\n test/geometry.cpp | 10 ++++++++++\n 4 files changed, 18 insertions(+), 1 deletion(-)"}