{"id":3467,"url":"https://patchwork.libcamera.org/api/1.1/covers/3467/?format=json","web_url":"https://patchwork.libcamera.org/cover/3467/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/1.1/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20200415150409.27938-1-email@uajain.com>","date":"2020-04-15T15:04:13","name":"[libcamera-devel,v2,0/2] Coverity scans fixes","submitter":{"id":1,"url":"https://patchwork.libcamera.org/api/1.1/people/1/?format=json","name":"Umang Jain","email":"email@uajain.com"},"mbox":"https://patchwork.libcamera.org/cover/3467/mbox/","series":[{"id":811,"url":"https://patchwork.libcamera.org/api/1.1/series/811/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=811","date":"2020-04-15T15:04:13","name":"Coverity scans fixes","version":2,"mbox":"https://patchwork.libcamera.org/series/811/mbox/"}],"comments":"https://patchwork.libcamera.org/api/covers/3467/comments/","headers":{"Return-Path":"","Received":["from o1.f.az.sendgrid.net (o1.f.az.sendgrid.net [208.117.55.132])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 6F4B960404\n\tfor ;\n\tWed, 15 Apr 2020 17:04:15 +0200 (CEST)","by filterdrecv-p3iad2-8ddf98858-mlrf4 with SMTP id\n\tfilterdrecv-p3iad2-8ddf98858-mlrf4-17-5E97226D-BE\n\t2020-04-15 15:04:13.805329486 +0000 UTC m=+1778201.553839166","from mail.uajain.com (unknown)\n\tby ismtpd0003p1hnd1.sendgrid.net (SG) with ESMTP\n\tid 3fxxwWEqTZ2-JkzqqoOb0w Wed, 15 Apr 2020 15:04:13.451 +0000 (UTC)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=uajain.com\n\theader.i=@uajain.com header.b=\"X7yGy1oU\"; \n\tdkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=uajain.com;\n\th=from:subject:mime-version:to:cc:content-transfer-encoding:\n\tcontent-type;\n\ts=s1; bh=E3O98DfBXAtWtGbf+FWVZZj1QfwdZVnI//e59OY8fe0=;\n\tb=X7yGy1oUPdYOyQEviSPN1hmhd0sJdaBqFFHdp17LjJbDLda51Wh+HWODTyBPvdm3ZQeA\n\t+UW5FD5dhSDj/0K0L5iG++qQrRDl5yiKX5onPwhEkD0NuDT33e7Av8AV0ZH24e81/tq2fL\n\t5K0V6/Yd48vp8Ot/AmGBmhoVnbRfBXUIo=","From":"Umang Jain ","Date":"Wed, 15 Apr 2020 15:04:13 +0000 (UTC)","Message-Id":"<20200415150409.27938-1-email@uajain.com>","Mime-Version":"1.0","X-SG-EID":"1Q40EQ7YGir8a9gjSIAdTjhngY657NMk9ckeo4dbHZDiOpywc/L3L9rFqlwE4KPcROc560Os82e1tQwAlD2FoHisHuJE98kRxDLCgvedkPMRumuwfRwTyOIXRT0F7uoPj+XMSBOYXjU7lMr+eTGlkti+cu8J2Zi//JMEE1jKH/qGDDIRQArq8WhfBAQYj8KYg5a1l3i0N6GA5jybBp74mW5q/mjmRGyT8KfizT7uuTY/wlaKGp4/1t52etwpMTjsIX7pwQEmt1HHzrrWRbkEiw==","To":"libcamera-devel@lists.libcamera.org","Content-Transfer-Encoding":"7bit","Content-Type":"text/plain; charset=us-ascii","Subject":"[libcamera-devel] [PATCH v2 0/2] Coverity scans fixes","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","X-List-Received-Date":"Wed, 15 Apr 2020 15:04:16 -0000"},"content":"This is the v2 for initial covierity scan fixes I sent.\nChangelog:\n* test: ipc: unixsocket: Close open fds on error paths\n - Use of FileDescriptor as asked by Laurent. I found this to be a bit\n tricky and I am not sure if opening new fds in prepareFDs, frees them down\n the line. The tests states comments like \"Test fire and forget\" so I am not\n sure what's the level of pedanticism we need. Happy to re-work though.\n* test: log: log_api: Close open fds on error paths\n - Cleanup logSetFile(path) error path too as pointed out by Kieran.\n\nUmang Jain (2):\n test: ipc: unixsocket: Close open fds on error paths\n test: log: log_api: Close open fds on error paths\n\n test/ipc/unixsocket.cpp | 19 ++++++++++++-------\n test/log/log_api.cpp | 2 ++\n 2 files changed, 14 insertions(+), 7 deletions(-)"}