{"id":3243,"url":"https://patchwork.libcamera.org/api/1.1/covers/3243/?format=json","web_url":"https://patchwork.libcamera.org/cover/3243/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/1.1/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20200323142205.28342-1-laurent.pinchart@ideasonboard.com>","date":"2020-03-23T14:21:44","name":"[libcamera-devel,00/21] qcam: Bypass format conversion when not required","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/1.1/people/2/?format=json","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"mbox":"https://patchwork.libcamera.org/cover/3243/mbox/","series":[{"id":760,"url":"https://patchwork.libcamera.org/api/1.1/series/760/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=760","date":"2020-03-23T14:21:44","name":"qcam: Bypass format conversion when not required","version":1,"mbox":"https://patchwork.libcamera.org/series/760/mbox/"}],"comments":"https://patchwork.libcamera.org/api/covers/3243/comments/","headers":{"Return-Path":"","Received":["from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 7B9B16041A\n\tfor ;\n\tMon, 23 Mar 2020 15:22:18 +0100 (CET)","from pendragon.bb.dnainternet.fi (81-175-216-236.bb.dnainternet.fi\n\t[81.175.216.236])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 06917308\n\tfor ;\n\tMon, 23 Mar 2020 15:22:17 +0100 (CET)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1584973338;\n\tbh=oJTvhzRZk2EMJ/GcM3KBGUExcnaJnGquZFAfmfA5cDk=;\n\th=From:To:Subject:Date:From;\n\tb=fMm/I5oU0a8mz0xjJuNlDSWGKsOh+1RpzBTlyGe55XTxCjiadGdSLivne0v9erqiX\n\tyelPCDklgwLB4Y/ZmgBL9Ae9NDCUSOKg/+Z7b3uy7gTCjadvD1nfupLhAPW1DPv6aT\n\t/rjKXuYHCCiIdmMCZuxkZX9782+ggtViOWWswMBg=","From":"Laurent Pinchart ","To":"libcamera-devel@lists.libcamera.org","Date":"Mon, 23 Mar 2020 16:21:44 +0200","Message-Id":"<20200323142205.28342-1-laurent.pinchart@ideasonboard.com>","X-Mailer":"git-send-email 2.24.1","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","Subject":"[libcamera-devel] [PATCH 00/21] qcam: Bypass format conversion when\n\tnot required","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","X-List-Received-Date":"Mon, 23 Mar 2020 14:22:18 -0000"},"content":"Hello,\n\nThis small patch series improves performances in qcam when the captured\nformat matches one of the formats natively supported by the viewfinder.\nIt allows skipping conversion and using zero-copy in that case.\n\nThe series includes a few miscellaneous drive-by fixes and improvements\nthat are documented in individual patches from 01/21 to 12/21. From\n13/21 onwards the viewfinder code is refactored, and patch 19/21 adds\nzero-copy support. Patch 20/21 fixes an isse where the last buffer isn't\nreleased when stopping capture (it could be squashed with 19/21, but I\ndecided to submit it separately for now to ease review).\n\nPatch 21/21 finally adds support for more native RGB formats in the\nviewfinder, and in particular for DRM_FORMAT_BGR888 that the VIMC\npipeline handler defaults to. BGR888 however requires Qt 5.14, which\nisn't widely shipped by distros, so it's disabled if the Qt version is\ntoo old.\n\nLaurent Pinchart (21):\n qcam: Remove custom event dispatcher\n qcam: Ensure headers are self-contained\n qcam: Use QSize through the code base\n qcam: main_window: Move request queuing to a separate function\n qcam: main_window: Move capture event processing to main thread\n qcam: main_window: Replace start and stop actions with a toggle action\n qcam: main_window: Use icons from system icon theme\n qcam: main_window: Add shortcuts for toolbar actions\n qcam: main_window: Don't print message when saving a picture\n qcam: main_window: Document functions and reorganize member data\n qcam: main_window: Remove unneeded debug message\n qcam: Use Qt qInfo() and qWarning() logging facilities\n qcam: viewfinder: Add MappedBuffer to store memory mapping information\n qcam: viewfinder: Move multi-planar check into viewfinder\n qcam: viewfinder: Make the viewfinder hold a reference to a buffer\n qcam: viewfinder: Embed QImage in ViewFinder\n qcam: viewfinder: Use PixelFormat default constructor\n qcam: viewfinder: Reorder methods to match header file\n qcam: viewfinder: Avoid memory copy when conversion isn't needed\n qcam: viewfinder: Display icon when stopping capture\n qcam: viewfinder: Add support for more native formats\n\n src/qcam/assets/feathericons/feathericons.qrc | 1 +\n src/qcam/format_converter.cpp | 10 +-\n src/qcam/format_converter.h | 5 +-\n src/qcam/main.cpp | 11 +-\n src/qcam/main_window.cpp | 272 +++++++++++++-----\n src/qcam/main_window.h | 38 ++-\n src/qcam/meson.build | 2 +-\n src/qcam/qt_event_dispatcher.cpp | 152 ----------\n src/qcam/qt_event_dispatcher.h | 62 ----\n src/qcam/viewfinder.cpp | 140 +++++++--\n src/qcam/viewfinder.h | 36 ++-\n 11 files changed, 377 insertions(+), 352 deletions(-)\n delete mode 100644 src/qcam/qt_event_dispatcher.cpp\n delete mode 100644 src/qcam/qt_event_dispatcher.h"}