{"id":280,"url":"https://patchwork.libcamera.org/api/1.1/covers/280/?format=json","web_url":"https://patchwork.libcamera.org/cover/280/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/1.1/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20190121005930.10112-1-laurent.pinchart@ideasonboard.com>","date":"2019-01-21T00:59:24","name":"[libcamera-devel,0/6] Extend the logger with categories and configuration","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/1.1/people/2/?format=json","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"mbox":"https://patchwork.libcamera.org/cover/280/mbox/","series":[{"id":96,"url":"https://patchwork.libcamera.org/api/1.1/series/96/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=96","date":"2019-01-21T00:59:24","name":"Extend the logger with categories and configuration","version":1,"mbox":"https://patchwork.libcamera.org/series/96/mbox/"}],"comments":"https://patchwork.libcamera.org/api/covers/280/comments/","headers":{"Return-Path":"","Received":["from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id E33BD60C6A\n\tfor ;\n\tMon, 21 Jan 2019 01:59:34 +0100 (CET)","from pendragon.bb.dnainternet.fi\n\t(dfj612yhrgyx302h3jwwy-3.rev.dnainternet.fi\n\t[IPv6:2001:14ba:21f5:5b00:ce28:277f:58d7:3ca4])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 6999BD6C\n\tfor ;\n\tMon, 21 Jan 2019 01:59:34 +0100 (CET)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1548032374;\n\tbh=qSEzLIn4j8DjMOBfyvwJDkzEe6hFC7E7d9PIwgVWowo=;\n\th=From:To:Subject:Date:From;\n\tb=HSVQXlPN5M/hYiWk8kKezX5jLe/Q+zw7FnGiwfC4dHF+R8Nf5u5OZK7xtjcVd+kp+\n\tuqK6Uj+AiFOhuIi050LLU+kAoS3vWveuJf9DRqfMPF+ZMuAOxtpYEiLlbtmPI+x+cl\n\tTSCGAs0K/0gjXX5J2fK/R+tojtLRhXVznOWMvKtU=","From":"Laurent Pinchart ","To":"libcamera-devel@lists.libcamera.org","Date":"Mon, 21 Jan 2019 02:59:24 +0200","Message-Id":"<20190121005930.10112-1-laurent.pinchart@ideasonboard.com>","X-Mailer":"git-send-email 2.19.2","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","Subject":"[libcamera-devel] [PATCH 0/6] Extend the logger with categories and\n\tconfiguration","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.23","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","X-List-Received-Date":"Mon, 21 Jan 2019 00:59:35 -0000"},"content":"Hello,\n\nThis patch series extends the logging infrastructure with support for\nlogging categories, and implements configuration of the logger from\nenvironment variables.\n\nThe series starts with two unrelated patches that are quite\nself-explicit. It then moves on to add log categories in patch 3/6, and\nconfiguration of log levels and log output file in patches 4/6 and 5/6\nrespectively. Patch 6/6 finally updates all LOG() calls to make use of\ncategories.\n\nThere are still a few points I'm not entirely happy with:\n\n- I would like the LOG() macro to automatically log to the category\n defined with LOG_DEFINE_CATEGORY() (or declared with\n LOG_DECLARE_CATEGORY()) when the compilation unit has a single\n category declared (or possibly the first or last category declared\n when there are several). I haven't found a good way to implement this.\n\n- A test case for log environment variables parsing would be nice, but\n that's hard to do as the implementation is very private.\n\n- Patch 6/6 heavily violates checkstyle.py. I think our astyle style\n should be updated, but I haven't checked whether that is doable.\n Bonus points if someone beats me to it.\n\nThe first two items are not blockers in my opinion, the last one is more\nproblematic.\n\nLaurent Pinchart (6):\n Documentation: coding_style: Add move semantics to C++11 features\n libcamera: signal: Enable documentation generation from signal.h file\n libcamera: log: Add log categories\n libcamera: log: Get log levels from the environment\n libcamera: log: Get log output file from the environment\n libcamera: Use log categories\n\n Documentation/coding-style.rst | 1 +\n src/libcamera/camera_manager.cpp | 14 +-\n src/libcamera/device_enumerator.cpp | 25 +-\n src/libcamera/event_dispatcher.cpp | 4 +\n src/libcamera/event_dispatcher_poll.cpp | 28 +-\n src/libcamera/include/log.h | 45 ++-\n src/libcamera/log.cpp | 460 ++++++++++++++++++++++--\n src/libcamera/media_device.cpp | 48 +--\n src/libcamera/media_object.cpp | 7 +-\n src/libcamera/pipeline_handler.cpp | 5 +-\n src/libcamera/signal.cpp | 5 +\n src/libcamera/timer.cpp | 6 +-\n src/libcamera/v4l2_device.cpp | 25 +-\n 13 files changed, 574 insertions(+), 99 deletions(-)"}