{"id":27308,"url":"https://patchwork.libcamera.org/api/1.1/covers/27308/?format=json","web_url":"https://patchwork.libcamera.org/cover/27308/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/1.1/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20260708-libipa-algorithms-v5-0-0759d0359f52@ideasonboard.com>","date":"2026-07-08T15:50:42","name":"[v5,00/36] ipa: libipa: Introduce libipa algorithms","submitter":{"id":143,"url":"https://patchwork.libcamera.org/api/1.1/people/143/?format=json","name":"Jacopo Mondi","email":"jacopo.mondi@ideasonboard.com"},"mbox":"https://patchwork.libcamera.org/cover/27308/mbox/","series":[{"id":6048,"url":"https://patchwork.libcamera.org/api/1.1/series/6048/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=6048","date":"2026-07-08T15:50:42","name":"ipa: libipa: Introduce libipa algorithms","version":5,"mbox":"https://patchwork.libcamera.org/series/6048/mbox/"}],"comments":"https://patchwork.libcamera.org/api/covers/27308/comments/","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id F3A09C3261\n\tfor ;\n\tWed, 8 Jul 2026 15:51:14 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 8230166094;\n\tWed, 8 Jul 2026 17:51:13 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 1BB6A61451\n\tfor ;\n\tWed, 8 Jul 2026 17:51:12 +0200 (CEST)","from [192.168.1.182] (93-46-82-201.ip106.fastwebnet.it\n\t[93.46.82.201])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id CA015EAA;\n\tWed, 8 Jul 2026 17:50:21 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"bGpz7MPy\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1783525822;\n\tbh=BIHsi+/Ew4Cqz6CANnM1yZWqpfV9zUOaFMhaBDLmnvs=;\n\th=From:Subject:Date:To:Cc:From;\n\tb=bGpz7MPy9kxrZqA3kN/e0bBA74Vf2JZL8ojutDQhDW/kSDq+b3QGU+LsRSNoPwI9b\n\t831HAHfdKZzLBnU5LVqaJEDFSZ8b4NVZmofAWlxwt4MR0t5bYQhewrlihS5JKFIH8H\n\t7C17AhtEwYNeVb6Ym8BTVvWwNP4w6k0UGeeRvTVQ=","From":"Jacopo Mondi ","Subject":"[PATCH v5 00/36] ipa: libipa: Introduce libipa algorithms","Date":"Wed, 08 Jul 2026 17:50:42 +0200","Message-Id":"<20260708-libipa-algorithms-v5-0-0759d0359f52@ideasonboard.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=\"utf-8\"","Content-Transfer-Encoding":"7bit","X-B4-Tracking":"v=1; b=H4sIANNxTmoC/33OO27DMAyA4asEmqtCpl5mpt6j6CDZVEwgsQIpM\n\tFoEvnvlLM3gdPwJ8CPvolJhquJ4uItCC1fOcwv7dhDDFOYTSR5bC1DglOusPHPka5DhfMqFb9O\n\tlSovOuTgEFSCJtnctlPj7YX5+tZ643nL5eZxYum36n7Z0UklCgwNqbwDog0cKNc8xhzK+D/kiN\n\tnSBJwj0HgQNSuiN1qkDMq8g/Qd55fYg3SB0vbc+Kt3H+AIyz1C/B5ntI0WISWkLaHagdV1/ASW\n\tS5fiUAQAA","X-Change-ID":"20260615-libipa-algorithms-59666bca0a2f","To":"libcamera-devel@lists.libcamera.org, \n\tStefan Klug ","Cc":"Jacopo Mondi , \n\tKieran Bingham , \n\tDaniel Scally , \n\tRobert Mader , \n\tLaurent Pinchart ","X-Mailer":"b4 0.14.3","X-Developer-Signature":"v=1; a=openpgp-sha256; l=7208;\n\ti=jacopo.mondi@ideasonboard.com; h=from:subject:message-id;\n\tbh=BIHsi+/Ew4Cqz6CANnM1yZWqpfV9zUOaFMhaBDLmnvs=;\n\tb=owEBbQKS/ZANAwAKAXI0Bo8WoVY8AcsmYgBqTnHfCQ9I4pa/tmhbFSSpqgzOzsa8dKiH6GLZO\n\t1QhHlQ47mqJAjMEAAEKAB0WIQS1xD1IgJogio9YOMByNAaPFqFWPAUCak5x3wAKCRByNAaPFqFW\n\tPNv7D/9H6EaNksJwBsFC3HJoQMR+dgWMoeNVq56CzuODx+7hosu+QU/dtxVBeIW/pv45YmLZ8De\n\t+VTldg8wowMtEUzASbmtJLGWkhN2EhvoAWj60OYM9JB4VBi4U4snOk2vgOaD33hRoR5jbPk7RV7\n\to8vacasa98BV8NlYUWRYy9KkHWHfSJi3yUfhzbKvcNNN34mtDFXWkD2/LLkJbJ33O1OQxk/yRLr\n\thxlKBzlDKJvmpJRqfLQjtf+GVqa9toPfwwWFFjtnk1AfW3fpYdQXeVYhKzVCJ2zk7Rbxx3hBMRH\n\tRCKOppSpQ0WfLKIsbPX5utu2nCB38qg5nHWfvJdIu1JaMB7iJwuZAFE18YebMNsGybeRlQlo+zv\n\t/kbMPTCQpd0TZL1HNiiJTQWLUpgZ5yYGMPnu08V0XdBDr6HjAbbZGQIYaH4gpcAeTAasQTK2kR6\n\tnYZAzqGtZW80gGy11eSEV5wpI5upTIP5gZNZTknBeVbCBp+wLlXXZtkWoeuvUjoUdxtApX+W70V\n\t22YwIqMGf3AAfgUolg+OzuA4wcnqeE6UjGTVAn9MDOfUJnigd/PqxnYzMLNr45NLnNVWLDGfzqW\n\t0+ERqPImb6D/nfP889QPw75tzlD/ExjUNt+0OC6arv53P2knW4c0ldsdxTqxyYaDRyqQh9mYPgN\n\tz5IJoKGWLqeY4iA==","X-Developer-Key":"i=jacopo.mondi@ideasonboard.com; a=openpgp;\n\tfpr=72392EDC88144A65C701EA9BA5826A2587AD026B","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"This series introduces the first algorithms in libipa: Awb, Lsc and Ccm.\n\nAs most of the implementations of the common algorithms derive from\nRkISP1 it wasn't possible to separate the algorithm introduction with\nthe RkISP1 IPA modifications to maintain bisectability.\n\nThis series contains:\n\n- Awb (Grey and Bayes)\n - RkISP1\n - Simple\n - Mali-C55\n\n- Ccm\n - RkISP1\n - Simple\n - Mali-C55\n\n- Lsc (grid and polynomial)\n - RkISP1\n - Mali-C55\n\nTested on RkISP1 with imx219 (Grey world awb and grid-based LSC) and on\nMali-C55 with imx708 (Bayes AWB and grid-based LSC).\n\nMore test on Simple and with polynomial LSC would be helpful :)\n\nSigned-off-by: Jacopo Mondi \n---\nChanges in v5:\n- Add \"ipa: libipa: lsc_polynomial: Fix polynomial parsing error\"\n to fix and exiting potential issue with Polynomial parsing\n- Fix Simple, which I broke in v4, thanks Milan\n- Link to v4: https://lore.kernel.org/r/20260708-libipa-algorithms-v4-0-f0e99f035294@ideasonboard.com\n\nChanges in v4:\n- s/awb/AWB in comments everywhere, same for CCM and LSC\n- Awb: changelog per patch\n - Make AwbStats pure virtual and move stats parsing logic to the IPA\n modules\n - Reduce comments/renames to reduce patch size and comments\n- Collect tags\n\nChanges in v3:\n- Address comments on Awb from Stefan:\n - Introduce AwbImplementation::Result\n - Move AwbStats implementation to IPAs\n - Drop AwbStats::rg()/bg() and re-implement AwbGray accordingly\n- Fix Saturation bug in Simple Ccm algorithm\n- Fix Simple Ccm gain limits using Q<2, 8>\n- Update Mali CCM and Gamma to latest uAPI patch version\n- Fix Mali CCM gain masking as reported by Dan\n- Break down libIPA Lsc implementation as requested by Stefan\n\nChanges in v2:\n- Introduce awb::Context to simplify ActiveState and FrameContext\n definition\n- Add mali uAPI header for CCM and Gamma\n- Do not rename Mali functions for hardware configuration in awb and lsc\n- Spelling and documentation\n\n---\nJacopo Mondi (33):\n ipa: libipa: awb: Reimplement AwbAlgorithm\n ipa: mali-c55: awb: Port to use libipa AwbAlgorithm\n ipa: libipa: Add CcmAlgorithm to libipa\n ipa: rkisp1: ccm: Port to use CcmAlgorithm\n include: linux: mali-c55: Update to support CCM and Gamma\n ipa: mali-c55: Implement Ccm algorithm\n ipa: rkisp1: lsc: Re-architecture Lsc support\n ipa: libipa: Introduce lsc_base.h\n ipa: libipa: lsc_polynomial: Fix polynomial parsing error\n ipa: libipa: lsc_polynomial: Rename LscPolynomial\n ipa: libipa: lsc_polynomial: Do not inline functions\n ipa: libipa: lsc: Move Interpolator to lsc_base\n ipa: rkisp1: lsc: Remove rogue empty line\n ipa: libipa: lsc_polynomial: Move LscPolynomial from RkISP1\n ipa: libipa: lsc_table: Move LscTable from RkISP1\n ipa: libipa: lsc_base: Add sampleForCrop documentation\n ipa: rksip1: lsc: Make parseSizes() a class function\n ipa: libipa: lsc: Introduce lsc::ActiveState\n ipa: libipa: lsc: Introduce lsc::FrameContext\n ipa: libipa: lsc: Introduce LscAlgorithm\n ipa: libipa: lsc: Move sizesListToPositions() back to rkisp1\n ipa: rkisp1: lsc: Port to use LscAlgorithm\n ipa: libipa: lsc: Make Components a map<>\n ipa: libipa: lsc: Document Components parsing\n ipa: libipa: lsc_polynomial: Remove sensorSize_\n ipa: libipa: lsc: Document LscDescriptor::sensorSize usage\n ipa: libipa: lsc: Template LscAlgorithm with register format\n ipa: libipa: lsc_base: Describe the function of lsc_base\n ipa: libipa: lsc: Template lsc::Components\n ipa: libipa: lsc: Rename sampleForCrop to resampleLscData\n ipa: libipa: lsc: Specialize Interpolator for uint8_t\n ipa: mali-c55: Add sensorInfo to IPAContext\n ipa: mali-c55: Port to use LscAlgorithm\n\nKieran Bingham (2):\n ipa: simple: awb: Port to use libipa AwbAlgorithm\n ipa: simple: Use libipa CcmAlgorithm\n\nLaurent Pinchart (1):\n ipa: libipa: lsc_polynomial: Don't inline ValueNode accessor\n\n .../internal/software_isp/debayer_params.h | 4 +-\n include/linux/media/arm/mali-c55-config.h | 86 +++-\n src/ipa/libipa/awb.cpp | 418 +++++++++++++++++---\n src/ipa/libipa/awb.h | 100 ++++-\n src/ipa/libipa/awb_bayes.cpp | 52 +--\n src/ipa/libipa/awb_bayes.h | 12 +-\n src/ipa/libipa/awb_grey.cpp | 16 +-\n src/ipa/libipa/awb_grey.h | 6 +-\n src/ipa/libipa/ccm.cpp | 245 ++++++++++++\n src/ipa/libipa/ccm.h | 77 ++++\n src/ipa/libipa/lsc.cpp | 311 +++++++++++++++\n src/ipa/libipa/lsc.h | 137 +++++++\n src/ipa/libipa/lsc_base.cpp | 178 +++++++++\n src/ipa/libipa/lsc_base.h | 90 +++++\n src/ipa/libipa/lsc_polynomial.cpp | 177 ++++++++-\n src/ipa/libipa/lsc_polynomial.h | 152 +++++---\n src/ipa/libipa/lsc_table.cpp | 40 ++\n src/ipa/libipa/lsc_table.h | 118 ++++++\n src/ipa/libipa/meson.build | 8 +\n src/ipa/mali-c55/algorithms/awb.cpp | 223 ++++++-----\n src/ipa/mali-c55/algorithms/awb.h | 28 +-\n src/ipa/mali-c55/algorithms/ccm.cpp | 173 +++++++++\n src/ipa/mali-c55/algorithms/ccm.h | 66 ++++\n src/ipa/mali-c55/algorithms/lsc.cpp | 156 +++++---\n src/ipa/mali-c55/algorithms/lsc.h | 32 +-\n src/ipa/mali-c55/algorithms/meson.build | 1 +\n src/ipa/mali-c55/ipa_context.cpp | 3 +\n src/ipa/mali-c55/ipa_context.h | 20 +-\n src/ipa/mali-c55/mali-c55.cpp | 2 +\n src/ipa/mali-c55/params.h | 2 +\n src/ipa/rkisp1/algorithms/awb.cpp | 191 ++-------\n src/ipa/rkisp1/algorithms/awb.h | 18 +-\n src/ipa/rkisp1/algorithms/ccm.cpp | 97 +----\n src/ipa/rkisp1/algorithms/ccm.h | 17 +-\n src/ipa/rkisp1/algorithms/lsc.cpp | 432 +++------------------\n src/ipa/rkisp1/algorithms/lsc.h | 41 +-\n src/ipa/rkisp1/ipa_context.h | 49 +--\n src/ipa/simple/algorithms/awb.cpp | 141 +++++--\n src/ipa/simple/algorithms/awb.h | 29 ++\n src/ipa/simple/algorithms/blc.cpp | 2 +-\n src/ipa/simple/algorithms/ccm.cpp | 72 ++--\n src/ipa/simple/algorithms/ccm.h | 23 +-\n src/ipa/simple/ipa_context.h | 15 +-\n src/libcamera/software_isp/debayer_cpu.cpp | 12 +-\n 44 files changed, 2945 insertions(+), 1127 deletions(-)\n---\nbase-commit: 709ad59a8d90af3570be1c8d02dee0ec9e011954\nchange-id: 20260615-libipa-algorithms-59666bca0a2f\n\nBest regards,"}