{"id":2674,"url":"https://patchwork.libcamera.org/api/1.1/covers/2674/?format=json","web_url":"https://patchwork.libcamera.org/cover/2674/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/1.1/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20200118200015.16531-1-nicolas@ndufresne.ca>","date":"2020-01-18T20:00:09","name":"[libcamera-devel,v4,0/6] Add the ability to do pre-commit style check","submitter":{"id":30,"url":"https://patchwork.libcamera.org/api/1.1/people/30/?format=json","name":"Nicolas Dufresne","email":"nicolas@ndufresne.ca"},"mbox":"https://patchwork.libcamera.org/cover/2674/mbox/","series":[{"id":636,"url":"https://patchwork.libcamera.org/api/1.1/series/636/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=636","date":"2020-01-18T20:00:09","name":"Add the ability to do pre-commit style check","version":4,"mbox":"https://patchwork.libcamera.org/series/636/mbox/"}],"comments":"https://patchwork.libcamera.org/api/covers/2674/comments/","headers":{"Return-Path":"","Received":["from bhuna.collabora.co.uk (bhuna.collabora.co.uk\n\t[IPv6:2a00:1098:0:82:1000:25:2eeb:e3e3])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 743E060455\n\tfor ;\n\tSat, 18 Jan 2020 21:02:42 +0100 (CET)","from nicolas-tpx395.localdomain (unknown\n\t[IPv6:2002:c0de:c115:0:66fc:8b:2a38:8313])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256\n\tbits))\n\t(No client certificate requested) (Authenticated sender: nicolas)\n\tby bhuna.collabora.co.uk (Postfix) with ESMTPSA id 0D8582911C1;\n\tSat, 18 Jan 2020 20:02:40 +0000 (GMT)"],"From":"Nicolas Dufresne ","To":"libcamera-devel@lists.libcamera.org","Cc":"Nicolas Dufresne ","Date":"Sat, 18 Jan 2020 15:00:09 -0500","Message-Id":"<20200118200015.16531-1-nicolas@ndufresne.ca>","X-Mailer":"git-send-email 2.24.1","MIME-Version":"1.0","Content-Type":"text/plain; charset=UTF-8","Content-Transfer-Encoding":"8bit","Subject":"[libcamera-devel] [PATCH v4 0/6] Add the ability to do pre-commit\n\tstyle check","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","X-List-Received-Date":"Sat, 18 Jan 2020 20:02:42 -0000"},"content":"From: Nicolas Dufresne \n\nThis series adds the ability to do pre-commit style check. Internally, this adds\nthe ability to use checkstyle.py to check staged changes (--staged) and the\ncombined changes of the index and the last commit (--amend).\n\nChanges in v4:\n - Patch 1 and 2 are unchanged\n - Unused top_level parameter removed from get_info() (patch 3 to 4)\n - revlist renamed to commits in main (patch 3)\n - Removed uneeded get_file() override by using empty string commit (patch 4)\n - Chain to StagedChanges constructor in Amendment class (patch 5)\n - Use \"--no-patch\" to reduce overhead of creating Amendment subject (patch 5)\n - Corrected the documentation in the pre-commit hook (patch 6)\n - Use tabs and minor style fix in pre-commit hook (patch 6)\n - Fixed all grammar mistake found by Laurent (all over)\n\nChanges in v3:\n - Patch 1 is unchanged\n - Remove yet another mode change (patch 2)\n - The return statement has been improved (patch 2)\n - Static member 'commit' has been removed from Commit class (patch 3)\n - A comment clarifies the return value of Commit.get_info() (patch 3)\n - extract_revlist() has been renamed extract_commits() (patch 3)\n - Index class is now named StagedChanges (patch 4)\n - If statement to set the default revision_range has been improve (patch 4)\n - Typo Amandment.det_info() is fixed to get_info() (patch 5)\n - Description of --amend has been fixed (patch 5)\n - Fixed commit->args variable name (patch 6)\n\nChanges in v2:\n - Fixed the checkstyle.py mode\n - Split into smaller patches\n - Only pass 0 or 1 to exit()\n - Replace boolean \"staged\" parameter with a Commit object\n - Subclass Commit to introduce special cases for Index and Amendment\n - Introduce a argument \"--amend\" to disambeguate the CLI \n\nNicolas Dufresne (6):\n checkstyle: Move from pep8 to pycodestyle\n checkstyle: Exit with 1 status if issues are found\n checkstyle: Introduce a Commit class\n checkstyle: Add support for checking style on staged changes\n checkstyle: Add support for checking style on amendments\n checkstyle: Add a pre-commit hook script\n\n utils/checkstyle.py | 118 +++++++++++++++++++++++++++++++++--------\n utils/hooks/pre-commit | 18 +++++++\n 2 files changed, 113 insertions(+), 23 deletions(-)\n create mode 100755 utils/hooks/pre-commit"}