{"id":2660,"url":"https://patchwork.libcamera.org/api/1.1/covers/2660/?format=json","web_url":"https://patchwork.libcamera.org/cover/2660/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/1.1/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20200117191733.198897-1-nicolas@ndufresne.ca>","date":"2020-01-17T19:17:27","name":"[libcamera-devel,v2,0/6] Add the ability to do pre-commit style check","submitter":{"id":30,"url":"https://patchwork.libcamera.org/api/1.1/people/30/?format=json","name":"Nicolas Dufresne","email":"nicolas@ndufresne.ca"},"mbox":"https://patchwork.libcamera.org/cover/2660/mbox/","series":[{"id":634,"url":"https://patchwork.libcamera.org/api/1.1/series/634/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=634","date":"2020-01-17T19:17:27","name":"Add the ability to do pre-commit style check","version":2,"mbox":"https://patchwork.libcamera.org/series/634/mbox/"}],"comments":"https://patchwork.libcamera.org/api/covers/2660/comments/","headers":{"Return-Path":"","Received":["from bhuna.collabora.co.uk (bhuna.collabora.co.uk [46.235.227.227])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id D159860456\n\tfor ;\n\tFri, 17 Jan 2020 20:17:51 +0100 (CET)","from nicolas-tpx395.localdomain (unknown [IPv6:2610:98:8005::127])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256\n\tbits))\n\t(No client certificate requested) (Authenticated sender: nicolas)\n\tby bhuna.collabora.co.uk (Postfix) with ESMTPSA id 274952949D4;\n\tFri, 17 Jan 2020 19:17:51 +0000 (GMT)"],"From":"Nicolas Dufresne ","To":"libcamera-devel@lists.libcamera.org","Cc":"Nicolas Dufresne ","Date":"Fri, 17 Jan 2020 14:17:27 -0500","Message-Id":"<20200117191733.198897-1-nicolas@ndufresne.ca>","X-Mailer":"git-send-email 2.24.1","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","Subject":"[libcamera-devel] [PATCH v2 0/6] Add the ability to do pre-commit\n\tstyle check","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","X-List-Received-Date":"Fri, 17 Jan 2020 19:17:52 -0000"},"content":"From: Nicolas Dufresne \n\nThis series adds the ability to do pre-commit style check. Internally, this adds\nthe ability to use checkstyle.py to check index changes (--staged) and the combined\nchanges the index changes and the last commit (--amend).\n\nHopefully I have covered all the review comments, note that I ended up\nrefactoring a lot with hope this is cleaner and less ambiguous.\n\nChanges in v2:\n - Fixed the checkstyle.py mode\n - Split into smaller patches\n - Only pass 0 or 1 to exit()\n - Replace boolean \"staged\" parameter with a Commit object\n - Subclass Commit to introduce special cases for Index and Amendment\n - Introduce a argument \"--amend\" to disambeguate the CLI \n\nNicolas Dufresne (6):\n checkstyle: Move from pep8 to pycodestyle\n checkstyle: Exit with 1 status if issues are found\n checkstyle: Introduce a Commit class\n checkstyle: Add support for checking style on indexed changes\n checkstyle: Add support for checking style on amendments\n checkstyle: Add a pre-commit hook script\n\n utils/checkstyle.py | 114 +++++++++++++++++++++++++++++++++--------\n utils/hooks/pre-commit | 17 ++++++\n 2 files changed, 110 insertions(+), 21 deletions(-)\n create mode 100755 utils/hooks/pre-commit"}