{"id":26192,"url":"https://patchwork.libcamera.org/api/1.1/covers/26192/?format=json","web_url":"https://patchwork.libcamera.org/cover/26192/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/1.1/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20260219144040.1615042-1-laurent.pinchart@ideasonboard.com>","date":"2026-02-19T14:40:36","name":"[v3,0/4] libcamera: Clean up iterators","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/1.1/people/2/?format=json","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"mbox":"https://patchwork.libcamera.org/cover/26192/mbox/","series":[{"id":5801,"url":"https://patchwork.libcamera.org/api/1.1/series/5801/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=5801","date":"2026-02-19T14:40:36","name":"libcamera: Clean up iterators","version":3,"mbox":"https://patchwork.libcamera.org/series/5801/mbox/"}],"comments":"https://patchwork.libcamera.org/api/covers/26192/comments/","headers":{"Return-Path":"<libcamera-devel-bounces@lists.libcamera.org>","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id BFF93C31E9\n\tfor <parsemail@patchwork.libcamera.org>;\n\tThu, 19 Feb 2026 14:40:46 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 1B7A86224F;\n\tThu, 19 Feb 2026 15:40:46 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 1EEC3620C9\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tThu, 19 Feb 2026 15:40:44 +0100 (CET)","from killaraus.ideasonboard.com (unknown [83.245.237.175])\n\tby perceval.ideasonboard.com (Postfix) with UTF8SMTPSA id B24344D3\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tThu, 19 Feb 2026 15:39:50 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"oCQcumWF\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1771511991;\n\tbh=tlMFliMO6Ksm3PAKl8EU3/oBfkE+oVXd29NXIvTHllA=;\n\th=From:To:Subject:Date:From;\n\tb=oCQcumWFJyQtGCBCva9mrEOgBbrmFCfJfhZgbZT9THSvpSOzQLJFnJufCuH9J89SH\n\txKfuPHxybjzcTUiiVOGH+jcsxok6wGMepgTvYcNTg5U1t2tepgp75tmst6ddSVUHjV\n\tT6oGQ4q6E7k5unv+0YbNlJm9U9jgYbULzrwdJAvQ=","From":"Laurent Pinchart <laurent.pinchart@ideasonboard.com>","To":"libcamera-devel@lists.libcamera.org","Subject":"[PATCH v3 0/4] libcamera: Clean up iterators","Date":"Thu, 19 Feb 2026 15:40:36 +0100","Message-ID":"<20260219144040.1615042-1-laurent.pinchart@ideasonboard.com>","X-Mailer":"git-send-email 2.52.0","MIME-Version":"1.0","Content-Type":"text/plain; charset=UTF-8","Content-Transfer-Encoding":"8bit","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"<libcamera-devel.lists.libcamera.org>","List-Unsubscribe":"<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>","List-Archive":"<https://lists.libcamera.org/pipermail/libcamera-devel/>","List-Post":"<mailto:libcamera-devel@lists.libcamera.org>","List-Help":"<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>","List-Subscribe":"<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>"},"content":"Hello,\n\nThis patch series cleans up usage of iterators to standardize on\nrange-based loops and structured bindings wherever possible (and\nconvenient). What started as a single patch is now a series that\n\n- Replaces map iterators and pairs with structured bindings (1/4)\n- Replaces iterators for non-associative containers (vector, span, ...)\n  with range-based for loops (2/4)\n- Rename one occurrence of a variable named 'it' that does not refer to\n  an iterator (3/4)\n- Standardize on 'const auto' instead of 'auto const'\n\nOne thing *not* addressed by this series is replacement of 'auto' with\n'const auto' or 'const auto &' where applicable. This could be done on\ntop by someone with enough motivation :-)\n\nLaurent Pinchart (4):\n  libcamera: Replace iterators with structured bindings\n  libcamera: Replace iterators with range-based for loops\n  libcamera: Use `it` variable name for iterators only\n  libcamera: Standardize on 'const auto'\n\n .../guides/application-developer.rst          |  2 +-\n include/libcamera/base/utils.h                | 10 ++--\n .../libcamera/internal/ipa_data_serializer.h  | 10 ++--\n src/apps/common/options.cpp                   |  6 +--\n src/apps/common/stream_options.cpp            |  4 +-\n src/gstreamer/gstlibcamera-controls.cpp.in    |  7 +--\n src/gstreamer/gstlibcamera-utils.cpp          | 50 ++++++++-----------\n src/ipa/ipu3/ipu3.cpp                         |  8 +--\n src/ipa/mali-c55/mali-c55.cpp                 |  8 +--\n src/ipa/rkisp1/rkisp1.cpp                     |  8 +--\n src/ipa/rpi/common/ipa_base.cpp               |  4 +-\n src/ipa/rpi/controller/controller.cpp         |  6 +--\n src/ipa/rpi/controller/rpi/agc.cpp            |  4 +-\n src/ipa/rpi/controller/rpi/agc_channel.cpp    |  2 +-\n src/ipa/rpi/controller/rpi/lux.cpp            |  2 +-\n src/ipa/rpi/pisp/pisp.cpp                     |  2 +-\n src/ipa/rpi/vc4/vc4.cpp                       |  2 +-\n src/ipa/simple/soft_simple.cpp                |  8 +--\n src/libcamera/camera.cpp                      |  4 +-\n .../converter/converter_v4l2_m2m.cpp          |  8 +--\n src/libcamera/delayed_controls.cpp            |  4 +-\n src/libcamera/media_device.cpp                |  2 +-\n src/libcamera/pipeline/ipu3/cio2.cpp          |  6 +--\n src/libcamera/pipeline/ipu3/ipu3.cpp          | 11 ++--\n src/libcamera/pipeline/mali-c55/mali-c55.cpp  |  2 +-\n .../pipeline/rpi/common/delayed_controls.cpp  |  4 +-\n .../pipeline/rpi/common/pipeline_base.cpp     | 29 ++++++-----\n .../pipeline/rpi/common/rpi_stream.cpp        |  8 +--\n src/libcamera/pipeline/rpi/pisp/pisp.cpp      |  6 +--\n src/libcamera/pipeline/rpi/vc4/vc4.cpp        |  2 +-\n src/libcamera/pipeline/vimc/vimc.cpp          | 10 ++--\n src/libcamera/pipeline/virtual/virtual.cpp    |  2 +-\n src/libcamera/request.cpp                     |  3 +-\n src/libcamera/sensor/camera_sensor_legacy.cpp |  4 +-\n src/libcamera/sensor/camera_sensor_raw.cpp    |  4 +-\n src/libcamera/software_isp/software_isp.cpp   |  3 +-\n src/libcamera/stream.cpp                      |  8 +--\n src/libcamera/v4l2_videodevice.cpp            |  8 ++-\n test/media_device/media_device_print_test.cpp | 10 ++--\n test/v4l2_videodevice/buffer_cache.cpp        |  2 +-\n 40 files changed, 126 insertions(+), 157 deletions(-)\n\n\nbase-commit: da12b1854fbc0ec32d3162a0ab97654fcb679ae3"}