{"id":25907,"url":"https://patchwork.libcamera.org/api/1.1/covers/25907/?format=json","web_url":"https://patchwork.libcamera.org/cover/25907/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/1.1/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20260121173737.376113-1-kieran.bingham@ideasonboard.com>","date":"2026-01-21T17:37:19","name":"[v6,00/16] libipa: Introduce a Quantized type","submitter":{"id":4,"url":"https://patchwork.libcamera.org/api/1.1/people/4/?format=json","name":"Kieran Bingham","email":"kieran.bingham@ideasonboard.com"},"mbox":"https://patchwork.libcamera.org/cover/25907/mbox/","series":[{"id":5730,"url":"https://patchwork.libcamera.org/api/1.1/series/5730/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=5730","date":"2026-01-21T17:37:19","name":"libipa: Introduce a Quantized type","version":6,"mbox":"https://patchwork.libcamera.org/series/5730/mbox/"}],"comments":"https://patchwork.libcamera.org/api/covers/25907/comments/","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 982F7BDCBF\n\tfor ;\n\tWed, 21 Jan 2026 17:37:44 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 5924161FD1;\n\tWed, 21 Jan 2026 18:37:43 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 168BE61F9F\n\tfor ;\n\tWed, 21 Jan 2026 18:37:42 +0100 (CET)","from Monstersaurus.hippo-penny.ts.net\n\t(cpc89244-aztw30-2-0-cust6594.18-1.cable.virginm.net [86.31.185.195])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id EA266741;\n\tWed, 21 Jan 2026 18:37:09 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"ENiuQfTU\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1769017030;\n\tbh=bhC8+RpeG/YRuwvMqIWK8jqmkXn0kQe2hh8I9Ms8L6M=;\n\th=From:To:Cc:Subject:Date:From;\n\tb=ENiuQfTUqA92TSaCsSda+Tf+cEQK0qMdQtrlVx024DzTYzK6St+DEkGa2S1MXX6DH\n\ttluA1tES+1xwuTZcIYDoGv1YmPUn9nw2ENKHvYhrxgamgy01JNs7Cg+gyfPcKSzR29\n\tFUEhJekrslMyxv2HEsF0nukPWeTKfXbL4ZvfCnog=","From":"Kieran Bingham ","To":"libcamera devel ","Cc":"Kieran Bingham ","Subject":"[PATCH v6 00/16] libipa: Introduce a Quantized type","Date":"Wed, 21 Jan 2026 17:37:19 +0000","Message-ID":"<20260121173737.376113-1-kieran.bingham@ideasonboard.com>","X-Mailer":"git-send-email 2.52.0","MIME-Version":"1.0","Content-Type":"text/plain; charset=UTF-8","Content-Transfer-Encoding":"8bit","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"This series superceeds [0] \"rkisp1: cproc - Metadata and Hue\ndevelopments\" by introducing a new base type for libipa to be able to\nmaintain values which are quantized for hardware.\n\nThese data values often need to be converted, perhaps to a fixed-point\nformat for configuration of hardware, but also then back to a floating\npoint for returning as metadata.\n\nIn particular this series builds to solve the review comment that\nblocked the original series at [1]\n\nThe Quantized type provides a storage mechanism to make both of these\nstorage representations visible to code that wishes to utilise the\nspecific values.\n\nThe series then re-introduces the proposed updates to cproc using the\nnew Q types by supplying Fixed Point types and a scaled fixed point type\nfor the Hue control.\n\nFinally, the remaining users of the fixedToFloatingPoint and\nfloatingToFixedPoint are converted and the old helpers and tests are\nremoved.\n\nThis in cases such as the Mali-C55 AWB Gains means that we now report\naccurate gains as used by the hardware in the metadata.\n\nThis then allows us to clean up a workaround which was managing the\nusage of unsigned integers to represent signed floats.\n\nTests and documentation are provided throughout.\n\n[0] https://patchwork.libcamera.org/project/libcamera/list/?series=5245\n[1] https://patchwork.libcamera.org/patch/23645/#34626\n\nRunning the tests directly shows the following output (all passing)\n\ntest/ipa/libipa/quantized\nQuantised tests passed successfully.\ntest/ipa/libipa/fixedpoint\n\nQ1.7(-1 .. 0.992188) Min: [0x80:-1] -- Max: [0x7f:0.992188] Step:0.0078125\n Checking -2 == [0x80:-1]\n Checking -1 == [0x80:-1]\n Checking -0.992 == [0x81:-0.992188]\n Checking -0.006 == [0xff:-0.0078125]\n Checking 0 == [0x00:0]\n Checking 0.008 == [0x01:0.0078125]\n Checking 0.992 == [0x7f:0.992188]\n Checking 2 == [0x7f:0.992188]\n\nUQ1.7(0 .. 1.99219) Min: [0x00:0] -- Max: [0xff:1.99219] Step:0.0078125\n Checking -1 == [0x00:0]\n Checking 0 == [0x00:0]\n Checking 1 == [0x80:1]\n Checking 1.992 == [0xff:1.99219]\n Checking 2 == [0xff:1.99219]\n\nQ4.7(-8 .. 7.99219) Min: [0x0400:-8] -- Max: [0x03ff:7.99219] Step:0.0078125\n Checking -8 == [0x0400:-8]\n Checking -0.008 == [0x07ff:-0.0078125]\n Checking 0 == [0x0000:0]\n Checking 0.008 == [0x0001:0.0078125]\n Checking 7.992 == [0x03ff:7.99219]\n Checking 0.2 == [0x001a:0.203125]\n Checking -0.2 == [0x07e6:-0.203125]\n Checking -0.8 == [0x079a:-0.796875]\n Checking -0.4 == [0x07cd:-0.398438]\n Checking -1.4 == [0x074d:-1.39844]\n\nUQ4.8(0 .. 15.9961) Min: [0x0000:0] -- Max: [0x0fff:15.9961] Step:0.00390625\n Checking 0 == [0x0000:0]\n Checking 16 == [0x0fff:15.9961]\n\nQ5.4(-16 .. 15.9375) Min: [0x0100:-16] -- Max: [0x00ff:15.9375] Step:0.0625\n Checking -16 == [0x0100:-16]\n Checking 15.94 == [0x00ff:15.9375]\n\nUQ5.8(0 .. 31.9961) Min: [0x0000:0] -- Max: [0x1fff:31.9961] Step:0.00390625\n Checking 0 == [0x0000:0]\n Checking 32 == [0x1fff:31.9961]\n\nQ12.4(-2048 .. 2047.94) Min: [0x8000:-2048] -- Max: [0x7fff:2047.94] Step:0.0625\n Checking 0 == [0x0000:0]\n Checking 7.5 == [0x0078:7.5]\n\nUQ12.4(0 .. 4095.94) Min: [0x0000:0] -- Max: [0xffff:4095.94] Step:0.0625\n Checking 0 == [0x0000:0]\n Checking 7.5 == [0x0078:7.5]\n\nQ4.20(-8 .. 8) Min: [0x00800000:-8] -- Max: [0x007fffff:8] Step:9.53674e-07\n Checking -9 == [0x00800000:-8]\n Checking -8 == [0x00800000:-8]\n Checking 8 == [0x007fffff:8]\n Checking 9 == [0x007fffff:8]\n\nUQ4.20(0 .. 16) Min: [0x00000000:0] -- Max: [0x00ffffff:16] Step:9.53674e-07\n Checking -1 == [0x00000000:0]\n Checking 0 == [0x00000000:0]\n Checking 16 == [0x00ffffff:16]\n Checking 20 == [0x00ffffff:16]\n\n\nKieran Bingham (15):\n ipa: libipa: Provide a Quantized data type support\n test: libipa: Add tests for Quantized types\n ipa: libipa: fixedpoint: Fix unsigned usage\n ipa: libipa: Provide fixed point quantized traits\n test: libipa: Provide FixedPoint Quantized tests\n ipa: rkisp1: cproc: Convert to use Quantized types\n ipa: rkisp1: cproc: Report metadata\n ipa: rkisp1: cproc: Provide a Hue control\n ipa: rkisp1: ccm: Use Q<4, 7> format directly\n ipa: mali-c55: Reduce AWB calculations to float precision\n ipa: mali-c55: Convert AWB to UQ<4, 8> usage\n ipa: mali-c55: agc: Quantise the ISP Digital Gain\n test: libipa: Remove legacy fixed point conversion test\n ipa: libipa: fixedpoint: Move float conversion inline\n ipa: libipa: fixedpoint: Remove unsigned workaround\n\nvan Veen, Stephan (1):\n libcamera: controls: Define a new core Hue control\n\n src/ipa/libipa/fixedpoint.cpp | 103 +++++++++++---\n src/ipa/libipa/fixedpoint.h | 117 ++++++++++-----\n src/ipa/libipa/meson.build | 2 +\n src/ipa/libipa/quantized.cpp | 135 ++++++++++++++++++\n src/ipa/libipa/quantized.h | 75 ++++++++++\n src/ipa/mali-c55/algorithms/agc.cpp | 18 +--\n src/ipa/mali-c55/algorithms/awb.cpp | 44 +++---\n src/ipa/mali-c55/ipa_context.h | 16 ++-\n src/ipa/rkisp1/algorithms/ccm.cpp | 3 +-\n src/ipa/rkisp1/algorithms/cproc.cpp | 68 ++++++---\n src/ipa/rkisp1/algorithms/cproc.h | 4 +\n src/ipa/rkisp1/ipa_context.h | 26 ++--\n src/libcamera/control_ids_core.yaml | 15 ++\n test/ipa/libipa/fixedpoint.cpp | 211 ++++++++++++++++++++--------\n test/ipa/libipa/meson.build | 1 +\n test/ipa/libipa/quantized.cpp | 148 +++++++++++++++++++\n 16 files changed, 807 insertions(+), 179 deletions(-)\n create mode 100644 src/ipa/libipa/quantized.cpp\n create mode 100644 src/ipa/libipa/quantized.h\n create mode 100644 test/ipa/libipa/quantized.cpp"}