{"id":25653,"url":"https://patchwork.libcamera.org/api/1.1/covers/25653/?format=json","web_url":"https://patchwork.libcamera.org/cover/25653/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/1.1/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20260106170059.56193-1-bryan.odonoghue@linaro.org>","date":"2026-01-06T17:00:35","name":"[v10,00/24] Add GLES 2.0 GPUISP to libcamera","submitter":{"id":175,"url":"https://patchwork.libcamera.org/api/1.1/people/175/?format=json","name":"Bryan O'Donoghue","email":"bryan.odonoghue@linaro.org"},"mbox":"https://patchwork.libcamera.org/cover/25653/mbox/","series":[{"id":5689,"url":"https://patchwork.libcamera.org/api/1.1/series/5689/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=5689","date":"2026-01-06T17:00:35","name":"Add GLES 2.0 GPUISP to libcamera","version":10,"mbox":"https://patchwork.libcamera.org/series/5689/mbox/"}],"comments":"https://patchwork.libcamera.org/api/covers/25653/comments/","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 0F437BDCC0\n\tfor ;\n\tTue, 6 Jan 2026 17:01:05 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 9376561FB7;\n\tTue, 6 Jan 2026 18:01:04 +0100 (CET)","from mail-wr1-x42d.google.com (mail-wr1-x42d.google.com\n\t[IPv6:2a00:1450:4864:20::42d])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id EA53B61F9F\n\tfor ;\n\tTue, 6 Jan 2026 18:01:02 +0100 (CET)","by mail-wr1-x42d.google.com with SMTP id\n\tffacd0b85a97d-42e2e3c0dccso570327f8f.2\n\tfor ;\n\tTue, 06 Jan 2026 09:01:02 -0800 (PST)","from inspiron14p-linux.ht.home (188-141-3-146.dynamic.upc.ie.\n\t[188.141.3.146]) by smtp.gmail.com with ESMTPSA id\n\tffacd0b85a97d-432bd0dadcfsm5515322f8f.3.2026.01.06.09.01.01\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tTue, 06 Jan 2026 09:01:01 -0800 (PST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (2048-bit key;\n\tunprotected) header.d=linaro.org header.i=@linaro.org\n\theader.b=\"nXxwiUVT\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=linaro.org; s=google; t=1767718862; x=1768323662;\n\tdarn=lists.libcamera.org; \n\th=content-transfer-encoding:mime-version:message-id:date:subject:cc\n\t:to:from:from:to:cc:subject:date:message-id:reply-to;\n\tbh=2Equy1XW3S3UbMzJUWtUkNKLn0Pv3VLkUxIvtVo8/i0=;\n\tb=nXxwiUVT6dxizaQcb1sV6oAOwptEFAgUjUM2r6gIxzxmUdIZsgQDVQVhLai2dVgm6L\n\tQuYbBOsmkFHinNTe5XbkqmWudn8plOz+ybyJhAfR+excLEYRePclOU7M5Hw8vIU9cEgn\n\t2zi4p4l+6d3NWtojrRhDoiJKqsoO6UV69OivSGnAbXy6gu1X5fYNP/WHyt9LJvYzURuc\n\tCd35Ox4pWwn15+hyXshMU3xqXLfRIrybGqdqIIIeF9HueBtIQXGt5uduzxzIl3Aty1Gp\n\t49DK4x4b0ZRxKd822GEe9bT0/keYyuYgh9loSoGDbjE4qqXZQj98whb3+HkbnYXPosHR\n\tWb8w==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20230601; t=1767718862; x=1768323662;\n\th=content-transfer-encoding:mime-version:message-id:date:subject:cc\n\t:to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date\n\t:message-id:reply-to;\n\tbh=2Equy1XW3S3UbMzJUWtUkNKLn0Pv3VLkUxIvtVo8/i0=;\n\tb=FyNIav5OsHJz88U9dxfXHxNybdhSvikM7FbVA+K3ol/KBUIcFPQU2HpCAg1w+MFZXa\n\tMlIaSdHe4AIN+0GLsefa+nCEtEqHFfnbU2j/pwz9uFG2eMsZnJlGp5yuQfWSg2wx3b2h\n\tIVW0C8Iddu5MhvK/wUYLECfEQ2eY3sk2OYMFmmKEpC/qRId859wCtm5JJf85SjdYJ6Ww\n\t4yriMApqdhDmHybxF2CNyyemGVHuolPx6t46lc5VNhedbuoo0Rcy5n1nwL5UcTL0QqTg\n\t94mjCjkGwfwYtvNObij12MP1d9LRvauOu5MA14dMcq+vAHVpyb4WBgtP7DKC+ga9QAk4\n\t7YHQ==","X-Gm-Message-State":"AOJu0YzT80LvO/sIKK12u+4Zh1exf2bL+JbvNrtvGPdO1z5l38oEDIP0\n\tnnD2QI2vkcaW2TuC792G2iZXx/pNB3mTMyIgjWtCvgsub4OVBwu0hAgXJeCL1FBaoQrrQSzg0Mg\n\tuj4KpjCw=","X-Gm-Gg":"AY/fxX6yCKGDNufoYk+EYzetCbsC8zGBZV4UQ7BSgGT89WoKulq/DBkUb5GmqiSNv/u\n\tgYih/YsmwMpKmzFXF9gVZuvXDT/9mTeaWa5A3/xRVcldbsjpmI2/y410OjEJwvGBR33I43T1VPL\n\tBKHaKrm/GqNB6X7rWp24e8tfzaL0NgkNhzcWnBjYX3xAHKhlY64QpLkCWXT6udSm4eZtthGqRAL\n\tSA+jgrncqRdsjR8A/ryTgpK5Z+3c2dsLInsGNawuz5gwnCkxcuZPRK2pHQsEOpEouZlbCiRU1Aq\n\t2AN19J5YovFciNibEzwlhyCELSfhZ6bGQLqAB1cEmbktHR5n/pjYed0EzjPd2oSrZs0jOAroR0o\n\tMU6XP68q55txNiemgZqubjVkfM3C74uqiXckhHDAyTZ6/5txyQsplIIJALus9uL91YzYWAyY/ea\n\tZbX6D36a3ojbeD147CdvzDeaVnyMFDSTAqEMpDIkCYBlxKfJNqilEaE6Lan/tdW3i4+0I=","X-Google-Smtp-Source":"AGHT+IHkcof6BxUiUtL6VBZXcup5dI5pzHd5Pj3brWZtX2+j5iwfvBs4eutbuBUabvhwojAXgbWyQQ==","X-Received":"by 2002:a05:6000:2383:b0:432:aad5:320b with SMTP id\n\tffacd0b85a97d-432bc9d0e65mr5211844f8f.23.1767718862094; \n\tTue, 06 Jan 2026 09:01:02 -0800 (PST)","From":"Bryan O'Donoghue ","To":"libcamera-devel@lists.libcamera.org","Cc":"pavel@ucw.cz,\n\tBryan O'Donoghue ","Subject":"[PATCH v10 00/24] Add GLES 2.0 GPUISP to libcamera","Date":"Tue, 6 Jan 2026 17:00:35 +0000","Message-ID":"<20260106170059.56193-1-bryan.odonoghue@linaro.org>","X-Mailer":"git-send-email 2.52.0","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"v11:\n- Rebases on today's tip of tree\n- Applies Tested-by from Hans\n- Applies RB from Robert and Milan\n- Fixes ~ every issue Barnabas raised in previous cycles with exception of:\n a. Header checks for GBM and gles are required in at least one\n of the ci checks respectively\n b. programId_ removal happens in stop() not in destructor\n\nFull testable branch\nLink: https://gitlab.freedesktop.org/camera/libcamera-softisp/-/tree/0.6.0-gpuisp-v11-a?ref_type=heads\n\nv10:\n- Drop selfEnumerating Ccm object - libcamera-softisp meeting agreement\n- Switch on uncalibrated yaml CCM @ 65k by default - softisp meeting agreement\n- Pass contrastExp from lut into shaders instead of calculating contrastExp\n for each pixel as @ v9 - softisp meeting agreement\n- Adds in RB as indicated by Milan and Robert\n- Fixes check of unique_ptr - Barnabas @ v8 review\n\nv9:\n\n- Rebase on 0.6.0-tip including precursor now merged\n\n _______\n | YAY! |\n |_______|\n |||\n /|||\\\n / ||| \\\n / ||| \\\n |\n / \\\n / \\\n\n- Number of fixes from the formatter now that I'm aware of its existence/use - Bryan/Milan\n- Includes Robert's changes for the projection matrix\n- Fixes the case where the uncalibrated.yaml file is enabled.\n Iterates through list of loaded algorithms matching Ccm. - Milan/Bryan\n\n\nBryan O'Donoghue (21):\n libcamera: software_isp: debayer: Latch contrastExp not contrast to\n debayer parameters\n libcamera: software_isp: gbm: Add a GBM helper class for GPU surface\n access\n libcamera: software_isp: egl: Add a eGL base helper class\n qcam: viewfinder_gl: Set no-op Bayer shader values\n libcamera: shaders: Use highp not mediump for float precision\n libcamera: shaders: Extend debayer shaders to apply CCM gains\n libcamera: shaders: Extend bayer shaders to support swapping R and B\n on output\n libcamera: shaders: Add support for black level compensation\n libcamera: shaders: Add support for Gamma\n libcamera: shaders: Add support for contrast\n libcamera: software_isp: Add member variables to track selected\n input/output pixelFormat\n libcamera: software_isp: Add a Size_ member variable to pass to eGL\n later\n libcamera: software_isp: debayer_egl: Add an eGL Debayer class\n libcamera: software_isp: debayer_cpu: Make getInputConfig and\n getOutputConfig static\n libcamera: software_isp: debayer_egl: Make DebayerEGL an environment\n option\n ipa: simple: Add a flag to indicate gpuIspEnabled\n libcamera: software_isp: lut: Skip calculation lookup tables if\n gpuIspEnabled is true\n libcamera: software_isp: lut: Change default Gamma to 1.0/2.2\n libcamera: software_isp: Switch on default CCM at 65k\n libcamera: software_isp: debayer_egl: Make gpuisp default softisp mode\n libcamera: software_isp: Add a gpuisp todo list\n\nHans de Goede (1):\n libcamera: shaders: Fix input sampling when width != stride\n\nMilan Zamazal (2):\n libcamera: shaders: Rename bayer_8 to bayer_unpacked\n libcamera: software_isp: GPU support for unpacked 10/12-bit formats\n\n include/libcamera/internal/egl.h | 152 ++++\n include/libcamera/internal/gbm.h | 55 ++\n include/libcamera/internal/meson.build | 2 +\n .../internal/software_isp/debayer_params.h | 2 +-\n include/libcamera/ipa/soft.mojom | 3 +-\n src/apps/qcam/assets/shader/shaders.qrc | 4 +-\n src/apps/qcam/viewfinder_gl.cpp | 42 +-\n src/apps/qcam/viewfinder_gl.h | 12 +\n src/ipa/simple/algorithms/lut.cpp | 78 ++-\n src/ipa/simple/data/uncalibrated.yaml | 12 +-\n src/ipa/simple/ipa_context.h | 2 +\n src/ipa/simple/soft_simple.cpp | 3 +\n src/libcamera/egl.cpp | 608 ++++++++++++++++\n src/libcamera/gbm.cpp | 107 +++\n src/libcamera/meson.build | 33 +\n src/libcamera/shaders/RGB.frag | 2 +-\n src/libcamera/shaders/YUV_2_planes.frag | 2 +-\n src/libcamera/shaders/YUV_3_planes.frag | 2 +-\n src/libcamera/shaders/YUV_packed.frag | 2 +-\n src/libcamera/shaders/bayer_1x_packed.frag | 77 ++-\n .../{bayer_8.frag => bayer_unpacked.frag} | 92 ++-\n .../{bayer_8.vert => bayer_unpacked.vert} | 6 +-\n src/libcamera/shaders/meson.build | 4 +-\n src/libcamera/software_isp/debayer.cpp | 17 +-\n src/libcamera/software_isp/debayer.h | 3 +\n src/libcamera/software_isp/debayer_cpu.h | 4 +-\n src/libcamera/software_isp/debayer_egl.cpp | 651 ++++++++++++++++++\n src/libcamera/software_isp/debayer_egl.h | 124 ++++\n src/libcamera/software_isp/gpuisp-todo.txt | 40 ++\n src/libcamera/software_isp/meson.build | 8 +\n src/libcamera/software_isp/software_isp.cpp | 28 +-\n 31 files changed, 2106 insertions(+), 71 deletions(-)\n create mode 100644 include/libcamera/internal/egl.h\n create mode 100644 include/libcamera/internal/gbm.h\n create mode 100644 src/libcamera/egl.cpp\n create mode 100644 src/libcamera/gbm.cpp\n rename src/libcamera/shaders/{bayer_8.frag => bayer_unpacked.frag} (53%)\n rename src/libcamera/shaders/{bayer_8.vert => bayer_unpacked.vert} (90%)\n create mode 100644 src/libcamera/software_isp/debayer_egl.cpp\n create mode 100644 src/libcamera/software_isp/debayer_egl.h\n create mode 100644 src/libcamera/software_isp/gpuisp-todo.txt"}