{"id":25451,"url":"https://patchwork.libcamera.org/api/1.1/covers/25451/?format=json","web_url":"https://patchwork.libcamera.org/cover/25451/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/1.1/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20251210131302.81887-1-naush@raspberrypi.com>","date":"2025-12-10T13:09:12","name":"[v1,0/2] RPi: Internal buffer alloaction rework","submitter":{"id":34,"url":"https://patchwork.libcamera.org/api/1.1/people/34/?format=json","name":"Naushir Patuck","email":"naush@raspberrypi.com"},"mbox":"https://patchwork.libcamera.org/cover/25451/mbox/","series":[{"id":5647,"url":"https://patchwork.libcamera.org/api/1.1/series/5647/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=5647","date":"2025-12-10T13:09:12","name":"RPi: Internal buffer alloaction rework","version":1,"mbox":"https://patchwork.libcamera.org/series/5647/mbox/"}],"comments":"https://patchwork.libcamera.org/api/covers/25451/comments/","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id C54BABD1F1\n\tfor ;\n\tWed, 10 Dec 2025 13:13:09 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id A38726146D;\n\tWed, 10 Dec 2025 14:13:08 +0100 (CET)","from mail-wm1-x32c.google.com (mail-wm1-x32c.google.com\n\t[IPv6:2a00:1450:4864:20::32c])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 52A81613CB\n\tfor ;\n\tWed, 10 Dec 2025 14:13:06 +0100 (CET)","by mail-wm1-x32c.google.com with SMTP id\n\t5b1f17b1804b1-47928022b93so14922415e9.0\n\tfor ;\n\tWed, 10 Dec 2025 05:13:06 -0800 (PST)","from naush-dell.pitowers.org\n\t([2a00:1098:3142:1f:2883:e222:5478:b981])\n\tby smtp.gmail.com with ESMTPSA id\n\tffacd0b85a97d-42f7cbfee71sm37871852f8f.15.2025.12.10.05.13.04\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tWed, 10 Dec 2025 05:13:05 -0800 (PST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (2048-bit key;\n\tunprotected) header.d=raspberrypi.com header.i=@raspberrypi.com\n\theader.b=\"IhJ2lIVl\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=raspberrypi.com; s=google; t=1765372385; x=1765977185;\n\tdarn=lists.libcamera.org; \n\th=content-transfer-encoding:mime-version:message-id:date:subject:cc\n\t:to:from:from:to:cc:subject:date:message-id:reply-to;\n\tbh=4HqMTkA0AYhfIaBXjgYT5BfM4YkwZVwI+OCQaMVQQ9M=;\n\tb=IhJ2lIVllVKvpVmE5ms/4vLAfk8B36IzmUHigSMBb0Z88G5HXVBMzvPndZkC6y1OSC\n\twVRKmMChZfWLkSdpuBkXkWTl9Z6F//TQGU9RnYr0aLrAKGwWItufk9JcbuBrj4afmmC+\n\tBXBFihqOwcBbyn8TNqNf2syjlFGUY6GVwCFwdnLbEZGyafD3dL56f3kzfjEOZxm3Zx1d\n\t9ENV/VhJNnApIKNtCejikvliMwjYuM6twmALXkAqKGdzu4dLhWetrBVleV6TZoU8BqJQ\n\t35sStSf0AWxXZ86sQTgwVbjyF/tSddtGjhn/GhJeupR7q2P9GHQoCfXX5GhAuXGai+2V\n\te5MA==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20230601; t=1765372385; x=1765977185;\n\th=content-transfer-encoding:mime-version:message-id:date:subject:cc\n\t:to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date\n\t:message-id:reply-to;\n\tbh=4HqMTkA0AYhfIaBXjgYT5BfM4YkwZVwI+OCQaMVQQ9M=;\n\tb=u+s96+SaPkBZTO3ipODCbQL2x70sHjN5CxeuMqd1wohyYBxEEMS+5erS9bC35m+hwt\n\tt7wUElwZSn8P3ZbHPupPB3VbMIVrJKxbZAx72DbOD4pW6PoEIsI2crQWeGTQV2JXpNw2\n\txaeyjN5oulfJVjWnp9yXjG8+UgcryHUzFQ1jpdFuhs4HeWKOo4F4q024gCARf/U/kDpI\n\tqqAuO6DqjRegNzH4X8VBVVIxy2jqM4VWySUILP/1SVghfwRlg2f+MGhf/FUyi6q4XyS6\n\tVu6YuoXA+LVo7dnZTf8323r3k56F0xk5lm9sKC7yuU4GpN298qGaUqh1ajNGeMHWBMX4\n\tJRyw==","X-Gm-Message-State":"AOJu0YwIxam++YOgt4Wvy4eDbrzcpuoya49WGHNMWkDYNk4xPcOXFZH2\n\tms26FF+ek6gJp7rAu8yRf73MBcDeDsWSelIulGDCB1O1KtNA/PLgApbOJerBRgi7SAE/h9U4kBX\n\tgPDkQnE4=","X-Gm-Gg":"ASbGncsV03i6H8scZ8yPvJy7TIUZt8P3youcJQtiE0o2gsRjZk1dOmYtsJcBJS+uK8Q\n\tMmWv59g53mu9MlvEgMTrVHrZbjf5KUWd8+UI/2NL4NO802m5FQjR5o5mwThOkSVrcQ8PbuYqzlX\n\t6O7xgyAemyAHPP9WPsm+Oe8139a3MJEoIfTb/NqgUuGXYtUt9OeEz1HbqOPvK3nhVwVstBm8MbK\n\toGpThFtN9feaS/65oJOg4Nnmp16Nix5VXjubyn02h/L1q/DpHZUARnbEoVDd/K7QkFCLmpaxgak\n\t6HQf8F7WoQbfH+kZJyy0s2EYSrDq55mg+fjXHVQjkmHMJoin0r8JPXyy5RImeD7TTOCmU0A1MVn\n\tsktUB/NP7lpsa/kcPtMfZPE78EDpJ8dviW0EyH8BxyLzwmiS7DZvnHLNgF7yNjc3tmujQkL50/D\n\tf1q9TDCvori9BxDw5zttb40pHd+Wn7MN4=","X-Google-Smtp-Source":"AGHT+IFMEc3GNOAtNOWLCFzlUKEWL1A86TaL3qMiQD4Aq/YdQIb23tFeDqyHrKv6xlYCU/eYjWaCqA==","X-Received":"by 2002:a05:600c:3105:b0:477:9f61:8c20 with SMTP id\n\t5b1f17b1804b1-47a8376dcbbmr13548765e9.2.1765372385471; \n\tWed, 10 Dec 2025 05:13:05 -0800 (PST)","From":"Naushir Patuck ","To":"libcamera-devel@lists.libcamera.org","Cc":"Naushir Patuck ","Subject":"[PATCH v1 0/2] RPi: Internal buffer alloaction rework","Date":"Wed, 10 Dec 2025 13:09:12 +0000","Message-ID":"<20251210131302.81887-1-naush@raspberrypi.com>","X-Mailer":"git-send-email 2.51.0","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"Hi,\n\nThis minor series addresses the issue raised at [1], where the RPi pipeline\nhandlers don't release the buffers from the V4L2VideoDevice cache when stopping\nthe camera.\n\nThe rework is faily minor, and with these changes, we now release the buffers\nfrom the V4L2VideoDevice cache, but keep the allocations around where needed.\n\nThanks,\nNaush\n\n[1]: https://gitlab.freedesktop.org/camera/libcamera/-/issues/265\n\nNaushir Patuck (2):\n pipeline: rpi: Rename Stream::prepareBuffers to\n Stream::allocateBuffers\n pipeline: rpi: Rework internal buffer allocations\n\n .../pipeline/rpi/common/pipeline_base.cpp | 10 ++++++--\n .../pipeline/rpi/common/pipeline_base.h | 2 +-\n .../pipeline/rpi/common/rpi_stream.cpp | 25 ++++++-------------\n .../pipeline/rpi/common/rpi_stream.h | 3 +--\n src/libcamera/pipeline/rpi/pisp/pisp.cpp | 6 ++---\n src/libcamera/pipeline/rpi/vc4/vc4.cpp | 6 ++---\n 6 files changed, 24 insertions(+), 28 deletions(-)"}