{"id":25337,"url":"https://patchwork.libcamera.org/api/1.1/covers/25337/?format=json","web_url":"https://patchwork.libcamera.org/cover/25337/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/1.1/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20251202-cam-control-override-v3-0-eacab052798d@ideasonboard.com>","date":"2025-12-02T14:49:25","name":"[v3,0/5] libcamera: ipc: ControlLists without valid idmap break IPC","submitter":{"id":143,"url":"https://patchwork.libcamera.org/api/1.1/people/143/?format=json","name":"Jacopo Mondi","email":"jacopo.mondi@ideasonboard.com"},"mbox":"https://patchwork.libcamera.org/cover/25337/mbox/","series":[{"id":5633,"url":"https://patchwork.libcamera.org/api/1.1/series/5633/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=5633","date":"2025-12-02T14:49:25","name":"libcamera: ipc: ControlLists without valid idmap break IPC","version":3,"mbox":"https://patchwork.libcamera.org/series/5633/mbox/"}],"comments":"https://patchwork.libcamera.org/api/covers/25337/comments/","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 6214ABD80A\n\tfor ;\n\tTue, 2 Dec 2025 14:49:39 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id EDBA460C8A;\n\tTue, 2 Dec 2025 15:49:37 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id EF5FD6096B\n\tfor ;\n\tTue, 2 Dec 2025 15:49:35 +0100 (CET)","from [192.168.1.104] (net-93-65-100-155.cust.vodafonedsl.it\n\t[93.65.100.155])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 7545AD7;\n\tTue, 2 Dec 2025 15:47:21 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"mP2u3Czv\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1764686841;\n\tbh=yoQRJEr4u19scjV/UcqJEWXmz5atsZHnRQ+gqKQnumw=;\n\th=From:Subject:Date:To:Cc:From;\n\tb=mP2u3Czv9ykFZHlE2vonzNkC3US0Ah9mwcJL3sE5N27OLkuePfPrerdUeN64NzeZB\n\tFtOlKs6toRqcBIiWtdc+jhYRJ0JWgGoJguPw3bWBp8Vm3ItPpf7EEsBy6UlyRFbwl4\n\t6UFbMCnSkE9ul9HxOEKKRluCapWgghiLA47kwEP8=","From":"Jacopo Mondi ","Subject":"[PATCH v3 0/5] libcamera: ipc: ControlLists without valid idmap\n\tbreak IPC","Date":"Tue, 02 Dec 2025 15:49:25 +0100","Message-Id":"<20251202-cam-control-override-v3-0-eacab052798d@ideasonboard.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=\"utf-8\"","Content-Transfer-Encoding":"7bit","X-B4-Tracking":"v=1; b=H4sIAHX8LmkC/4XNQQrCMBCF4auUrI1kJm1FV95DXKTJxAZsR5ISl\n\tNK7m3blQnH5P5hvZpEoBkriVM0iUg4p8FhC7yphezPeSAZXWqDCBgBrac0gLY9T5LvkTDEGR7I\n\tB1epDZ7EDJcrpI5IPz429XEv3IU0cX9uXDOv6B8wglXTeaoNeeyI6l9UkHjs20e0tD2J1M35a7\n\tQ8Li6VVo7A24OGovljLsrwBL+ENvQsBAAA=","X-Change-ID":"20251124-cam-control-override-510637bc2b10","To":"libcamera-devel@lists.libcamera.org","Cc":"Jacopo Mondi , Kieran Bingham\n\t, Paul Elder\n\t, =?utf-8?q?Barnab=C3=A1s_P=C5=91cze?=\n\t","X-Mailer":"b4 0.14.2","X-Developer-Signature":"v=1; a=openpgp-sha256; l=2003;\n\ti=jacopo.mondi@ideasonboard.com; h=from:subject:message-id;\n\tbh=yoQRJEr4u19scjV/UcqJEWXmz5atsZHnRQ+gqKQnumw=;\n\tb=owEBbQKS/ZANAwAKAXI0Bo8WoVY8AcsmYgBpLvx94hjk9HHUWM7J51SfmzR3+jVfCmc82DvdA\n\tzTlpnHMEHCJAjMEAAEKAB0WIQS1xD1IgJogio9YOMByNAaPFqFWPAUCaS78fQAKCRByNAaPFqFW\n\tPAbgD/9vdJEKMNKjradbRWa39C7ckfOrC6HxQlnL9+P/VdAWEJkS+5kEwzK5hFHD4dinP4NLF0V\n\tGjm6PNeiAz0O3GmfymIw3EVMB4xW5TricPuOQQVv/y2j/tOlBtLFKNTvtdR/xNW4V79W4w3UjwR\n\t6U/X8BpI1woMBpDVffyf99TbyPkzDJm065g3CoYrMdPR3/AMi9yzFvOu+kBgYGV+iGDdhmbaGLD\n\tU2O3JQQMC6zxnAsGJtNO0XsMsMQYXveyZwdWjtuweRw3npQiIG9Ka8H1Uw+V3XH2xk+uRLcVl3R\n\tVjMWSYuWNViKKPKSVZGFf6wJE7mHsv1wGbiSQDsPj4gwdhUvyGMjOwxhIFMV/M/4FrVk1PnRfJn\n\td6xu7gjkFemaaJThekaDZEy7u/sJDTsqsq8ZufPTej3J+SrXOjXNVZ2g6Kf6Z4WjElARF1o8RDM\n\tBdEUuEEKL65eq8hLzN5q3kBYRe4R6Ncu7xe8gwJjlwRUaO2mP7AqVJZdqVBJNlii2CZKRueci+u\n\tTpGc8wS0H5IRfixSf93ZWcbu7/WmyGXpjHiqRbPPT02a+ZqGbzQg5zH6QdK0NLe+n1CNcjWJFUU\n\t7cDbqRIpS5dzIfaWxeQs3xCbjoQVfmTHVfokwA/TmNP0I8II2Y5ma7ABfN6p8TbqcnwqSd8Ez0U\n\tKawPVwEV7U3ynMg==","X-Developer-Key":"i=jacopo.mondi@ideasonboard.com; a=openpgp;\n\tfpr=72392EDC88144A65C701EA9BA5826A2587AD026B","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"https://gitlab.freedesktop.org/camera/libcamera/-/issues/295\n\nSigned-off-by: Jacopo Mondi \n---\nChanges in v3:\n- Remove \"libcamera: request: Remove write-access to controls_\"\n- Replace it with \"libcamera: camera: Ensure a request's controls are\n valid\"\n- Add two patches to make metadata_ and controls_ class members\n- Add review tags\n\nChanges in v2:\n- Properly change the access to Request::controls() to const &\n- Add patch to make metadata read-only\n- Yes, this breaks the API/ABI very much\n\n---\nJacopo Mondi (5):\n libcamera: request: Create control list with Camera info map\n libcamera: request: Move metadata_ to Private\n libcamera: request: Make metadata_ a class instance\n libcamera: request: Make controls_ a class instance\n libcamera: camera: Ensure a request's controls are valid\n\n include/libcamera/internal/request.h | 3 ++\n include/libcamera/request.h | 7 ++--\n src/libcamera/camera.cpp | 6 +++\n src/libcamera/pipeline/imx8-isi/imx8-isi.cpp | 3 +-\n src/libcamera/pipeline/ipu3/ipu3.cpp | 16 ++++----\n src/libcamera/pipeline/mali-c55/mali-c55.cpp | 2 +-\n src/libcamera/pipeline/rkisp1/rkisp1.cpp | 10 ++---\n .../pipeline/rpi/common/pipeline_base.cpp | 13 ++++---\n src/libcamera/pipeline/rpi/common/pipeline_base.h | 2 +-\n src/libcamera/pipeline/simple/simple.cpp | 8 ++--\n src/libcamera/pipeline/uvcvideo/uvcvideo.cpp | 6 +--\n src/libcamera/pipeline/vimc/vimc.cpp | 6 +--\n src/libcamera/pipeline/virtual/virtual.cpp | 4 +-\n src/libcamera/request.cpp | 43 +++++++++++-----------\n 14 files changed, 69 insertions(+), 60 deletions(-)\n---\nbase-commit: 3a835ff48ccfa6779012dd7d761f8f416dbdef92\nchange-id: 20251124-cam-control-override-510637bc2b10\n\nBest regards,"}