{"id":2519,"url":"https://patchwork.libcamera.org/api/1.1/covers/2519/?format=json","web_url":"https://patchwork.libcamera.org/cover/2519/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/1.1/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20200107154442.17372-1-kieran.bingham@ideasonboard.com>","date":"2020-01-07T15:44:39","name":"[libcamera-devel,0/2] utils: checkstyle: Two checkstyle fixes","submitter":{"id":4,"url":"https://patchwork.libcamera.org/api/1.1/people/4/?format=json","name":"Kieran Bingham","email":"kieran.bingham@ideasonboard.com"},"mbox":"https://patchwork.libcamera.org/cover/2519/mbox/","series":[{"id":605,"url":"https://patchwork.libcamera.org/api/1.1/series/605/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=605","date":"2020-01-07T15:44:39","name":"utils: checkstyle: Two checkstyle fixes","version":1,"mbox":"https://patchwork.libcamera.org/series/605/mbox/"}],"comments":"https://patchwork.libcamera.org/api/covers/2519/comments/","headers":{"Return-Path":"","Received":["from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 77C2460464\n\tfor ;\n\tTue, 7 Jan 2020 16:44:46 +0100 (CET)","from localhost.localdomain\n\t(cpc89242-aztw30-2-0-cust488.18-1.cable.virginm.net [86.31.129.233])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id DF42552F;\n\tTue, 7 Jan 2020 16:44:45 +0100 (CET)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1578411886;\n\tbh=rBBlI4mYdbWM4p9vmYtcPLVzAc7hUNGByo3UpLOzamA=;\n\th=From:To:Cc:Subject:Date:From;\n\tb=Hh6XimIPL+VF46p6a3nJoYh1HsHr+rQ1b4ewLPPJn2VnD+LL7EmPppKcadyzfoS8B\n\t5DwCh+xM8vtxcgRrtFrLPrOGz9e3CnlTvX30aSKPid2SD4CmK/S/TdMTiTYD1Hv0LE\n\tpKK6AqBKdPahpsCLns1c3NvGmEPXaDjUNcNVQ6uI=","From":"Kieran Bingham ","To":"LibCamera Devel ","Date":"Tue, 7 Jan 2020 15:44:39 +0000","Message-Id":"<20200107154442.17372-1-kieran.bingham@ideasonboard.com>","X-Mailer":"git-send-email 2.20.1","MIME-Version":"1.0","Content-Type":"text/plain; charset=UTF-8","Content-Transfer-Encoding":"8bit","Subject":"[libcamera-devel] [PATCH 0/2] utils: checkstyle: Two checkstyle\n\tfixes","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","X-List-Received-Date":"Tue, 07 Jan 2020 15:44:46 -0000"},"content":"While applying a patch containing a short hunk (a single line addition to a\nfile with a single line), an error was observied in the checkstyle hunk\nparsing. This was easily fixed by updating the regex to support optionally\nspecifiying the line count of a hunk (it's not provided when only a single line\nis in the hunk).\n\nDoing so, and creating a commit for this, caused checkstyle.py to run\ncheckstyle.py on it's own regex parser which identified an issue in the string\nliterals, with a deprecated escape format usage.\n\nThis is fixed as a preceeding commit for the single line hunk support.\n\nNote that the *output* hunks produced do still provide the line count for\nsingle line hunks. Updating this can be handled later if required, but is\nexpected to be optional, as they are usually only consumed by humans currently.\n\nKieran Bingham (2):\n utils: checkstyle.py: Fix regex string literal\n utils: checkstyle.py: Support single line hunks\n\n utils/checkstyle.py | 2 +-\n 1 file changed, 1 insertion(+), 1 deletion(-)"}