{"id":25014,"url":"https://patchwork.libcamera.org/api/1.1/covers/25014/?format=json","web_url":"https://patchwork.libcamera.org/cover/25014/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/1.1/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20251113122450.287633-1-kieran.bingham@ideasonboard.com>","date":"2025-11-13T12:24:35","name":"[v3,00/14] libipa: Introduce a Quantized type","submitter":{"id":4,"url":"https://patchwork.libcamera.org/api/1.1/people/4/?format=json","name":"Kieran Bingham","email":"kieran.bingham@ideasonboard.com"},"mbox":"https://patchwork.libcamera.org/cover/25014/mbox/","series":[{"id":5587,"url":"https://patchwork.libcamera.org/api/1.1/series/5587/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=5587","date":"2025-11-13T12:24:35","name":"libipa: Introduce a Quantized type","version":3,"mbox":"https://patchwork.libcamera.org/series/5587/mbox/"}],"comments":"https://patchwork.libcamera.org/api/covers/25014/comments/","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id D1E77C3263\n\tfor ;\n\tThu, 13 Nov 2025 12:24:55 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 8B05B60A80;\n\tThu, 13 Nov 2025 13:24:55 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 3916F609E0\n\tfor ;\n\tThu, 13 Nov 2025 13:24:54 +0100 (CET)","from Monstersaurus.infra.iob\n\t(cpc89244-aztw30-2-0-cust6594.18-1.cable.virginm.net [86.31.185.195])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 1F8CF5B2;\n\tThu, 13 Nov 2025 13:22:54 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"q+LEogQJ\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1763036574;\n\tbh=6iOoft9B1QKJICy7YXXbFL0ate3d5fTzrpa5EXFelwE=;\n\th=From:To:Cc:Subject:Date:From;\n\tb=q+LEogQJTIMQ326kqDLiZ+eFOHSQzorvllgIirrB72FcUXdd546ctr0Kqj/1lmMgR\n\teyhPyPePEAFIOKrfEx32ktLQpEIjdnF/g7stEF7QjYGavm8CE0Fq7CodRSZSiKLYyF\n\tZFyG3x0P71ddTlMwVItUGU8XNA4atGLx9etXDUbw=","From":"Kieran Bingham ","To":"libcamera devel ","Cc":"Kieran Bingham ","Subject":"[PATCH v3 00/14] libipa: Introduce a Quantized type","Date":"Thu, 13 Nov 2025 12:24:35 +0000","Message-ID":"<20251113122450.287633-1-kieran.bingham@ideasonboard.com>","X-Mailer":"git-send-email 2.50.1","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"This series superceeds [0] \"rkisp1: cproc - Metadata and Hue\ndevelopments\" by introducing a new base type for libipa to be able to\nmaintain values which are quantized for hardware.\n\nThese data values often need to be converted, perhaps to a fixed-point\nformat for configuration of hardware, but also then back to a floating\npoint for returning as metadata.\n\nIn particular this series builds to solve the review comment that\nblocked the original series at [1]\n\nThe Quantized type provides a storage mechanism to make both of these\nstorage representations visible to code that wishes to utilise the\nspecific values.\n\nThe series then re-introduces the proposed updates to cproc using the\nnew Q types by supplying Fixed Point types and a scaled fixed point type\nfor the Hue control.\n\nTests and documentation are provided throughout.\n\n[0] https://patchwork.libcamera.org/project/libcamera/list/?series=5245\n[1] https://patchwork.libcamera.org/patch/23645/#34626\n\nRunning the tests directly shows the following output (all passing)\n\ntest/ipa/libipa/quantized\nQuantised tests passed successfully.\ntest/ipa/libipa/fixedpoint\n\nQ1_7(-1 .. 0.992188) Min: [0x80:-1] -- Max: [0x7f:0.992188] Step:0.0078125\n Checking -1 == [0x80:-1]\n Checking -0.992 == [0x81:-0.992188]\n Checking -0.006 == [0xff:-0.0078125]\n Checking 0 == [0x00:0]\n Checking 0.008 == [0x01:0.0078125]\n Checking 0.992 == [0x7f:0.992188]\n\nUQ1_7(0 .. 1.99219) Min: [0x00:0] -- Max: [0xff:1.99219] Step:0.0078125\n Checking 0 == [0x00:0]\n Checking 1 == [0x80:1]\n Checking 1.992 == [0xff:1.99219]\n\nQ4_7(-8 .. 7.99219) Min: [0x0400:-8] -- Max: [0x03ff:7.99219] Step:0.0078125\n Checking -8 == [0x0400:-8]\n Checking -0.008 == [0x07ff:-0.0078125]\n Checking 0 == [0x0000:0]\n Checking 0.008 == [0x0001:0.0078125]\n Checking 7.992 == [0x03ff:7.99219]\n Checking 0.2 == [0x001a:0.203125]\n Checking -0.2 == [0x07e6:-0.203125]\n Checking -0.8 == [0x079a:-0.796875]\n Checking -0.4 == [0x07cd:-0.398438]\n Checking -1.4 == [0x074d:-1.39844]\n\nQ5_4(-16 .. 15.9375) Min: [0x0100:-16] -- Max: [0x00ff:15.9375] Step:0.0625\n Checking -16 == [0x0100:-16]\n Checking 15.94 == [0x00ff:15.9375]\n\nQ12_4(-2048 .. 2047.94) Min: [0x8000:-2048] -- Max: [0x7fff:2047.94] Step:0.0625\n Checking 0 == [0x0000:0]\n Checking 7.5 == [0x0078:7.5]\n\nUQ12_4(0 .. 4095.94) Min: [0x0000:0] -- Max: [0xffff:4095.94] Step:0.0625\n Checking 0 == [0x0000:0]\n Checking 7.5 == [0x0078:7.5]\n\nRange validation:\n Checking -100 == [0x80:-1]\n Checking 100 == [0x7f:0.992188]\n Checking -100 == [0x00:0]\n Checking 100 == [0xff:1.99219]\n\n\nScaled Fixed-Point Quantizer tests:\n\nHueQ (Scaled Q1_7 * 90) (-90 .. 89.2969) Min: [0x80:-90] -- Max: [0x7f:89.2969] Step:0.703125\n Checking -90 == [0x80:-90]\n Checking -45 == [0xc0:-45]\n Checking 0 == [0x00:0]\n Checking 45 == [0x40:45]\n Checking 90 == [0x7f:89.2969]\n Checking -99 == [0x80:-90]\n Checking 99 == [0x7f:89.2969]\n\nCPROC Fixed-Point Quantizer conversion tests:\n Checking [0x80:-1] == [0x80:-1]\n Checking [0x7f:0.992188] == [0x7f:0.992188]\n Checking [0x00:0] == [0x00:0]\n Checking [0xff:1.99219] == [0xff:1.99219]\n\n\n\nKieran Bingham (13):\n ipa: libipa: Provide a Quantized data type support\n test: libipa: Add tests for Quantized types\n ipa: libipa: Provide fixed point quantized traits\n test: libipa: Provide FixedPoint Quantized tests\n ipa: libipa: fixedpoint: Fix unsigned usage\n test: libipa: Add Q4.7 type and tests to match existing use case tests\n ipa: libipa: Provide Q5.4 FixedPoint support\n ipa: libipa: fixedpoint: Provide a ScaledFixedPoint type\n test: libipa: Provide ScaledFixedPoint tests\n ipa: rkisp1: cproc: Convert to use Quantized types\n ipa: rkisp1: cproc: Report metadata\n ipa: rkisp1: cproc: Provide a Hue control\n DNI: test: libipa: fixedpoint: Validate extra types\n\nvan Veen, Stephan (1):\n libcamera: controls: Define a new core Hue control\n\n src/ipa/libipa/fixedpoint.cpp | 182 ++++++++++++++++++++\n src/ipa/libipa/fixedpoint.h | 72 ++++++++\n src/ipa/libipa/meson.build | 2 +\n src/ipa/libipa/quantized.cpp | 134 +++++++++++++++\n src/ipa/libipa/quantized.h | 78 +++++++++\n src/ipa/rkisp1/algorithms/cproc.cpp | 66 +++++---\n src/ipa/rkisp1/algorithms/cproc.h | 4 +\n src/ipa/rkisp1/ipa_context.h | 22 ++-\n src/libcamera/control_ids_core.yaml | 13 ++\n test/ipa/libipa/fixedpoint.cpp | 247 +++++++++++++++++++++++++++-\n test/ipa/libipa/meson.build | 1 +\n test/ipa/libipa/quantized.cpp | 130 +++++++++++++++\n 12 files changed, 916 insertions(+), 35 deletions(-)\n create mode 100644 src/ipa/libipa/quantized.cpp\n create mode 100644 src/ipa/libipa/quantized.h\n create mode 100644 test/ipa/libipa/quantized.cpp"}