{"id":24130,"url":"https://patchwork.libcamera.org/api/1.1/covers/24130/?format=json","web_url":"https://patchwork.libcamera.org/cover/24130/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/1.1/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20250815113400.20623-1-laurent.pinchart@ideasonboard.com>","date":"2025-08-15T11:33:52","name":"[v2,0/8] libcamera: Use span in FrameBuffer & assorted cleanups","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/1.1/people/2/?format=json","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"mbox":"https://patchwork.libcamera.org/cover/24130/mbox/","series":[{"id":5383,"url":"https://patchwork.libcamera.org/api/1.1/series/5383/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=5383","date":"2025-08-15T11:33:52","name":"libcamera: Use span in FrameBuffer & assorted cleanups","version":2,"mbox":"https://patchwork.libcamera.org/series/5383/mbox/"}],"comments":"https://patchwork.libcamera.org/api/covers/24130/comments/","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id DA06FBEFBE\n\tfor ;\n\tFri, 15 Aug 2025 11:34:24 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 114A269251;\n\tFri, 15 Aug 2025 13:34:23 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id B1D7461443\n\tfor ;\n\tFri, 15 Aug 2025 13:34:20 +0200 (CEST)","from pendragon.ideasonboard.com (81-175-209-231.bb.dnainternet.fi\n\t[81.175.209.231])\n\tby perceval.ideasonboard.com (Postfix) with UTF8SMTPSA id 5DAE7605;\n\tFri, 15 Aug 2025 13:33:25 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"OXoSPGL+\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1755257605;\n\tbh=Yq/hjF53Cfq75Wcu0WMfSpoPssbtJPnaa4T75Rl64gI=;\n\th=From:To:Cc:Subject:Date:From;\n\tb=OXoSPGL+PVDs75jshxPkW1NV+YsaEQUiv9JbIZ3CStJD1vcd1AADiyh8Jibnp2Qtg\n\tIX5ZWwBvmfEGo7+R/pyBX8r9zxUmLxybTyCeVW3zFzz091kVxlq+1x5TpvTB4bmgh0\n\tf1eyoK31zzcjFgC/mGPHKnRsrjLES1x05725e0i4=","From":"Laurent Pinchart ","To":"libcamera-devel@lists.libcamera.org","Cc":"=?utf-8?q?Daniel_R=C3=A1kos?= ","Subject":"[PATCH v2 0/8] libcamera: Use span in FrameBuffer & assorted\n\tcleanups","Date":"Fri, 15 Aug 2025 14:33:52 +0300","Message-ID":"<20250815113400.20623-1-laurent.pinchart@ideasonboard.com>","X-Mailer":"git-send-email 2.49.1","MIME-Version":"1.0","Content-Type":"text/plain; charset=UTF-8","Content-Transfer-Encoding":"8bit","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"Hello,\n\nThis patch series is the second version of the standalone \"[PATCH]\nlibcamera: framebuffer: Replace vector with span in constructor\" patch.\nIt addresses an oversight in v1, where I forgot to convert the\nFrameBuffer::planes() function to return a span. The first 7 patches are\na consequence of that change.\n\nWith FrameBuffer::planes() returning a span, multiple callers have the\nbe modified through libcamera. While fixing the compilation issues, I\nnoticed a set of small issues that patches 1/8 to 7/8 improve. Splitting\nthem in separate patches also reduces the code changes in 8/8 and makes\nit easier to review.\n\nPatches 1/8 to 5/8 and 7/8 are just small drive-by improvements. Please\nsee individual patches for details. A bit worthier of notice is patch\n6/8 that changes the way the IPA data structures are constructed,\nleading to possible optimizations.\n\nCompared to v1, the FrameBuffer::planes() class now returns a span.\nRequired changes to callers are outlined in the patch. This changes the\nlibcamera ABI and API, requiring recompilation and possibly code\nchanges.\n\nLaurent Pinchart (8):\n libcamera: v4l2_videodevice: Avoid repeated calls to\n FrameBuffer::planes()\n pipeline: ipu3: Drop unneeded forward declarations\n pipeline: rkisp1: Replace error handling gotos with utils::exit_scope\n pipeline: rpi: Use structured bindings in range-based for loop\n pipelines: Use lambda functions to factor out buffer mapping code\n utils: codegen: ipc: Optimize constructors of IPA interface structures\n apps: cam: drm: Drop unneeded local variable\n libcamera: framebuffer: Replace vector with span in constructor\n\n include/libcamera/framebuffer.h | 4 +-\n include/libcamera/internal/framebuffer.h | 3 +-\n .../mm/cros_frame_buffer_allocator.cpp | 2 +-\n .../mm/generic_frame_buffer_allocator.cpp | 2 +-\n src/apps/cam/drm.cpp | 4 +-\n src/libcamera/framebuffer.cpp | 10 ++---\n src/libcamera/pipeline/ipu3/frames.h | 4 --\n src/libcamera/pipeline/ipu3/ipu3.cpp | 19 +++++---\n src/libcamera/pipeline/mali-c55/mali-c55.cpp | 27 ++++++-----\n src/libcamera/pipeline/rkisp1/rkisp1.cpp | 45 ++++++++++---------\n .../pipeline/rpi/common/pipeline_base.cpp | 10 +++--\n src/libcamera/pipeline/vimc/vimc.cpp | 5 ++-\n src/libcamera/pipeline/virtual/virtual.cpp | 3 +-\n src/libcamera/v4l2_videodevice.cpp | 13 +++---\n .../definition_functions.tmpl | 4 +-\n 15 files changed, 84 insertions(+), 71 deletions(-)\n\n\nbase-commit: af43c2f945c42cc7d111de63abed9ca3df830ca4\n--\nRegards,\n\nLaurent Pinchart"}