{"id":23461,"url":"https://patchwork.libcamera.org/api/1.1/covers/23461/?format=json","web_url":"https://patchwork.libcamera.org/cover/23461/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/1.1/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20250604130741.9228-1-laurent.pinchart@ideasonboard.com>","date":"2025-06-04T13:07:34","name":"[v2,0/7] gstreamer: Miscellaneous cleanups + two fixes","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/1.1/people/2/?format=json","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"mbox":"https://patchwork.libcamera.org/cover/23461/mbox/","series":[{"id":5204,"url":"https://patchwork.libcamera.org/api/1.1/series/5204/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=5204","date":"2025-06-04T13:07:34","name":"gstreamer: Miscellaneous cleanups + two fixes","version":2,"mbox":"https://patchwork.libcamera.org/series/5204/mbox/"}],"comments":"https://patchwork.libcamera.org/api/covers/23461/comments/","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 5FE66C31E9\n\tfor ;\n\tWed, 4 Jun 2025 13:07:55 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id D23B368DBE;\n\tWed, 4 Jun 2025 15:07:53 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 921AD68DA8\n\tfor ;\n\tWed, 4 Jun 2025 15:07:51 +0200 (CEST)","from pendragon.ideasonboard.com (81-175-209-231.bb.dnainternet.fi\n\t[81.175.209.231])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 6AE8778C;\n\tWed, 4 Jun 2025 15:07:48 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"FcWrrSNk\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1749042468;\n\tbh=QlajVHy2gd+XGIkL66x2E7vIH8KbKZew1C4ykfjr0B4=;\n\th=From:To:Cc:Subject:Date:From;\n\tb=FcWrrSNkdi8HLqNBwrx2DnGaWJypVbHP4FqTcV5x+uh9wxRBUpgRIw9CWXTFTcjA9\n\tIHJPfz/6gZg+RC9E5Acb/9q1GqiG7VCdwGBB04FR92WuyYWSBk3Uhdy6h+AEFLYLMO\n\t+cduU6Bood1gPIR8BlJrycKEHIQgIWXd4kJJren4=","From":"Laurent Pinchart ","To":"libcamera-devel@lists.libcamera.org","Cc":"Hou Qi ,\n\tNicolas Dufresne ","Subject":"[PATCH v2 0/7] gstreamer: Miscellaneous cleanups + two fixes","Date":"Wed, 4 Jun 2025 16:07:34 +0300","Message-ID":"<20250604130741.9228-1-laurent.pinchart@ideasonboard.com>","X-Mailer":"git-send-email 2.49.0","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"Hello everybody,\n\nHere's a set of miscellaneous cleanups for libcamerasrc that follow the\nrecently added GstVideoMeta support. They mostly improve readability,\nbut patches 5/7 and 6/7 also fix two leaks and a use-after-free\nrespectively.\n\nCompared to v1, I've addressed review comments, reordered the patches,\nadded more leak and use-after-free fixes, added patch 7/7, and performed\nother small changes as detailed in the per-patch changelogs.\n\nThe code has still been compile-tested only as I haven't managed to\nexercize the video pool creation code path yet. Hou, would you be able\nto test this series ?\n\nLaurent Pinchart (7):\n gstreamer: Document improvements when updating minimum GStreamer\n version\n gstreamer: Factor out video pool creation\n gstreamer: Reduce indentation in gst_libcamera_create_video_pool()\n gstreamer: Rename variable in gst_libcamera_create_video_pool()\n gstreamer: Fix leak of GstQuery and GstBufferPool in error path\n gstreamer: Drop incorrect unref on caps\n gstreamer: Replace NULL with nullptr\n\n src/gstreamer/gstlibcamera-controls.cpp.in | 2 +-\n src/gstreamer/gstlibcamerapad.cpp | 2 +-\n src/gstreamer/gstlibcamerasrc.cpp | 146 ++++++++++++++-------\n 3 files changed, 98 insertions(+), 52 deletions(-)\n\n\nbase-commit: 290d3f82e3e3e313932a201308813c75131d16f1\n--\nRegards,\n\nLaurent Pinchart"}