{"id":23329,"url":"https://patchwork.libcamera.org/api/1.1/covers/23329/?format=json","web_url":"https://patchwork.libcamera.org/cover/23329/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/1.1/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20250501141609.717148-1-kieran.bingham@ideasonboard.com>","date":"2025-05-01T14:16:06","name":"[0/3] libcamera: rkisp1: Camera Sensor Mode Validation","submitter":{"id":4,"url":"https://patchwork.libcamera.org/api/1.1/people/4/?format=json","name":"Kieran Bingham","email":"kieran.bingham@ideasonboard.com"},"mbox":"https://patchwork.libcamera.org/cover/23329/mbox/","series":[{"id":5159,"url":"https://patchwork.libcamera.org/api/1.1/series/5159/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=5159","date":"2025-05-01T14:16:06","name":"libcamera: rkisp1: Camera Sensor Mode Validation","version":1,"mbox":"https://patchwork.libcamera.org/series/5159/mbox/"}],"comments":"https://patchwork.libcamera.org/api/covers/23329/comments/","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 621EAC327D\n\tfor ;\n\tThu, 1 May 2025 14:16:15 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 9D63568ADB;\n\tThu, 1 May 2025 16:16:14 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 80455617D7\n\tfor ;\n\tThu, 1 May 2025 16:16:13 +0200 (CEST)","from Monstersaurus.lgs-net.com\n\t(cpc89244-aztw30-2-0-cust6594.18-1.cable.virginm.net [86.31.185.195])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 33BEC63D;\n\tThu, 1 May 2025 16:16:06 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"vbWk2LNd\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1746108966;\n\tbh=lQ6Ik85df2OArFpp+rU0pS5/jIFfVEEm5zHZ06de9g4=;\n\th=From:To:Cc:Subject:Date:From;\n\tb=vbWk2LNdWdaBRFhxB+3ua7/ibZDoPViywpVlPlqrQn+q1g5BEkOG0OV3hD0EU1xiG\n\tN2DDkTRAX3cLgbIvMps9v4B39yQnnGBdgXZmZtSzcIiNZREJeLWFx/FdVkH3nXL3+b\n\tvujuHHDN7x96pvkN7Q6rcCWGQYLAYCyAq6O/ZYUs=","From":"Kieran Bingham ","To":"libcamera devel ","Cc":"Kieran Bingham ","Subject":"[PATCH 0/3] libcamera: rkisp1: Camera Sensor Mode Validation","Date":"Thu, 1 May 2025 15:16:06 +0100","Message-ID":"<20250501141609.717148-1-kieran.bingham@ideasonboard.com>","X-Mailer":"git-send-email 2.48.1","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"While testing the RKISP1 with dewarp features enabled, it is possible to\nhave a camera with a default 90* rotation. During testing it becomes\nvery easy to transpose the width and height - which can lead to asking\nfor an invalid camera configuration.\n\nThis demonstrated itself as a configuration that was successfully\nvalidated, but that could never successfully configure.\n\nExpand the CameraSensor classes to aid reporting this instance to the\nuser, and ensure that if an invalid sensor configuration is selected\nthat the Configuration is rejected as Invalid.\n\nFurther extend the 'cam' tool to support setting the\nrotation(Orientations) accordingly which then allows the desired\nconfiguration to be tested correctly.\n\nKieran Bingham (3):\n libcamera: pipeline: rkisp1: Detect invalid sensor configurations\n libcamera: camera_sensor: Extend reporting in getFormat()\n apps: cam: Support full orientation options\n\n src/apps/cam/camera_session.cpp | 9 +++++++++\n src/apps/cam/main.cpp | 5 ++++-\n src/libcamera/pipeline/rkisp1/rkisp1.cpp | 12 ++++++++++++\n src/libcamera/sensor/camera_sensor_legacy.cpp | 4 +++-\n src/libcamera/sensor/camera_sensor_raw.cpp | 4 +++-\n 5 files changed, 31 insertions(+), 3 deletions(-)"}