{"id":23252,"url":"https://patchwork.libcamera.org/api/1.1/covers/23252/?format=json","web_url":"https://patchwork.libcamera.org/cover/23252/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/1.1/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20250424114103.451395-1-barnabas.pocze@ideasonboard.com>","date":"2025-04-24T11:40:54","name":"[RFC,v5,0/9] libcamera: process: Remove `ProcessManager` singleton","submitter":{"id":216,"url":"https://patchwork.libcamera.org/api/1.1/people/216/?format=json","name":"Barnabás Pőcze","email":"barnabas.pocze@ideasonboard.com"},"mbox":"https://patchwork.libcamera.org/cover/23252/mbox/","series":[{"id":5145,"url":"https://patchwork.libcamera.org/api/1.1/series/5145/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=5145","date":"2025-04-24T11:40:54","name":"libcamera: process: Remove `ProcessManager` singleton","version":5,"mbox":"https://patchwork.libcamera.org/series/5145/mbox/"}],"comments":"https://patchwork.libcamera.org/api/covers/23252/comments/","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 0B07AC327D\n\tfor ;\n\tThu, 24 Apr 2025 11:41:11 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id CA06C68ADA;\n\tThu, 24 Apr 2025 13:41:09 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 461C068ACC\n\tfor ;\n\tThu, 24 Apr 2025 13:41:07 +0200 (CEST)","from pb-laptop.local (185.221.143.16.nat.pool.zt.hu\n\t[185.221.143.16])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id E1CF7F01\n\tfor ;\n\tThu, 24 Apr 2025 13:41:04 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"UwOkyl3m\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1745494865;\n\tbh=LJ/uVHH/4VdrTBZ9Lra9dio0aABzsV2WrYg7Z6h9dJ0=;\n\th=From:To:Subject:Date:From;\n\tb=UwOkyl3mNPL/x6VWjfbL8JbPZQPtQszbTJBqfVRdFvEbC5cPjOnTFe4rpDdkLTG6g\n\tC9yZupfV4QgcgfWzj7AHE0+kwIyZtCJFotfWoPhK4Ih87uoQC4u2UauSq7VfALZ6eP\n\tiGUmmCE4JrPqawDCZj96B/jMdLjEQ98zJTFbcisw=","From":"=?utf-8?q?Barnab=C3=A1s_P=C5=91cze?= ","To":"libcamera-devel@lists.libcamera.org","Subject":"[RFC PATCH v5 0/9] libcamera: process: Remove `ProcessManager`\n\tsingleton","Date":"Thu, 24 Apr 2025 13:40:54 +0200","Message-ID":"<20250424114103.451395-1-barnabas.pocze@ideasonboard.com>","X-Mailer":"git-send-email 2.49.0","MIME-Version":"1.0","Content-Type":"text/plain; charset=UTF-8","Content-Transfer-Encoding":"8bit","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"The main goal is to remove the need for the ProcessManager singleton. That\nis achieved by using pidfd + clone3(), which raises the minimum\nkernel version to 5.4. There are also additional misc. changes.\n\nchanges in v5:\n * send the actually intended version...\n\nchanges in v4:\n * address review comments\n\nv4: https://patchwork.libcamera.org/cover/23242/\nv3: https://patchwork.libcamera.org/cover/23013/\nv2: https://patchwork.libcamera.org/patch/22609/\nv1: https://patchwork.libcamera.org/patch/22522/\n\nBarnabás Pőcze (9):\n libcamera: process: Disable copy/move\n libcamera: process: Misc. cleanup around `execv()`\n libcamera: process: Use `pid_` member to decide if running\n libcamera: process: Return error if already running\n libcamera: process: Ensure that file descriptors are nonnegative\n libcamera: process: Use span instead of vector\n libcamera: process: Move `closeAllFdsExcept()`\n libcamera: process: Use `close_range()` when available\n libcamera: process: Remove `ProcessManager` singleton\n\n include/libcamera/internal/camera_manager.h | 1 -\n include/libcamera/internal/process.h | 45 +--\n meson.build | 6 +-\n src/libcamera/ipc_pipe_unixsocket.cpp | 9 +-\n src/libcamera/process.cpp | 312 +++++++-------------\n test/ipc/unixsocket_ipc.cpp | 2 -\n test/log/log_process.cpp | 2 -\n test/process/process_test.cpp | 7 +-\n 8 files changed, 124 insertions(+), 260 deletions(-)\n\n--\n2.49.0"}