{"id":23028,"url":"https://patchwork.libcamera.org/api/1.1/covers/23028/?format=json","web_url":"https://patchwork.libcamera.org/cover/23028/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/1.1/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20250326080034.1733385-1-paul.elder@ideasonboard.com>","date":"2025-03-26T08:00:30","name":"[v2,0/3] libipa: Fix CameraSensorHelper gain helpers","submitter":{"id":17,"url":"https://patchwork.libcamera.org/api/1.1/people/17/?format=json","name":"Paul Elder","email":"paul.elder@ideasonboard.com"},"mbox":"https://patchwork.libcamera.org/cover/23028/mbox/","series":[{"id":5081,"url":"https://patchwork.libcamera.org/api/1.1/series/5081/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=5081","date":"2025-03-26T08:00:30","name":"libipa: Fix CameraSensorHelper gain helpers","version":2,"mbox":"https://patchwork.libcamera.org/series/5081/mbox/"}],"comments":"https://patchwork.libcamera.org/api/covers/23028/comments/","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 735F3C323E\n\tfor ;\n\tWed, 26 Mar 2025 08:00:46 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 89D9668955;\n\tWed, 26 Mar 2025 09:00:45 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 6D85B6894B\n\tfor ;\n\tWed, 26 Mar 2025 09:00:44 +0100 (CET)","from neptunite.flets-east.jp (unknown\n\t[IPv6:2404:7a81:160:2100:7402:917d:ea0c:6d4c])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 79F853A4;\n\tWed, 26 Mar 2025 08:58:55 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"dpAbzls2\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1742975936;\n\tbh=6aVKyIGRMPfY7WDiDxG4+gHyEbnSl+OdY8gUjWxzd6U=;\n\th=From:To:Cc:Subject:Date:From;\n\tb=dpAbzls2gBKVQ3nRwPkv1cqDnPAtcfjbo/KH49hS8mdMw1VKR2N7z3F6xXGs6HZhJ\n\t36c01gRfQ5jGuHozyTJWD/huUF5ngG0vg8p7lL0rt+/sfIm8k8ZQqE7b4T4yNF292A\n\tq10BmZOi7AReweh3m0TdeOJ31jiqJfLhVWzswIT4=","From":"Paul Elder ","To":"libcamera-devel@lists.libcamera.org","Cc":"Paul Elder ","Subject":"[PATCH v2 0/3] libipa: Fix CameraSensorHelper gain helpers","Date":"Wed, 26 Mar 2025 17:00:30 +0900","Message-ID":"<20250326080034.1733385-1-paul.elder@ideasonboard.com>","X-Mailer":"git-send-email 2.47.2","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"The CameraSensorHelper class provides helpers to simplify the\ndescriptions of gain models of the sensors.\n\nThis provides an implementation of converting a gain-code to a linear\ngain value, and a return calculation that converts a linear gain to a\ngain code.\n\nIt could be expected that a gain value reported by the 'gain(code)'\nfunction should itself generate the same code when called into\n'gainCode(gain)' but this is not the case.\n\nThis series addresses this by correcting the rounding issue and adding a\ntest to ensure all CameraSensorHelpers meet this expectation.\n\nNote that the test needs extended as it falsly identifies a failure in\nthe ar0521 helper.\n\nv2 mainly recovers from bitrot.\n\nKieran Bingham (3):\n ipa: libipa: Allow retrieving the name of a CameraSensorHelperFactory\n test: ipa: libipa: Add CameraSensorHelper Gain Model tests\n libipa: camera_sensor_helper: Fix rounding of gainCode\n\n src/ipa/libipa/camera_sensor_helper.cpp | 6 +--\n src/ipa/libipa/camera_sensor_helper.h | 2 +\n test/ipa/camera_sensor_helper.cpp | 69 +++++++++++++++++++++++++\n test/ipa/meson.build | 1 +\n 4 files changed, 75 insertions(+), 3 deletions(-)\n create mode 100644 test/ipa/camera_sensor_helper.cpp"}