{"id":22978,"url":"https://patchwork.libcamera.org/api/1.1/covers/22978/?format=json","web_url":"https://patchwork.libcamera.org/cover/22978/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/1.1/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20250319161152.63625-1-stefan.klug@ideasonboard.com>","date":"2025-03-19T16:11:05","name":"[v2,00/17] Some rkisp1 awb improvements","submitter":{"id":184,"url":"https://patchwork.libcamera.org/api/1.1/people/184/?format=json","name":"Stefan Klug","email":"stefan.klug@ideasonboard.com"},"mbox":"https://patchwork.libcamera.org/cover/22978/mbox/","series":[{"id":5071,"url":"https://patchwork.libcamera.org/api/1.1/series/5071/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=5071","date":"2025-03-19T16:11:05","name":"Some rkisp1 awb improvements","version":2,"mbox":"https://patchwork.libcamera.org/series/5071/mbox/"}],"comments":"https://patchwork.libcamera.org/api/covers/22978/comments/","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 03368C32FE\n\tfor ;\n\tWed, 19 Mar 2025 16:11:59 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 4A977687FA;\n\tWed, 19 Mar 2025 17:11:58 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 1889A687FA\n\tfor ;\n\tWed, 19 Mar 2025 17:11:57 +0100 (CET)","from ideasonboard.com (unknown\n\t[IPv6:2a00:6020:448c:6c00:760:e5ca:4814:99c7])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 1F73B55A;\n\tWed, 19 Mar 2025 17:10:14 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"ZJUr01uj\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1742400614;\n\tbh=kwxhQozAvJ2V5t+2fR369MU6/hY3k+gDyK2F/DC+AZA=;\n\th=From:To:Cc:Subject:Date:From;\n\tb=ZJUr01ujd9l3AWb0yGPZl3gfGfyg6xQHEr+bd4ACFySZFFcZeJsTWQeH2cL7Sqfn5\n\tjixODzbknBU5NWPMShMCiToHJPT/zH08NDhf6ZOXILJW4VxrxlaCCiXAIjnc3LfPwL\n\t61FeTFURzLzWb8WFtbycjd/Ko7nra2+EQt1ccwl4=","From":"Stefan Klug ","To":"libcamera-devel@lists.libcamera.org","Cc":"Stefan Klug ","Subject":"[PATCH v2 00/17] Some rkisp1 awb improvements","Date":"Wed, 19 Mar 2025 17:11:05 +0100","Message-ID":"<20250319161152.63625-1-stefan.klug@ideasonboard.com>","X-Mailer":"git-send-email 2.43.0","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"Hi all,\n\nThis series contains a few fixes that greatly improve and stabilize the\nAWB handling on rkisp1.\n\nAfter the feedback from the first version, some parts were rewritten and\nLaurent added a generic matrix inverse function.\n\nPatches 1-8 add utility functions to Vector and Matrix.\n\nThe rest fixes some bugs and generally improves the AWB on rkisp1.\nPlease see the individual patches for details.\n\nBest regards,\nStefan\n\nChanges in v2:\n\n- Replaced the matrix cast() and inverse() functions by better alternatives\n- Added a manual CCM control\n- Some small fixes (see logs in individual patches)\n\n\nLaurent Pinchart (2):\n libcamera: matrix: Extend multiplication operator to heterogenous\n types\n libcamera: vector: Extend matrix multiplication operator to\n heterogenous types\n\nStefan Klug (15):\n libcamera: matrix: Replace SFINAE with static_asserts\n libcamera: matrix: Make most functions constexpr\n libcamera: matrix: Add a Span based constructor\n libcamera: vector: Add a Span based constructor\n libcamera: matrix: Add inverse() function\n test: Add minimal test for Matrix\n ipa: rkisp1: Refactor automatic/manual structure in IPAActiveState\n ipa: rkisp1: ccm/lsc: Fix CCM/LSC based on manual color temperature\n ipa: rkisp1: Implement manual ColourCorrectionMatrix control\n libipa: awb: Make result of gainsFromColourTemp optional\n ipa: rkisp1: awb: Use gains from color temperature curve\n ipa: rkisp1: Damp color temperature regulation\n ipa: rkisp1: awb: Set rgb mean limits to 180\n ipa: rkisp1: awb: Take the CCM into account for the AWB gains\n calculation\n ipa: rkisp1: awb: Avoid division by zero\n\n include/libcamera/internal/matrix.h | 82 ++++++-------\n include/libcamera/internal/vector.h | 21 ++--\n src/ipa/libipa/awb.cpp | 2 +-\n src/ipa/libipa/awb.h | 2 +-\n src/ipa/libipa/awb_bayes.cpp | 4 +-\n src/ipa/libipa/awb_bayes.h | 2 +-\n src/ipa/libipa/awb_grey.cpp | 6 +-\n src/ipa/libipa/awb_grey.h | 2 +-\n src/ipa/rkisp1/algorithms/awb.cpp | 79 ++++++++-----\n src/ipa/rkisp1/algorithms/ccm.cpp | 63 ++++++++--\n src/ipa/rkisp1/algorithms/ccm.h | 6 +\n src/ipa/rkisp1/algorithms/lsc.cpp | 6 +-\n src/ipa/rkisp1/ipa_context.h | 15 ++-\n src/libcamera/matrix.cpp | 175 +++++++++++++++++++++++++++-\n src/libcamera/vector.cpp | 13 ++-\n test/matrix.cpp | 53 +++++++++\n test/meson.build | 1 +\n 17 files changed, 427 insertions(+), 105 deletions(-)\n create mode 100644 test/matrix.cpp"}