{"id":22864,"url":"https://patchwork.libcamera.org/api/1.1/covers/22864/?format=json","web_url":"https://patchwork.libcamera.org/cover/22864/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/1.1/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20250225164116.414301-1-stanislaw.gruszka@linux.intel.com>","date":"2025-02-25T16:41:11","name":"[v5,0/5] libcamera: start frame events changes","submitter":{"id":211,"url":"https://patchwork.libcamera.org/api/1.1/people/211/?format=json","name":"Stanislaw Gruszka","email":"stanislaw.gruszka@linux.intel.com"},"mbox":"https://patchwork.libcamera.org/cover/22864/mbox/","series":[{"id":5021,"url":"https://patchwork.libcamera.org/api/1.1/series/5021/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=5021","date":"2025-02-25T16:41:11","name":"libcamera: start frame events changes","version":5,"mbox":"https://patchwork.libcamera.org/series/5021/mbox/"}],"comments":"https://patchwork.libcamera.org/api/covers/22864/comments/","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 62817BDB1C\n\tfor ;\n\tTue, 25 Feb 2025 16:41:34 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 7AC476871F;\n\tTue, 25 Feb 2025 17:41:33 +0100 (CET)","from mgamail.intel.com (mgamail.intel.com [192.198.163.11])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id CCEB4686D6\n\tfor ;\n\tTue, 25 Feb 2025 17:41:30 +0100 (CET)","from fmviesa009.fm.intel.com ([10.60.135.149])\n\tby fmvoesa105.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;\n\t25 Feb 2025 08:41:29 -0800","from sgruszka-mobl.ger.corp.intel.com (HELO localhost)\n\t([10.245.115.185]) by fmviesa009-auth.fm.intel.com with\n\tESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 25 Feb 2025 08:41:27 -0800"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (2048-bit key;\n\tunprotected) header.d=intel.com header.i=@intel.com\n\theader.b=\"HAkNTRQN\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple;\n\td=intel.com; i=@intel.com; q=dns/txt; s=Intel;\n\tt=1740501691; x=1772037691;\n\th=from:to:cc:subject:date:message-id:mime-version:\n\tcontent-transfer-encoding;\n\tbh=+0TiGhdKBZmHLDROsWk5daRW6d5aH1CaBveQK4Ng9n4=;\n\tb=HAkNTRQNVKW3OAN0xwQIIB619MlcnaO7XqKcOY5jHV9gINssMLaNMLkn\n\t/aUDntTsmnvB2SkrGJ+pDGXaJKa+B68kniVkWs8446lvKH7iY3fQio30Z\n\tsu35vr/QCwHZJCit7OBCksbVtpzDoaBk5/RVeFconyCMAxlzCceBtE8XE\n\t3Z/wZSGkZ6pIjrRzvpiEH72kHrMlnVJYMcz6swm9WHoR+z0CTcEDX9C2c\n\tEE/+G6vNeTqAsUiXeGrVcHbuQWye75BRPJck0OLunJfw1jAQLeHScWlto\n\twCRsgmKVjWLgXJcU52381yr9Z7lw2etgtnjFEAmvMqDwutoKcv9iCbIJS w==;","X-CSE-ConnectionGUID":["AUCOoJzcSIWsOu3bGMuUdw==","LbmXNo/BQXG/KIB/CxbVFQ=="],"X-CSE-MsgGUID":["PXYayN9GRmO11jiCEbKs7w==","DtR1BxUhSCChJ+AQTpQ2WA=="],"X-IronPort-AV":["E=McAfee;i=\"6700,10204,11356\"; a=\"51948199\"","E=Sophos;i=\"6.13,314,1732608000\"; d=\"scan'208\";a=\"51948199\"","E=Sophos;i=\"6.13,314,1732608000\"; d=\"scan'208\";a=\"117050535\""],"X-ExtLoop1":"1","From":"Stanislaw Gruszka ","To":"libcamera-devel@lists.libcamera.org","Cc":"Milan Zamazal ,\n\tLaurent Pinchart ,\n\tKieran Bingham ,\n\tNaushir Patuck ,\n\tSakari Ailus ,\n\tHans de Goede ","Subject":"[PATCH v5 0/5] libcamera: start frame events changes","Date":"Tue, 25 Feb 2025 17:41:11 +0100","Message-Id":"<20250225164116.414301-1-stanislaw.gruszka@linux.intel.com>","X-Mailer":"git-send-email 2.34.1","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"v4 -> v5:\n - split patch2 into 3 separte patches\n - drop frameStartEnabled(), return error from start\n - use for (const Entity &entity : entities_) insted of iterator\n - reset delayed controls before enabling events\n - drop R-b , T-b tags since code changes substantially since got them\n\nv3 -> v4:\n - constify frameStartEnabled()\n - make supportsFrameStartEvent() more readable\n - rename eventEmitter to startFrameEmitter\n - update patch2 changelog to make it more clear\n\nv2 -> v3:\n - add helpers for v4l2_device\n - initialize eventEmitter_ in init(), when no proper device is found\n use nullptr (this fix crash seen by Kieran as eventEmitetter was\n\t not nullptr in v2)\n\nv1 -> v2:\n - make eventEmitter_ subdevice part of SimpleCameraData\n - add debug log when found event emitter device\n - nullify eventEmitter_ on stop\n - remove direct sensor_->setControls()\n - add delayedCtrls_->reset() on start\n\n\nLaurent Pinchart (1):\n pipeline: simple: Create DelayedControls instance once only\n\nStanislaw Gruszka (4):\n libcamera: v4l2_device: add frame start event helpers\n pipeline: simple: Use proper device for frame start events\n pipeline: simple: Connect and disconnect start frame events\n pipeline: simple: Do not apply controls twice\n\n include/libcamera/internal/v4l2_device.h | 1 +\n src/libcamera/pipeline/simple/simple.cpp | 58 ++++++++++++++++++------\n src/libcamera/v4l2_device.cpp | 19 ++++++++\n 3 files changed, 65 insertions(+), 13 deletions(-)\n\n--\n2.43.0"}