{"id":22840,"url":"https://patchwork.libcamera.org/api/1.1/covers/22840/?format=json","web_url":"https://patchwork.libcamera.org/cover/22840/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/1.1/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20250224120854.19747-1-mzamazal@redhat.com>","date":"2025-02-24T12:08:49","name":"[0/5] Fix occasional software ISP assertion error on stop","submitter":{"id":177,"url":"https://patchwork.libcamera.org/api/1.1/people/177/?format=json","name":"Milan Zamazal","email":"mzamazal@redhat.com"},"mbox":"https://patchwork.libcamera.org/cover/22840/mbox/","series":[{"id":5015,"url":"https://patchwork.libcamera.org/api/1.1/series/5015/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=5015","date":"2025-02-24T12:08:49","name":"Fix occasional software ISP assertion error on stop","version":1,"mbox":"https://patchwork.libcamera.org/series/5015/mbox/"}],"comments":"https://patchwork.libcamera.org/api/covers/22840/comments/","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id AE75CC324E\n\tfor ;\n\tMon, 24 Feb 2025 12:09:11 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id B8DA9686E5;\n\tMon, 24 Feb 2025 13:09:10 +0100 (CET)","from us-smtp-delivery-124.mimecast.com\n\t(us-smtp-delivery-124.mimecast.com [170.10.133.124])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 7838061856\n\tfor ;\n\tMon, 24 Feb 2025 13:09:09 +0100 (CET)","from mx-prod-mc-08.mail-002.prod.us-west-2.aws.redhat.com\n\t(ec2-35-165-154-97.us-west-2.compute.amazonaws.com [35.165.154.97])\n\tby relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3,\n\tcipher=TLS_AES_256_GCM_SHA384) id us-mta-186-XGvwM4nLMqytWePACGT4Fw-1;\n\tMon, 24 Feb 2025 07:09:03 -0500","from mx-prod-int-04.mail-002.prod.us-west-2.aws.redhat.com\n\t(mx-prod-int-04.mail-002.prod.us-west-2.aws.redhat.com\n\t[10.30.177.40])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\tkey-exchange X25519 server-signature RSA-PSS (2048 bits)\n\tserver-digest SHA256) (No client certificate requested)\n\tby mx-prod-mc-08.mail-002.prod.us-west-2.aws.redhat.com (Postfix)\n\twith ESMTPS id 81D6F180087E; Mon, 24 Feb 2025 12:09:02 +0000 (UTC)","from mzamazal-thinkpadp1gen7.tpbc.com (unknown [10.45.225.60])\n\tby mx-prod-int-04.mail-002.prod.us-west-2.aws.redhat.com (Postfix)\n\twith ESMTP id 3158F19560AA; Mon, 24 Feb 2025 12:08:59 +0000 (UTC)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=redhat.com header.i=@redhat.com\n\theader.b=\"KUJzXfs1\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;\n\ts=mimecast20190719; t=1740398948;\n\th=from:from:reply-to:subject:subject:date:date:message-id:message-id:\n\tto:to:cc:cc:mime-version:mime-version:content-type:content-type:\n\tcontent-transfer-encoding:content-transfer-encoding;\n\tbh=3jk3NvYAXVXcVdb0xqM4LI7YbS8UYv7Aoym1N33l04c=;\n\tb=KUJzXfs14CCEYrBsKkFBKN0MraG3Olr9PqVKfCplLSwAOG1iq10H0YDuGhu1Y4ZssVVijL\n\tDDe6Z5O2CgDnTKXAwqcusSEZzKoW84IicbO00ipLaZAf6gSYEWjL7lbGcYnYoL7ZCB8xTt\n\t6+FT0NwwgLbpy95T+CzBbaRR5s+rqsI=","X-MC-Unique":"XGvwM4nLMqytWePACGT4Fw-1","X-Mimecast-MFC-AGG-ID":"XGvwM4nLMqytWePACGT4Fw_1740398942","From":"Milan Zamazal ","To":"libcamera-devel@lists.libcamera.org","Cc":"Milan Zamazal ,\n\tStanislaw Gruszka ,\n\tLaurent Pinchart ,\n\tKieran Bingham ","Subject":"[PATCH 0/5] Fix occasional software ISP assertion error on stop","Date":"Mon, 24 Feb 2025 13:08:49 +0100","Message-ID":"<20250224120854.19747-1-mzamazal@redhat.com>","MIME-Version":"1.0","X-Scanned-By":"MIMEDefang 3.0 on 10.30.177.40","X-Mimecast-Spam-Score":"0","X-Mimecast-MFC-PROC-ID":"2PgxDnF7in5fl9LXoaptnMUZhIJDN_xs3Ps4dnGNdLA_1740398942","X-Mimecast-Originator":"redhat.com","Content-Transfer-Encoding":"8bit","content-type":"text/plain; charset=\"US-ASCII\"; x-default=true","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"When software ISP is stopped, there can be pending messages in the\nmessage queue that will attempt to call the already stopped IPA,\nresulting in an assertion error like this:\n\n FATAL default soft_ipa_proxy.cpp:456 assertion \"state_ == ProxyRunning\" failed in processStatsThread()\n\nThis patch series fixes the problem and also attempts to prevent other\nproblems related to message handling when or after software ISP is\nstopped.\n\nMilan Zamazal (5):\n libcamera: software_isp: Emit ispStatsReady only if IPA is running\n libcamera: software_isp: Handle queued output buffers on stop\n libcamera: software_isp: Handle queued input buffers on stop\n libcamera: base: Fix formatting in thread.cpp\n libcamera: software_isp: Modify dispatching messages on stop\n\n include/libcamera/base/thread.h | 3 +-\n .../internal/software_isp/software_isp.h | 3 ++\n src/libcamera/base/thread.cpp | 19 ++++----\n src/libcamera/software_isp/software_isp.cpp | 46 +++++++++++++++++--\n .../libcamera_templates/proxy_functions.tmpl | 2 +-\n 5 files changed, 58 insertions(+), 15 deletions(-)"}