{"id":22031,"url":"https://patchwork.libcamera.org/api/1.1/covers/22031/?format=json","web_url":"https://patchwork.libcamera.org/cover/22031/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/1.1/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20241120142807.2093301-1-stefan.klug@ideasonboard.com>","date":"2024-11-20T14:27:47","name":"[v3,0/9] Move Matrix class from libipa to libcamera","submitter":{"id":184,"url":"https://patchwork.libcamera.org/api/1.1/people/184/?format=json","name":"Stefan Klug","email":"stefan.klug@ideasonboard.com"},"mbox":"https://patchwork.libcamera.org/cover/22031/mbox/","series":[{"id":4809,"url":"https://patchwork.libcamera.org/api/1.1/series/4809/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=4809","date":"2024-11-20T14:27:47","name":"Move Matrix class from libipa to libcamera","version":3,"mbox":"https://patchwork.libcamera.org/series/4809/mbox/"}],"comments":"https://patchwork.libcamera.org/api/covers/22031/comments/","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 2D6E4C0F2A\n\tfor ;\n\tWed, 20 Nov 2024 14:28:17 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 5531465F54;\n\tWed, 20 Nov 2024 15:28:16 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 0586465898\n\tfor ;\n\tWed, 20 Nov 2024 15:28:14 +0100 (CET)","from ideasonboard.com (unknown\n\t[IPv6:2a00:6020:448c:6c00:bbd:82cc:f3f3:e12e])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id A1B8B55A;\n\tWed, 20 Nov 2024 15:27:55 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"XW0nPN4B\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1732112875;\n\tbh=zvJdYOpt3fBO507EDZl5ex50+LyqHca3THSJFRLcv6k=;\n\th=From:To:Cc:Subject:Date:From;\n\tb=XW0nPN4BDySKneTgx/+A/GZbT2BNes7DYtn2uc7sN5F9Lp8ccwATer+lxhF7E/CDx\n\t446EOexRRvuPuejVteXOfvk93/vBRmQcmOgYt4AUMfg67z97r1cFp6NbUVBdKHiHF8\n\tH6z11tvrYdiSX7NTUkz+S1ObMFUSU+t4y0bMAqKU=","From":"Stefan Klug ","To":"libcamera-devel@lists.libcamera.org","Cc":"Stefan Klug ","Subject":"[PATCH v3 0/9] Move Matrix class from libipa to libcamera","Date":"Wed, 20 Nov 2024 15:27:47 +0100","Message-ID":"<20241120142807.2093301-1-stefan.klug@ideasonboard.com>","X-Mailer":"git-send-email 2.43.0","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"Hi all,\n\nMy upcoming dewarper series implements parametric lens dewarping inside\nthe rkisp1 pipeline. That code makes use of the Matrix class but lives\noutside of the IPA. I suspect there will be more cases, where a matrix\nis of good use inside libcamera.\n\nThis series movies the Matrix into libacmera/internal. As that gets\nlinked to the IPAs anyways, there are no negative effects for the IPAs.\n\nThis was tested on an imx8mp and the RaspberryPi.\n\nRegards,\nStefan\n\nChanges since v2:\n- Collected tags\n- Fixed comments from review\n- Tested on RaspberryPi\n\nChanges since v1:\n- Split into smaller patches\n- Replaced the initializer_list based constructor with a std::vector\n based one to align with Vector\n- Dropped the Span based constructor as it is not used anywhere\n\nStefan Klug (9):\n ipa: rpi: Rename Matrix to Matrix3x3\n libcamera: Copy Matrix class from libipa to libcamera\n libcamera: internal: Move Matrix class into libcamera namespace\n libcamera: internal: matrix: Replace vector with array in constructor\n libcamera: internal: Add Matrix class to build\n ipa: rpi: ccm: Replace local matrix implementation with the one from\n libcamera\n libipa: Use Matrix class from libcamera\n rkisp1: Use Matrix class from libcamera\n libipa: Drop Matrix class\n\n .../libcamera/internal}/matrix.h | 16 ++---\n include/libcamera/internal/meson.build | 1 +\n src/ipa/libipa/meson.build | 2 -\n src/ipa/libipa/vector.h | 3 +-\n src/ipa/rkisp1/algorithms/ccm.h | 3 +-\n src/ipa/rkisp1/ipa_context.h | 2 +-\n src/ipa/rpi/controller/rpi/ccm.cpp | 65 +++++++------------\n src/ipa/rpi/controller/rpi/ccm.h | 35 +---------\n src/{ipa/libipa => libcamera}/matrix.cpp | 8 +--\n src/libcamera/meson.build | 1 +\n 10 files changed, 39 insertions(+), 97 deletions(-)\n rename {src/ipa/libipa => include/libcamera/internal}/matrix.h (91%)\n rename src/{ipa/libipa => libcamera}/matrix.cpp (97%)"}