{"id":21998,"url":"https://patchwork.libcamera.org/api/1.1/covers/21998/?format=json","web_url":"https://patchwork.libcamera.org/cover/21998/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/1.1/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20241119121928.30939-1-laurent.pinchart@ideasonboard.com>","date":"2024-11-19T12:19:11","name":"[v4,00/17] Improve linear algebra helpers in libipa","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/1.1/people/2/?format=json","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"mbox":"https://patchwork.libcamera.org/cover/21998/mbox/","series":[{"id":4804,"url":"https://patchwork.libcamera.org/api/1.1/series/4804/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=4804","date":"2024-11-19T12:19:11","name":"Improve linear algebra helpers in libipa","version":4,"mbox":"https://patchwork.libcamera.org/series/4804/mbox/"}],"comments":"https://patchwork.libcamera.org/api/covers/21998/comments/","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 52133C32F1\n\tfor ;\n\tTue, 19 Nov 2024 12:19:46 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 3175665F0F;\n\tTue, 19 Nov 2024 13:19:45 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 866AB658A2\n\tfor ;\n\tTue, 19 Nov 2024 13:19:43 +0100 (CET)","from pendragon.ideasonboard.com (81-175-209-231.bb.dnainternet.fi\n\t[81.175.209.231])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id B0C8922E\n\tfor ;\n\tTue, 19 Nov 2024 13:19:23 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"ssxZ/Oz+\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1732018763;\n\tbh=PjAz0R4d1slv9WqZ8QwEKkOMJOEMoHdXOpFHJMlTVl4=;\n\th=From:To:Subject:Date:From;\n\tb=ssxZ/Oz+Y3pVL4SnYPXmdC0qf0VN3YomenRvjguDtDP0d2QiKSu+ka2mAXCM5tAhm\n\t4dqw8RrHZCWG0/OejgCRB5aotT6RI5iHhFS3Bd54+SCKuSubvuL4udvzpvuRfBlD/b\n\tEV9ixAYyKRGtkt5xqh5l0X74OHO/XdmGarUlVFO0=","From":"Laurent Pinchart ","To":"libcamera-devel@lists.libcamera.org","Subject":"[PATCH v4 00/17] Improve linear algebra helpers in libipa","Date":"Tue, 19 Nov 2024 14:19:11 +0200","Message-ID":"<20241119121928.30939-1-laurent.pinchart@ideasonboard.com>","X-Mailer":"git-send-email 2.45.2","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"Hello,\n\nThis patch series tries to simplify IPA linear algebra calculations by\nimproving the Vector class API.\n\nPatches 01/17 to 10/17 start by improving the Vector class, and patch\n11/17 adds a unit test for the class. Patche 12/17 follows with\nmigrating the IPU3 IPA module to replace its custom RGB class with the\ngeneric version, enabling usage of the new RGB class in the libipa API\nin patch 13/17. Patches 14/17 to 16/17 are further code simpflications\nthanks to the new helpers. Finally, patch 17/17 is a drive-by extension\nof a comment to record information I discovered while working on the\nseries.\n\nFurther usage of the RGB, Vector and Matrix classes are likely possible.\nIn particular, I have limited changes to the Raspberry Pi IPA module to\nthe minimum required due to the updates in colours.h.\n\nPlease see individual patches for detailed changelogs.\n\nLaurent Pinchart (17):\n ipa: libipa: vector: Add mutable x(), y() and z() accessors\n ipa: libipa: vector: Add r(), g() and b() accessors\n ipa: libipa: vector: Add scalar constructor\n ipa: libipa: vector: Add copy constructor and assignment operator\n ipa: libipa: vector: Rename the dot product operator*() to dot()\n ipa: libipa: vector: Generalize arithmetic operators\n ipa: libipa: vector: Add missing binary arithemtic operators\n ipa: libipa: vector: Add compound assignment operators\n ipa: libipa: vector: Add element-wise min() and max() functions\n ipa: libipa: vector: Add sum() function\n test: libipa: Add Vector class test\n ipa: ipu3: awb: Replace Awb::RGB class with ipa::RGB\n ipa: libipa: colour: Use the RGB class to model RGB values\n ipa: libipa: colour: Use Vector and Matrix for linear algebra\n ipa: rkisp1: awb: Use RGB class to store colour gains\n ipa: rkisp1: awb: Use Vector and Matrix for linear algebra\n ipa: rkisp1: awb: Expand comment\n\n src/ipa/ipu3/algorithms/agc.cpp | 14 +-\n src/ipa/ipu3/algorithms/awb.cpp | 37 +--\n src/ipa/ipu3/algorithms/awb.h | 18 +-\n src/ipa/libipa/colours.cpp | 40 ++--\n src/ipa/libipa/colours.h | 6 +-\n src/ipa/libipa/vector.cpp | 264 ++++++++++++++++++---\n src/ipa/libipa/vector.h | 254 ++++++++++++++++----\n src/ipa/rkisp1/algorithms/awb.cpp | 127 +++++-----\n src/ipa/rkisp1/ipa_context.cpp | 31 +--\n src/ipa/rkisp1/ipa_context.h | 20 +-\n src/ipa/rpi/controller/rpi/agc_channel.cpp | 21 +-\n test/ipa/libipa/meson.build | 2 +\n test/ipa/libipa/vector.cpp | 100 ++++++++\n 13 files changed, 668 insertions(+), 266 deletions(-)\n create mode 100644 test/ipa/libipa/vector.cpp\n\n\nbase-commit: d5217b16020c659145f9d6dbf5849129b8500967"}