{"id":21896,"url":"https://patchwork.libcamera.org/api/1.1/covers/21896/?format=json","web_url":"https://patchwork.libcamera.org/cover/21896/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/1.1/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20241115074628.417215-1-dan.scally@ideasonboard.com>","date":"2024-11-15T07:46:22","name":"[v3,0/6] Centralise common functions in IPA modules","submitter":{"id":156,"url":"https://patchwork.libcamera.org/api/1.1/people/156/?format=json","name":"Dan Scally","email":"dan.scally@ideasonboard.com"},"mbox":"https://patchwork.libcamera.org/cover/21896/mbox/","series":[{"id":4792,"url":"https://patchwork.libcamera.org/api/1.1/series/4792/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=4792","date":"2024-11-15T07:46:22","name":"Centralise common functions in IPA modules","version":3,"mbox":"https://patchwork.libcamera.org/series/4792/mbox/"}],"comments":"https://patchwork.libcamera.org/api/covers/21896/comments/","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 1C7ACC0F1B\n\tfor ;\n\tFri, 15 Nov 2024 07:46:52 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id F1E0D6585E;\n\tFri, 15 Nov 2024 08:46:50 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id F072D618BB\n\tfor ;\n\tFri, 15 Nov 2024 08:46:47 +0100 (CET)","from mail.ideasonboard.com\n\t(cpc141996-chfd3-2-0-cust928.12-3.cable.virginm.net [86.13.91.161])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id EAA71291;\n\tFri, 15 Nov 2024 08:46:32 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"tdp7D8kY\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1731656793;\n\tbh=DcQ5qx9BpRZA+1zOFmXoV7FnuEsD47oNaMO0vUBHRRA=;\n\th=From:To:Cc:Subject:Date:From;\n\tb=tdp7D8kY6kg60v8GMfzFPtxUN24pZHw3vEB9CbBM/PTjzcHCjL0S1MrFiKUamBQzh\n\tX9TDp6a3OfMPD3RIAoXWd3RCv3GVV5CH8k5s4VMcBtaLOkwA96qLdu+TZuUEnDgkz8\n\tGFmVxSVygX22RISrMHm1mFT8zRhM9jTSvDBqLX6s=","From":"Daniel Scally ","To":"libcamera-devel@lists.libcamera.org","Cc":"mike.rudenko@gmail.com,\n\tDaniel Scally ","Subject":"[PATCH v3 0/6] Centralise common functions in IPA modules","Date":"Fri, 15 Nov 2024 07:46:22 +0000","Message-Id":"<20241115074628.417215-1-dan.scally@ideasonboard.com>","X-Mailer":"git-send-email 2.34.1","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"Hello all\n\nThis series attempts to centralise some common things that are cropping up in\nmultiple different IPAs. A helpers file is added for functions to be defined in\nthat can be used in each IPA module so that a single common implementation is\nused across the board. Additionally the common hardcoding of default sensor\ndelay values in pipeline handlers is switched to using values from the sensor's\nCameraSensorProperties class - the values there are those from the Rpi handler\nif available, or the defaults otherwise.\n\nThanks\nDan\n\nDaniel Scally (6):\n ipa: libipa: Add colour helpers\n ipa: ipu3: Use centralised libipa helpers\n ipa: rkisp1: Use centralised libipa helpers\n ipa: rpi: Use centralised libipa helpers\n libcamera: camera_sensor_properties: Add sensor control delays\n libcamera: pipelines: Draw control delays from CameraSensor properties\n\n include/libcamera/internal/camera_sensor.h | 2 +\n .../internal/camera_sensor_properties.h | 9 +++\n src/ipa/ipu3/algorithms/agc.cpp | 7 +-\n src/ipa/ipu3/algorithms/awb.cpp | 32 +-------\n src/ipa/ipu3/algorithms/awb.h | 1 -\n src/ipa/libipa/colours.cpp | 77 ++++++++++++++++++\n src/ipa/libipa/colours.h | 21 +++++\n src/ipa/libipa/meson.build | 2 +\n src/ipa/rkisp1/algorithms/awb.cpp | 18 +----\n src/ipa/rkisp1/algorithms/awb.h | 2 -\n src/ipa/rpi/controller/rpi/agc_channel.cpp | 10 ++-\n src/libcamera/pipeline/ipu3/ipu3.cpp | 12 ++-\n src/libcamera/pipeline/rkisp1/rkisp1.cpp | 13 ++-\n src/libcamera/pipeline/simple/simple.cpp | 8 +-\n src/libcamera/sensor/camera_sensor.cpp | 13 +++\n src/libcamera/sensor/camera_sensor_legacy.cpp | 33 ++++++++\n .../sensor/camera_sensor_properties.cpp | 79 +++++++++++++++++++\n 17 files changed, 267 insertions(+), 72 deletions(-)\n create mode 100644 src/ipa/libipa/colours.cpp\n create mode 100644 src/ipa/libipa/colours.h"}