{"id":21812,"url":"https://patchwork.libcamera.org/api/1.1/covers/21812/?format=json","web_url":"https://patchwork.libcamera.org/cover/21812/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/1.1/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20241105105445.1468954-1-chenghaoyang@chromium.org>","date":"2024-11-05T10:49:20","name":"[0/1] Add v4l2_subdev_format in V4L2SubdeviceFormat","submitter":{"id":117,"url":"https://patchwork.libcamera.org/api/1.1/people/117/?format=json","name":"Cheng-Hao Yang","email":"chenghaoyang@chromium.org"},"mbox":"https://patchwork.libcamera.org/cover/21812/mbox/","series":[{"id":4769,"url":"https://patchwork.libcamera.org/api/1.1/series/4769/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=4769","date":"2024-11-05T10:49:20","name":"Add v4l2_subdev_format in V4L2SubdeviceFormat","version":1,"mbox":"https://patchwork.libcamera.org/series/4769/mbox/"}],"comments":"https://patchwork.libcamera.org/api/covers/21812/comments/","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 5B99EBDB1C\n\tfor ;\n\tTue, 5 Nov 2024 10:54:53 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 8BF86653F1;\n\tTue, 5 Nov 2024 11:54:52 +0100 (CET)","from mail-oi1-x234.google.com (mail-oi1-x234.google.com\n\t[IPv6:2607:f8b0:4864:20::234])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 589A36035B\n\tfor ;\n\tTue, 5 Nov 2024 11:54:51 +0100 (CET)","by mail-oi1-x234.google.com with SMTP id\n\t5614622812f47-3e60825aa26so2742483b6e.1\n\tfor ;\n\tTue, 05 Nov 2024 02:54:51 -0800 (PST)","from chenghaoyang-low.c.googlers.com.com\n\t(27.247.221.35.bc.googleusercontent.com. [35.221.247.27])\n\tby smtp.gmail.com with ESMTPSA id\n\t41be03b00d2f7-7ee45a002d4sm8817612a12.70.2024.11.05.02.54.48\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tTue, 05 Nov 2024 02:54:49 -0800 (PST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=chromium.org header.i=@chromium.org\n\theader.b=\"ZjWXcQcO\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=chromium.org; s=google; t=1730804090; x=1731408890;\n\tdarn=lists.libcamera.org; \n\th=content-transfer-encoding:mime-version:message-id:date:subject:cc\n\t:to:from:from:to:cc:subject:date:message-id:reply-to;\n\tbh=yt/MxP9JqRZz67Jfii/ave7jD09W4W/Jo9pu9HGiVP8=;\n\tb=ZjWXcQcOfunM7U8WXGVoDaF++wuO5H4A/xjRtTbvVXzY16Gy/blbyF5GnTZbTf0usv\n\t2WVdOL9wE+ORrEoFOSfXJBJAtpfaeEOR2D+dL0XnanE7qHCIYXxknEBGjPS4LbttNKhw\n\tUbV0AkthkMbdO/C3uD5Ec6u2tV71EEJOR5gqQ=","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20230601; t=1730804090; x=1731408890;\n\th=content-transfer-encoding:mime-version:message-id:date:subject:cc\n\t:to:from:x-gm-message-state:from:to:cc:subject:date:message-id\n\t:reply-to;\n\tbh=yt/MxP9JqRZz67Jfii/ave7jD09W4W/Jo9pu9HGiVP8=;\n\tb=VXUQ5Ay3MU7RcBg9gP1XFPaOE/BHEReILhxGyjAAbN/snpIE2C/QUS3jzPZwe/xLt0\n\tERBZtXw0bsIBQuH1icyj3gEGNu6auvIxs25R2cgfSKzdgZpTvKFayIGP2ZhVkEZR/Dj7\n\tPZZopPXo/G8mNaE7kMuaQ8yCuI9dwnUDowz12xq88id5ZG1R0S6pY/1MtmV/tUbZyQqe\n\tryvsFNGvgDO1TbT4pcelvx+wqZpOIODmeZ+Qg6JRDKWuR0q+2bzovs+jtwel9w/pnAiF\n\t5Wud/oW/lEvynbIHvwSro299E6IVPn1Z7GAiqnY5Wk33qZxB/dZxtJwQMU2QVFab2Ax1\n\tcWsA==","X-Gm-Message-State":"AOJu0Yyg2W0pz/zZDRRYoss/9BCqkFADjv89oBlOaA21cgbJ4j4Qp+f8\n\t472CWQdZnfU2mj9vo+FzQeAvCtvfVayER9VeyNafvrYat4e9kSps+TBcs3ZRdf9mNpOGxUrxFk0\n\t=","X-Google-Smtp-Source":"AGHT+IGT/KMr2/Trjbxa3DID9frNTgew87jWf5m16QOCN1xoH+3wld5bAe/CcBcblxQElj67M2Yj3A==","X-Received":"by 2002:a05:6808:330a:b0:3e6:402:d228 with SMTP id\n\t5614622812f47-3e758c17adamr13317031b6e.13.1730804089778; \n\tTue, 05 Nov 2024 02:54:49 -0800 (PST)","From":"Harvey Yang ","To":"libcamera-devel@lists.libcamera.org","Cc":"Harvey Yang ","Subject":"[PATCH 0/1] Add v4l2_subdev_format in V4L2SubdeviceFormat","Date":"Tue, 5 Nov 2024 10:49:20 +0000","Message-ID":"<20241105105445.1468954-1-chenghaoyang@chromium.org>","X-Mailer":"git-send-email 2.47.0.199.ga7371fff76-goog","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"Hi folks,\n\nThis patch adds extra information in V4L2SubdeviceFormat, which will\nbe needed in mtkisp7:\nhttps://source.chromium.org/chromiumos/chromiumos/codesearch/+/main:src/third_party/libcamera/mtkisp7/src/libcamera/pipeline/mtkisp7/camsys/camsys.cpp;l=371\n\nI think we can also choose to just add the format (type:\nv4l2_mbus_framefmt) into the struct though. However, in either approach,\nwe are duplicating the information with other existing member variables.\n\nPlease check if this patch makes sense, or if there are other\napproaches.\n\nBR,\nHarvey\n\n\nHan-Lin Chen (1):\n libcamera: Add v4l2_subdev_format in V4L2SubdeviceFormat\n\n include/libcamera/internal/v4l2_subdevice.h | 2 ++\n src/libcamera/pipeline/simple/simple.cpp | 2 +-\n src/libcamera/sensor/camera_sensor.cpp | 1 +\n src/libcamera/v4l2_subdevice.cpp | 10 ++++++++++\n 4 files changed, 14 insertions(+), 1 deletion(-)"}