{"id":21716,"url":"https://patchwork.libcamera.org/api/1.1/covers/21716/?format=json","web_url":"https://patchwork.libcamera.org/cover/21716/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/1.1/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20241021133718.894374-1-mzamazal@redhat.com>","date":"2024-10-21T13:37:15","name":"[v5,0/3] Clean up pending requests on stop in software ISP","submitter":{"id":177,"url":"https://patchwork.libcamera.org/api/1.1/people/177/?format=json","name":"Milan Zamazal","email":"mzamazal@redhat.com"},"mbox":"https://patchwork.libcamera.org/cover/21716/mbox/","series":[{"id":4731,"url":"https://patchwork.libcamera.org/api/1.1/series/4731/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=4731","date":"2024-10-21T13:37:15","name":"Clean up pending requests on stop in software ISP","version":5,"mbox":"https://patchwork.libcamera.org/series/4731/mbox/"}],"comments":"https://patchwork.libcamera.org/api/covers/21716/comments/","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 743F1C32A3\n\tfor ;\n\tMon, 21 Oct 2024 13:37:37 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 633B36538B;\n\tMon, 21 Oct 2024 15:37:36 +0200 (CEST)","from us-smtp-delivery-124.mimecast.com\n\t(us-smtp-delivery-124.mimecast.com [170.10.133.124])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id DBE616538A\n\tfor ;\n\tMon, 21 Oct 2024 15:37:33 +0200 (CEST)","from mx-prod-mc-02.mail-002.prod.us-west-2.aws.redhat.com\n\t(ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63])\n\tby relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3,\n\tcipher=TLS_AES_256_GCM_SHA384) id us-mta-496-aj41HeQKN-2j-UbbwEqKMA-1;\n\tMon, 21 Oct 2024 09:37:29 -0400","from mx-prod-int-04.mail-002.prod.us-west-2.aws.redhat.com\n\t(mx-prod-int-04.mail-002.prod.us-west-2.aws.redhat.com\n\t[10.30.177.40])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\tkey-exchange X25519 server-signature RSA-PSS (2048 bits)\n\tserver-digest SHA256) (No client certificate requested)\n\tby mx-prod-mc-02.mail-002.prod.us-west-2.aws.redhat.com (Postfix)\n\twith ESMTPS id B53C91944DFD; Mon, 21 Oct 2024 13:37:24 +0000 (UTC)","from nuthatch.redhat.com (unknown [10.45.225.218])\n\tby mx-prod-int-04.mail-002.prod.us-west-2.aws.redhat.com (Postfix)\n\twith ESMTP id 6591B19560AA; Mon, 21 Oct 2024 13:37:22 +0000 (UTC)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=redhat.com header.i=@redhat.com\n\theader.b=\"QhTyjeop\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;\n\ts=mimecast20190719; t=1729517852;\n\th=from:from:reply-to:subject:subject:date:date:message-id:message-id:\n\tto:to:cc:cc:mime-version:mime-version:content-type:content-type:\n\tcontent-transfer-encoding:content-transfer-encoding;\n\tbh=UD1nB4f2Q47S+akUYNBPOQ46JTEevNFYMnmwcdv7HhA=;\n\tb=QhTyjeopPAF0WZ7qYAa0rpqgsGRI8P16Mp+anjF1tdlXt8JyzAuziK35QCuHmHGnOuAFbm\n\ti0cxYZF9SN7RgScQ36Y8AC2M+RWzcNtBLSR6VQZEayNz/C9wCSwAnyOnZND2ofF14W99LF\n\t1JIb6MCutCxwdHemQjAvNycUn3jtW1g=","X-MC-Unique":"aj41HeQKN-2j-UbbwEqKMA-1","From":"Milan Zamazal ","To":"libcamera-devel@lists.libcamera.org","Cc":"Milan Zamazal , robert.mader@posteo.de,\n\tkieran.bingham@ideasonboard.com, laurent.pinchart@ideasonboard.com","Subject":"[PATCH v5 0/3] Clean up pending requests on stop in software ISP","Date":"Mon, 21 Oct 2024 15:37:15 +0200","Message-ID":"<20241021133718.894374-1-mzamazal@redhat.com>","MIME-Version":"1.0","X-Scanned-By":"MIMEDefang 3.0 on 10.30.177.40","X-Mimecast-Spam-Score":"0","X-Mimecast-Originator":"redhat.com","Content-Transfer-Encoding":"8bit","Content-Type":"text/plain; charset=\"US-ASCII\"; x-default=true","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"Fix for the bug #234 where software ISP may not clean up some pending\nbuffers in stopDevice.\n\nChanges in v5:\n- Use a struct instead of std::pair in conversionQueue_.\n\nChanges in v4:\n- Request explicitly tracked as suggested by Laurent.\n\nChanges in v3:\n- Split to two patches according to different code areas affected.\n- Added a check for the request status to prevent canceling a request\n multiple times.\n- Calling conversionBuffers_.clear() after the cleanup, to be safer.\n\nChanges in v2:\n- The request is additionally canceled.\n- New helper method PipelineHandler::cancelRequest() introduced.\n\nMilan Zamazal (3):\n libcamera: pipeline_handler: Provide cancelRequest\n libcamera: simple: Track requests in conversionQueue_\n libcamera: software_isp: Clean up pending requests on stop\n\n include/libcamera/internal/pipeline_handler.h | 1 +\n src/libcamera/pipeline/simple/simple.cpp | 36 ++++++++++++-------\n src/libcamera/pipeline_handler.cpp | 23 ++++++++----\n 3 files changed, 40 insertions(+), 20 deletions(-)"}