{"id":21620,"url":"https://patchwork.libcamera.org/api/1.1/covers/21620/?format=json","web_url":"https://patchwork.libcamera.org/cover/21620/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/1.1/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20241014154747.2295253-1-kieran.bingham@ideasonboard.com>","date":"2024-10-14T15:47:44","name":"[0/3] ipa: rkisp1: Honor FrameDurationLimits","submitter":{"id":4,"url":"https://patchwork.libcamera.org/api/1.1/people/4/?format=json","name":"Kieran Bingham","email":"kieran.bingham@ideasonboard.com"},"mbox":"https://patchwork.libcamera.org/cover/21620/mbox/","series":[{"id":4697,"url":"https://patchwork.libcamera.org/api/1.1/series/4697/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=4697","date":"2024-10-14T15:47:44","name":"ipa: rkisp1: Honor FrameDurationLimits","version":1,"mbox":"https://patchwork.libcamera.org/series/4697/mbox/"}],"comments":"https://patchwork.libcamera.org/api/covers/21620/comments/","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id EBFB6C32F4\n\tfor ;\n\tMon, 14 Oct 2024 15:47:54 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id E295365380;\n\tMon, 14 Oct 2024 17:47:53 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 6AA4F63525\n\tfor ;\n\tMon, 14 Oct 2024 17:47:51 +0200 (CEST)","from Monstersaurus.lgs-net.com\n\t(cpc89244-aztw30-2-0-cust6594.18-1.cable.virginm.net [86.31.185.195])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 46F098BE;\n\tMon, 14 Oct 2024 17:46:10 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"t492nNF6\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1728920770;\n\tbh=rvFRESRYO9zXAj4VDtSMmzeuQdof242S5gbdBEdOkZc=;\n\th=From:To:Cc:Subject:Date:From;\n\tb=t492nNF6moYYQIiy1Fi4TQzxA5L58Uctejc+YL8v06UzCUnJjsCZEx5FYbh/0ax6a\n\tBSUzcZqxphUxG5d8qhNgz+1j5Op/wCCtfKUuCnPaNQpAM0NiMnT8+MWrnXQS4KfxOl\n\taWzofpMMzSfQkt4E0q7OjEUp/h4B9OueTuooSacM=","From":"Kieran Bingham ","To":"libcamera devel ","Cc":"Kieran Bingham ","Subject":"[PATCH 0/3] ipa: rkisp1: Honor FrameDurationLimits","Date":"Mon, 14 Oct 2024 16:47:44 +0100","Message-Id":"<20241014154747.2295253-1-kieran.bingham@ideasonboard.com>","X-Mailer":"git-send-email 2.34.1","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"The RKISP1 will presently only adhere to the 'Maximum'\nFrameDurationLimit, which describes the 'slowest' frame rate allowed.\n\nPauls' work here in \"rkisp1: Honor the FrameDurationLimits control\" adds\nsupport for ensuring that the 'Minimum' FrameDurationLimit can also be\nused to specify a limit for the 'fastest' frame rate that is acceptable.\n\nThis allows for instance setting a camera to operate only between 10FPS\nor 1FPS with a capture script such as :\n\nframes:\n - 0:\n FrameDurationLimits: [ 100000, 1000000]\n\nwhich is how I have tested this.\n\nI've taken Paul's patch from a separate branch and made some\nmodifications here to support initialising the FrameDurationLimits in\nthe AGC implementation from the ControlInfoMap when constructed or\nupdated.\n\nThis clears out a todo in the agc.cpp (\\o/) and hopefully simplifies the\nvblank calculation.\n\nAn extra patch (\"ipa: rkisp1: Alias lineDuration\") helps make this\naddition easier to parse with smaller line lengths on the repeated use\nof the Line Duration calculaion.\n\nKieran Bingham (2):\n ipa: rkisp1: Initialise AGC from FrameDurationLimits controls\n ipa: rkisp1: Alias lineDuration\n\nPaul Elder (1):\n rkisp1: Honor the FrameDurationLimits control\n\n src/ipa/rkisp1/algorithms/agc.cpp | 68 ++++++++++++++++--------\n src/ipa/rkisp1/ipa_context.cpp | 16 +++++-\n src/ipa/rkisp1/ipa_context.h | 4 ++\n src/ipa/rkisp1/rkisp1.cpp | 7 +--\n src/libcamera/pipeline/rkisp1/rkisp1.cpp | 7 +++\n 5 files changed, 77 insertions(+), 25 deletions(-)"}