{"id":21521,"url":"https://patchwork.libcamera.org/api/1.1/covers/21521/?format=json","web_url":"https://patchwork.libcamera.org/cover/21521/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/1.1/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20241004122103.89807-1-umang.jain@ideasonboard.com>","date":"2024-10-04T12:21:02","name":"[v4,0/1] rkisp1: Integrate sensorConfiguration","submitter":{"id":86,"url":"https://patchwork.libcamera.org/api/1.1/people/86/?format=json","name":"Umang Jain","email":"umang.jain@ideasonboard.com"},"mbox":"https://patchwork.libcamera.org/cover/21521/mbox/","series":[{"id":4660,"url":"https://patchwork.libcamera.org/api/1.1/series/4660/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=4660","date":"2024-10-04T12:21:02","name":"rkisp1: Integrate sensorConfiguration","version":4,"mbox":"https://patchwork.libcamera.org/series/4660/mbox/"}],"comments":"https://patchwork.libcamera.org/api/covers/21521/comments/","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id C2AD4BD80A\n\tfor ;\n\tFri, 4 Oct 2024 12:21:13 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 4408F63524;\n\tFri, 4 Oct 2024 14:21:12 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 891AF62C8F\n\tfor ;\n\tFri, 4 Oct 2024 14:21:10 +0200 (CEST)","from umang.jain (unknown\n\t[IPv6:2405:201:2015:f873:55d7:c02e:b2eb:ee3f])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 154D24C9;\n\tFri, 4 Oct 2024 14:19:34 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"XZrV3Ahk\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1728044376;\n\tbh=fWHwl5rf+0nFwo4V6xObRc/MuWqYdCccieePkISOYvg=;\n\th=From:To:Cc:Subject:Date:From;\n\tb=XZrV3Ahkq+XtMhsfv5zzVEipYGghyXeW/kSn25BhAOtq3Dpbb5epaSPjkflI7HQ7U\n\tszDnwS9gCsj+mzDHJnb187rE7EyCb8ztTtf/8Ks0mTyMnpNr95cu9XVHkNVB2a2z+G\n\tkocl1V54hlp/gShLMgvT9+Y6HOppR4CrjnXkxnH0=","From":"Umang Jain ","To":"libcamera-devel@lists.libcamera.org","Cc":"Jacopo Mondi ,\n\tKieran Bingham ,\n\tLaurent Pinchart ,\n\tPaul Elder ,\n\tStefan Klug ,\n\tUmang Jain ","Subject":"[PATCH v4 0/1] rkisp1: Integrate sensorConfiguration","Date":"Fri, 4 Oct 2024 17:51:02 +0530","Message-ID":"<20241004122103.89807-1-umang.jain@ideasonboard.com>","X-Mailer":"git-send-email 2.45.2","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"1/1 integrates sensor configuration in rkisp1.\n\nChanges in v4:\n- Fix bitDepth handling in RkISP1Path\n- Unify 2 if(sensorConfig) branches in RkISP1\n- Remove {} (nits)\n- maxResolution should be bounded first before bounding to\n aspect ratio\n- drop \"std::optional\" from bitDepth variable\n\nChanges in v3:\n- Drop isRaw() dependency\n- rework commit message to elaborate cases of sensor configuration\n failure\n\nChanges in v2:\n- Validate sensor resolution in RkISP1Path::validate() instead of RkISP1\n- Pass sensorConfiguration by reference\n- Do not adjust sensor Configuration, always return\n CameraConfiguration::Invalid if sensor configuration cannot be\n satisfied\n- Apply sensor configuration at configure() time\n\nv1:\n- https://patchwork.libcamera.org/patch/21463/\n\n- Developed over [PATCH] libcamera: rkisp1: Clamp stream configuration to ISP limit on raw path\n- Tested with cam+[1] on i.MX8MP with IMX283 attached\n\n[1]: https://patchwork.libcamera.org/patch/20080/\n\nUmang Jain (1):\n libcamera: rkisp1: Integrate SensorConfiguration support\n\n src/libcamera/pipeline/rkisp1/rkisp1.cpp | 42 ++++++++++++++---\n src/libcamera/pipeline/rkisp1/rkisp1_path.cpp | 47 +++++++++++++++++--\n src/libcamera/pipeline/rkisp1/rkisp1_path.h | 2 +\n 3 files changed, 79 insertions(+), 12 deletions(-)"}