{"id":21168,"url":"https://patchwork.libcamera.org/api/1.1/covers/21168/?format=json","web_url":"https://patchwork.libcamera.org/cover/21168/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/1.1/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20240906063444.32772-1-umang.jain@ideasonboard.com>","date":"2024-09-06T06:34:40","name":"[v7,0/4] libcamera: rkisp1: Plumb the ConverterDW100 converter","submitter":{"id":86,"url":"https://patchwork.libcamera.org/api/1.1/people/86/?format=json","name":"Umang Jain","email":"umang.jain@ideasonboard.com"},"mbox":"https://patchwork.libcamera.org/cover/21168/mbox/","series":[{"id":4565,"url":"https://patchwork.libcamera.org/api/1.1/series/4565/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=4565","date":"2024-09-06T06:34:40","name":"libcamera: rkisp1: Plumb the ConverterDW100 converter","version":7,"mbox":"https://patchwork.libcamera.org/series/4565/mbox/"}],"comments":"https://patchwork.libcamera.org/api/covers/21168/comments/","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 787CFC324C\n\tfor ;\n\tFri, 6 Sep 2024 06:34:58 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 58578634E7;\n\tFri, 6 Sep 2024 08:34:57 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 595C1618F8\n\tfor ;\n\tFri, 6 Sep 2024 08:34:55 +0200 (CEST)","from localhost.localdomain (unknown\n\t[IPv6:2405:201:2015:f873:55f8:639e:8e9f:12ec])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id B5E7845B;\n\tFri, 6 Sep 2024 08:33:40 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"UO3aAuE7\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1725604421;\n\tbh=orhQg2SBPlIbzOdigTUT5sjKBQINZ2hcrJomu8TAVPA=;\n\th=From:To:Cc:Subject:Date:From;\n\tb=UO3aAuE7N+TgIdM571rk0fJI+eNHb2PifuxG1CpNZ8wu30yV5nTolt1SqklZJCPF+\n\ttz8yYRySVZ001DQxGPFmQX3Oh5tN1xTu3g6S2i8IdJNmhSxJVHkWAuNi/zbfWuoKMZ\n\tb215XjLSZC01LoVqyIgQXhdHiJ4C+UzHQCXyPh0Q=","From":"Umang Jain ","To":"libcamera-devel@lists.libcamera.org","Cc":"Umang Jain ","Subject":"[PATCH v7 0/4] libcamera: rkisp1: Plumb the ConverterDW100\n\tconverter ","Date":"Fri, 6 Sep 2024 12:04:40 +0530","Message-ID":"<20240906063444.32772-1-umang.jain@ideasonboard.com>","X-Mailer":"git-send-email 2.45.0","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"This series intends to support i.MX8MP DW100 dewarper in rkisp1\npipeline handler. It is modelled as a V4L2M2MConverter and has a\nhelper to support scaler crop control. Extensions to the base converter\ninterface has also been done initially in the series.\n\nPatch 1/4 add ability to add features to the Converter interface.\nEach Converter can dictate its own features it can support\n\nPatch 2/4 adds crop feature enumeration and virtual functions and\ngets implemented in the V4L2 M2M converter. \n\nPatch 3/4 prepares the rkisp1 pipeline handler to register controls\nfor the camera, outside of the IPA. The dw100 converter will let us\nsupport scaler crop - which will be registered as one of the camera\ncontrols.\n\nPatch 4/4 plumbs the ConverterDW100 in the rkisp1 pipeline handler\n\nSeries is based on top of \n[PATCH v3 0/2] libcamera: Simplify error handling with ScopeExitActions class\n\nTesting:\n--------\nThe series is tested on i.MX8MP and cam utility, by setting scaler crop\ncontrol via capture script with IMX283 attached to isp0.\n\nChanges in v7:\n- Documentation improvements for input crop (1/4)\n- Crop feature now discovered dynamically at construction (2/4)\n- Handling of scaler crop control is deferred. Now scaler\n crop is applied at dewarper after buffer from ISP is ready (4/4)\n- Add explanatory comments about dw100/i.MX8MP platform (4/4)\n- Drop dw100 Converter sub-classing from v6\n- lower indentation (4/4)\n- report scaler crop value for all frames now. (4/4)\n- Use ScopeExitActions on dewarp cleanup paths (4/4)\n- copy updateControls() documentation from IPU3 (3/4)\n\nChanges in v6:\n- clarify crop expectations - set on input side\n- Rename setCrop() to setInputCrop\n- Rename getFeatures() to features()\n- Rename getCropBounds() to inputCropBounds()\n- rename Features::Crop to Features::InputCrop\n- Document crop functionality properly\n- Improve error paths\n- exportsBuffers() between RkISP1Path<>dewarper instead of\n allocateBuffers.\n\nChanges in v5:\n- Return -ENOTSUP for base implementation for virtual setCrop() in 2/5\n- Return configured size for base implemention for virtual getCropBounds\n in 2/5.\n- Fix a bug in getting crop bounds when streams are not configured\n- drop getSelection() V4L2VideoDevices additions from v4. we can get\n bounds by setSelection by setting 1x1 and UINT_MAX x UINT_MAX\n rectangles.\n\nchanges in v4:\n- rework Converter Interface to expose Features\n- Add Crop Feature interface in Converter setCrop and setCropBound\n- Implement cropping in V4L2M2MConverter for V4L2 M2M based converters\n- Introduce useDewarper_ to denote when to use dewarper (simplied code\n reading).\n- Trivial typo fixing.\n\nChanges in v3:\n- Base on top of [2]\n- Model dewarper class as converter, so can be used with Simple\n pipeline-handler/ISI\n\nChanges in v2:\n- Fix raw capture configuration, disable dewarper in that case\n\nUmang Jain (4):\n libcamera: converter: Add interface for feature flags\n libcamera: converter: Add interface to support cropping capability\n libcamera: rkisp1: Prepare for additional camera controls\n libcamera: rkisp1: Plumb the dw100 dewarper as V4L2M2M converter\n\n include/libcamera/internal/converter.h | 19 +-\n .../internal/converter/converter_v4l2_m2m.h | 13 +-\n src/libcamera/converter.cpp | 65 ++++-\n .../converter/converter_v4l2_m2m.cpp | 110 ++++++++-\n src/libcamera/pipeline/rkisp1/rkisp1.cpp | 225 +++++++++++++++++-\n 5 files changed, 416 insertions(+), 16 deletions(-)"}