{"id":21124,"url":"https://patchwork.libcamera.org/api/1.1/covers/21124/?format=json","web_url":"https://patchwork.libcamera.org/cover/21124/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/1.1/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20240830210313.30691-1-chenghaoyang@chromium.org>","date":"2024-08-30T21:00:18","name":"[v3,0/3] Add Face Detection Controls","submitter":{"id":117,"url":"https://patchwork.libcamera.org/api/1.1/people/117/?format=json","name":"Cheng-Hao Yang","email":"chenghaoyang@chromium.org"},"mbox":"https://patchwork.libcamera.org/cover/21124/mbox/","series":[{"id":4553,"url":"https://patchwork.libcamera.org/api/1.1/series/4553/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=4553","date":"2024-08-30T21:00:18","name":"Add Face Detection Controls","version":3,"mbox":"https://patchwork.libcamera.org/series/4553/mbox/"}],"comments":"https://patchwork.libcamera.org/api/covers/21124/comments/","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id B25CCC323E\n\tfor ;\n\tFri, 30 Aug 2024 21:03:19 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id DE7B7634CA;\n\tFri, 30 Aug 2024 23:03:18 +0200 (CEST)","from mail-wm1-x334.google.com (mail-wm1-x334.google.com\n\t[IPv6:2a00:1450:4864:20::334])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 9420261E4A\n\tfor ;\n\tFri, 30 Aug 2024 23:03:16 +0200 (CEST)","by mail-wm1-x334.google.com with SMTP id\n\t5b1f17b1804b1-42bb8cf8abeso15904405e9.2\n\tfor ;\n\tFri, 30 Aug 2024 14:03:16 -0700 (PDT)","from chenghaoyang-germany.c.googlers.com.com\n\t(161.126.77.34.bc.googleusercontent.com. [34.77.126.161])\n\tby smtp.gmail.com with ESMTPSA id\n\tffacd0b85a97d-3749efb37efsm4935529f8f.109.2024.08.30.14.03.14\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tFri, 30 Aug 2024 14:03:14 -0700 (PDT)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=chromium.org header.i=@chromium.org\n\theader.b=\"W5E6OBwI\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=chromium.org; s=google; t=1725051796; x=1725656596;\n\tdarn=lists.libcamera.org; \n\th=content-transfer-encoding:mime-version:message-id:date:subject:cc\n\t:to:from:from:to:cc:subject:date:message-id:reply-to;\n\tbh=vvpGPs5qyoHP4Gevd/Ug/drJLe5/JESG1wBP7hFbINU=;\n\tb=W5E6OBwIwwDC4d12Wjk6mOno1+ICH3W0QihGyUxwQeS6FDGCtLl9r5rFjvS5g/ljfp\n\tBeYLZpNhnZy2fUmeUY+vsHcaLowRa2+vjhpvtD79q/0AlAntrCidk6/J9FkBDyIPkunm\n\tp9aO39OwZDUS6ltwN+OItMDKTh9OsAS2rZnrI=","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20230601; t=1725051796; x=1725656596;\n\th=content-transfer-encoding:mime-version:message-id:date:subject:cc\n\t:to:from:x-gm-message-state:from:to:cc:subject:date:message-id\n\t:reply-to;\n\tbh=vvpGPs5qyoHP4Gevd/Ug/drJLe5/JESG1wBP7hFbINU=;\n\tb=wCi2S7RuoVWXNQmYys05mrdp+ckwhXLUsco61AV0Z14z9VtMqKeWJJ3Doj4TKGHweB\n\tMm+L9qwpj94xy6dbtIzgoeqI6iE9PMHj3FhXJrn9JU5Kq6dd+tBpO3s9gKuCPLSnuG0I\n\t7+cfUQ/aFGETJrMr2HNrG6qy/pWJYwfWg4M+XVtJf/fV/R0GQRYqUow+4nlxlUGQkucC\n\tvpdds+EnEGEBhQR12QrY9EEPbEWRS77MZ4e11b5nmjpa+SA0YPe5TV6tEdW1dGBOM4TN\n\ts/pK4O8s+QWS8/SqT3Gp0hQFH7lcNhZfrHiaM3L1kClTK+ZUBKv5t+bCrCAbJy6hHdV5\n\t5k6Q==","X-Gm-Message-State":"AOJu0YzAlflWsRLlGeusS7sSGOMSzw2DuYDzMB0/tq8kgY5q08VnqKyP\n\tWlbYE+TDUtsxvvWw5QqbP0MN4YXykDCCeDN32gAcCvsHBmcCZQdexz9tN4gyBRj0DVNwJhO5IHy\n\tQVg==","X-Google-Smtp-Source":"AGHT+IFLaS7UJznS4Or/o6CBp8gEAeDK2gvUuT6YxIvGr4hzFJAcCV1cavJz0yLYTA10mWyfRTg1sw==","X-Received":"by 2002:a05:600c:354b:b0:42b:afa7:804e with SMTP id\n\t5b1f17b1804b1-42bb01ae418mr56768085e9.3.1725051795405; \n\tFri, 30 Aug 2024 14:03:15 -0700 (PDT)","From":"Harvey Yang ","To":"libcamera-devel@lists.libcamera.org","Cc":"Harvey Yang ","Subject":"[PATCH v3 0/3] Add Face Detection Controls","Date":"Fri, 30 Aug 2024 21:00:18 +0000","Message-ID":"<20240830210313.30691-1-chenghaoyang@chromium.org>","X-Mailer":"git-send-email 2.46.0.469.g59c65b2a67-goog","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"Hi folks,\n\nThis series of patches adds face detection controls in the control ids,\nthe corresponding usages, and a c'tor of libcamera::Rectangle to\nconstruct it easiler with face detection results.\n\nIt passed gitlab pipeline checks:\nhttps://gitlab.freedesktop.org/chenghaoyang/libcamera/-/pipelines/1261374\n\nThis is one of the series cherry-picked from cros mtkisp7 branch.\n\nThe corresponding CLs in cros are:\nhttps://chromium-review.googlesource.com/c/chromiumos/third_party/libcamera/+/4741266\nhttps://chromium-review.googlesource.com/c/chromiumos/third_party/libcamera/+/4741267\nhttps://chromium-review.googlesource.com/c/chromiumos/third_party/libcamera/+/5669229\nhttps://chromium-review.googlesource.com/c/chromiumos/third_party/libcamera/+/5669232\n\nThe usages in pipeline handler mtkisp7 will be added later.\n\nThe checkstyle's suggestion on the second patch is ignored, as it\nchanges the style of previous code.\n\nv3: Applied fixes according to Jacopo's comments.\n- Moved the new face detection controls from core to draft.\n- Amended new controls' descriptions.\n\nv2:\n- Squashed the fourth CL into the last patch, as it's a fix.\n- Fixed CLs based on checkstyle's suggestions.\n\nHarvey Yang (1):\n libcamera: android: Add face detection control support\n\nYudhistira Erlandinata (2):\n libcamera: Add rectangle two-point constructor\n libcamera: Add face detection controls\n\n include/libcamera/controls.h | 6 +++\n include/libcamera/geometry.h | 2 +\n src/android/camera_capabilities.cpp | 45 ++++++++++++++++++--\n src/android/camera_device.cpp | 61 ++++++++++++++++++++++++++-\n src/libcamera/control_ids_draft.yaml | 63 ++++++++++++++++++++++++++++\n src/libcamera/controls.cpp | 6 +++\n src/libcamera/geometry.cpp | 14 +++++++\n 7 files changed, 191 insertions(+), 6 deletions(-)"}