{"id":20893,"url":"https://patchwork.libcamera.org/api/1.1/covers/20893/?format=json","web_url":"https://patchwork.libcamera.org/cover/20893/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/1.1/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20240813084451.44099-1-stefan.klug@ideasonboard.com>","date":"2024-08-13T08:44:17","name":"[v4,0/6] rkisp1: Add manual colour temperature control","submitter":{"id":184,"url":"https://patchwork.libcamera.org/api/1.1/people/184/?format=json","name":"Stefan Klug","email":"stefan.klug@ideasonboard.com"},"mbox":"https://patchwork.libcamera.org/cover/20893/mbox/","series":[{"id":4514,"url":"https://patchwork.libcamera.org/api/1.1/series/4514/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=4514","date":"2024-08-13T08:44:17","name":"rkisp1: Add manual colour temperature control","version":4,"mbox":"https://patchwork.libcamera.org/series/4514/mbox/"}],"comments":"https://patchwork.libcamera.org/api/covers/20893/comments/","headers":{"Return-Path":"<libcamera-devel-bounces@lists.libcamera.org>","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 2573EC323E\n\tfor <parsemail@patchwork.libcamera.org>;\n\tTue, 13 Aug 2024 08:45:06 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id E3DA9633B5;\n\tTue, 13 Aug 2024 10:45:04 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 80B556337E\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tTue, 13 Aug 2024 10:45:03 +0200 (CEST)","from ideasonboard.com (unknown\n\t[IPv6:2a00:6020:448c:6c00:7025:8d00:1ffd:751a])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 52B06827;\n\tTue, 13 Aug 2024 10:44:06 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"sEmg1eer\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1723538646;\n\tbh=5uAHcx72BklYBy4x9kEu/Urv9StUk3Y6/tIeGFqubqI=;\n\th=From:To:Cc:Subject:Date:From;\n\tb=sEmg1eerQrNaMDd+hLtNe+ME7Iw3YPvGwbiSvnYuV0xpxYVi+9e7f8GtO3TGpv0I+\n\tYo8gFCZuTMBDGZ5F/0BldMWh+/n/zvBNfB25HBPVDWpqd1bpAvjeuP0wLb3O+fsWKf\n\tghh8fdGwJTAkLQEezs3MYZ/EmlcmM9apHnXE9zjg=","From":"Stefan Klug <stefan.klug@ideasonboard.com>","To":"libcamera-devel@lists.libcamera.org","Cc":"Stefan Klug <stefan.klug@ideasonboard.com>","Subject":"[PATCH v4 0/6] rkisp1: Add manual colour temperature control","Date":"Tue, 13 Aug 2024 10:44:17 +0200","Message-ID":"<20240813084451.44099-1-stefan.klug@ideasonboard.com>","X-Mailer":"git-send-email 2.43.0","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"<libcamera-devel.lists.libcamera.org>","List-Unsubscribe":"<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>","List-Archive":"<https://lists.libcamera.org/pipermail/libcamera-devel/>","List-Post":"<mailto:libcamera-devel@lists.libcamera.org>","List-Help":"<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>","List-Subscribe":"<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>"},"content":"This series adds the ability to manually set the colour temperature\ncontrol. It is a partial resurrection of the \"libcamera: controls:\nUpdate the ColourTemperature control to be writable\" series by David\nPlowman [1], but with a implementation for the rkisp1 instead of the\nrpi.\n\nPatch 1 updates the control id documentation. Patches 2-3 implement the\ncontrol for the rkisp1. Patches 4-6 update the tuning scripts\naccordingly. \n\nIt depends on the \"Two small tuning script cleanups\" series [2].  Please\nsee the individual commit messages for more details.\n\nChanges v1 -> v4:\n- Incremented series version to v4, because technically it is a superset of [1]\n- Fixed compile issue on patch 2\n- Fixed typos and wording in patch 1\n- Collected tags\n\nBest regards,\nStefan\n\n[1] https://patchwork.libcamera.org/project/libcamera/list/?series=4083 \n[2] https://patchwork.libcamera.org/project/libcamera/list/?series=4484\n\nStefan Klug (6):\n  libcamera: controls: Update the ColourTemperature control to be\n    writable\n  ipa: rkisp1: awb: Load white balance gains from tuning file\n  ipa: rkisp1: awb: Implement ColourTemperature control\n  libtuning: Modify ctt_awb.awb() so that it can run in our context\n  libtuning: Add initial AWB module\n  utils: tuning: rkisp1: Replace static AWB with new AWB module\n\n src/ipa/rkisp1/algorithms/awb.cpp             | 38 +++++++++++++\n src/ipa/rkisp1/algorithms/awb.h               |  6 ++\n src/libcamera/control_ids_core.yaml           | 24 ++++++--\n utils/tuning/libtuning/ctt_awb.py             | 55 ++++++++++---------\n .../tuning/libtuning/modules/awb/__init__.py  |  6 ++\n utils/tuning/libtuning/modules/awb/awb.py     | 42 ++++++++++++++\n utils/tuning/libtuning/modules/awb/rkisp1.py  | 27 +++++++++\n utils/tuning/rkisp1.py                        |  4 +-\n 8 files changed, 170 insertions(+), 32 deletions(-)\n create mode 100644 utils/tuning/libtuning/modules/awb/__init__.py\n create mode 100644 utils/tuning/libtuning/modules/awb/awb.py\n create mode 100644 utils/tuning/libtuning/modules/awb/rkisp1.py"}