{"id":20709,"url":"https://patchwork.libcamera.org/api/1.1/covers/20709/?format=json","web_url":"https://patchwork.libcamera.org/cover/20709/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/1.1/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20240726114715.226468-1-umang.jain@ideasonboard.com>","date":"2024-07-26T11:47:10","name":"[v6,0/5] libcamera: rkisp1: Plumb the ConverterDW100 converter","submitter":{"id":86,"url":"https://patchwork.libcamera.org/api/1.1/people/86/?format=json","name":"Umang Jain","email":"umang.jain@ideasonboard.com"},"mbox":"https://patchwork.libcamera.org/cover/20709/mbox/","series":[{"id":4462,"url":"https://patchwork.libcamera.org/api/1.1/series/4462/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=4462","date":"2024-07-26T11:47:10","name":"libcamera: rkisp1: Plumb the ConverterDW100 converter","version":6,"mbox":"https://patchwork.libcamera.org/series/4462/mbox/"}],"comments":"https://patchwork.libcamera.org/api/covers/20709/comments/","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 003A3BDC71\n\tfor ;\n\tFri, 26 Jul 2024 11:47:28 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 3391363370;\n\tFri, 26 Jul 2024 13:47:28 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 903CD6199C\n\tfor ;\n\tFri, 26 Jul 2024 13:47:26 +0200 (CEST)","from localhost.localdomain (unknown\n\t[IPv6:2405:201:2015:f873:55f8:639e:8e9f:12ec])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 7758D83F;\n\tFri, 26 Jul 2024 13:46:41 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"Cd+v2ZlI\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1721994402;\n\tbh=A0am7O0PQofge6RBJR4mCWKQGyYuLMgIiSK8Z5GCR6o=;\n\th=From:To:Cc:Subject:Date:From;\n\tb=Cd+v2ZlIpKet31yh1VPCtehhccX62bGtLGpY30pIcdTHEgpk+tJ1oUrebhKQ6TgWE\n\tM9WNUwZlkn4/ZzWOsPsWBP8V00qU/2eD6ShI5mSyTlWrnx7Cv5L534kShW0CTf7u/S\n\tAEn/Udy6D9HGlFOSkINR04cgJDy/p7dHWLcsPtwA=","From":"Umang Jain ","To":"libcamera-devel@lists.libcamera.org","Cc":"Umang Jain ","Subject":"[PATCH v6 0/5] libcamera: rkisp1: Plumb the ConverterDW100 converter","Date":"Fri, 26 Jul 2024 17:17:10 +0530","Message-ID":"<20240726114715.226468-1-umang.jain@ideasonboard.com>","X-Mailer":"git-send-email 2.45.0","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"This series intends to support i.MX8MP DW100 dewarper in rkisp1 pipeline\nhandler. It is modelled as Converter (inherited from V4L2M2MConverter)\nand has a helper to support scaler crop control. The converter acts\nas a base for now, additional development around dewarping capabilites\nand support in simple pipeline-handler [1] can be added on top as\nfocused tasks.\n\nPatch 1/5 add ability to add features to the Converter interface.\nEach Converter can dictate its own features it can support\n\nPatch 2/5 adds crop feature and gets implemented in the V4L2 M2M\nconverter. \n\nPatch 3/5 prepares the rkisp1 pipeline handler to register controls\nfor the camera, outside of the IPA. The ConverterDW100 will let us support\nscaler crop - which will be registered as one of the camera controls.\n\nPatch 4/5 adds a ConverterDW100 class inheriting from\nconverter_v4l2_m2m. This is just a base class for ConverterDW100\nwith Feature::Crop. Actual dewarp support will extend this class\nin future.\n\nPatch 5/5 plumbs the ConverterDW100 in the rkisp1 pipeline handler\n\nTesting:\n--------\nThe series is tested on i.MX8MP and cam utility, by setting scaler crop\ncontrol via capture script with IMX283 attached to isp0.\n\nChanges in v6:\n- clarify crop expectations - set on input side\n- Rename setCrop() to setInputCrop\n- Rename getFeatures() to features()\n- Rename getCropBounds() to inputCropBounds()\n- rename Features::Crop to Features::InputCrop\n- Document crop functionality properly\n- Improve error paths\n- exportsBuffers() between RkISP1Path<>dewarper instead of\n allocateBuffers.\n\nChanges in v5:\n- Return -ENOTSUP for base implementation for virtual setCrop() in 2/5\n- Return configured size for base implemention for virtual getCropBounds\n in 2/5.\n- Fix a bug in getting crop bounds when streams are not configured\n- drop getSelection() V4L2VideoDevices additions from v4. we can get\n bounds by setSelection by setting 1x1 and UINT_MAX x UINT_MAX\n rectangles.\n\nchanges in v4:\n- rework Converter Interface to expose Features\n- Add Crop Feature interface in Converter setCrop and setCropBound\n- Implement cropping in V4L2M2MConverter for V4L2 M2M based converters\n- Introduce useDewarper_ to denote when to use dewarper (simplied code\n reading).\n- Trivial typo fixing.\n\nChanges in v3:\n- Base on top of [2]\n- Model dewarper class as converter, so can be used with Simple\n pipeline-handler/ISI\n\nChanges in v2:\n- Fix raw capture configuration, disable dewarper in that case\n\n[1]: Supporting the ConverterDW100 is simple pipeline handler should be\neasy, adding the compatibles string and registering the converter with\nREGISTER_CONVERTER(). However, for testing the\ni.MX8MP -> ISI -> ConverterDW100 (dewarper) requires me to have a YUV\nsensor attached, which I have not abled to source it yet. Once I source\nit, I will test the ConverterDW100 on simple pipeline handler (I don't\nexpect any issues there but still..) and prepare a integration patch.\nI hope this doesn't act as blocker for the series.\n\n\nUmang Jain (5):\n libcamera: converter: Add interface for feature flags\n libcamera: converter: Add interface to support cropping capability\n libcamera: rkisp1: Prepare for additional camera controls\n libcamera: converter: Add DW100 converter class\n libcamera: rkisp1: Plumb the ConverterDW100 converter\n\n include/libcamera/internal/converter.h | 18 +-\n .../internal/converter/converter_dw100.h | 24 +++\n .../internal/converter/converter_v4l2_m2m.h | 8 +-\n .../libcamera/internal/converter/meson.build | 1 +\n src/libcamera/converter.cpp | 74 ++++++-\n src/libcamera/converter/converter_dw100.cpp | 37 ++++\n .../converter/converter_v4l2_m2m.cpp | 97 +++++++++-\n src/libcamera/converter/meson.build | 1 +\n src/libcamera/pipeline/rkisp1/rkisp1.cpp | 182 +++++++++++++++++-\n 9 files changed, 430 insertions(+), 12 deletions(-)\n create mode 100644 include/libcamera/internal/converter/converter_dw100.h\n create mode 100644 src/libcamera/converter/converter_dw100.cpp"}