{"id":20436,"url":"https://patchwork.libcamera.org/api/1.1/covers/20436/?format=json","web_url":"https://patchwork.libcamera.org/cover/20436/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/1.1/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20240627145156.1094127-1-mzamazal@redhat.com>","date":"2024-06-27T14:51:37","name":"[v3,00/14] Add global configuration file","submitter":{"id":177,"url":"https://patchwork.libcamera.org/api/1.1/people/177/?format=json","name":"Milan Zamazal","email":"mzamazal@redhat.com"},"mbox":"https://patchwork.libcamera.org/cover/20436/mbox/","series":[{"id":4426,"url":"https://patchwork.libcamera.org/api/1.1/series/4426/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=4426","date":"2024-06-27T14:51:37","name":"Add global configuration file","version":3,"mbox":"https://patchwork.libcamera.org/series/4426/mbox/"}],"comments":"https://patchwork.libcamera.org/api/covers/20436/comments/","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 8B857BD87C\n\tfor ;\n\tThu, 27 Jun 2024 14:52:32 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id E228A62C9A;\n\tThu, 27 Jun 2024 16:52:31 +0200 (CEST)","from us-smtp-delivery-124.mimecast.com\n\t(us-smtp-delivery-124.mimecast.com [170.10.133.124])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 91A84619E8\n\tfor ;\n\tThu, 27 Jun 2024 16:52:30 +0200 (CEST)","from mx-prod-mc-02.mail-002.prod.us-west-2.aws.redhat.com\n\t(ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63])\n\tby relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3,\n\tcipher=TLS_AES_256_GCM_SHA384) id us-mta-622-T5RTVPUEMQu4XA4ZJpObtQ-1;\n\tThu, 27 Jun 2024 10:52:25 -0400","from mx-prod-int-02.mail-002.prod.us-west-2.aws.redhat.com\n\t(mx-prod-int-02.mail-002.prod.us-west-2.aws.redhat.com\n\t[10.30.177.15])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\tkey-exchange X25519 server-signature RSA-PSS (2048 bits)\n\tserver-digest SHA256) (No client certificate requested)\n\tby mx-prod-mc-02.mail-002.prod.us-west-2.aws.redhat.com (Postfix)\n\twith ESMTPS id 1D5E4194511E; Thu, 27 Jun 2024 14:52:24 +0000 (UTC)","from nuthatch.redhat.com (unknown [10.45.225.47])\n\tby mx-prod-int-02.mail-002.prod.us-west-2.aws.redhat.com (Postfix)\n\twith ESMTP id 896631955BE0; Thu, 27 Jun 2024 14:52:22 +0000 (UTC)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=redhat.com header.i=@redhat.com\n\theader.b=\"ObIftIuE\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;\n\ts=mimecast20190719; t=1719499949;\n\th=from:from:reply-to:subject:subject:date:date:message-id:message-id:\n\tto:to:cc:cc:mime-version:mime-version:content-type:content-type:\n\tcontent-transfer-encoding:content-transfer-encoding;\n\tbh=TRxViZG7PyExzbP7b7FEAwHZllnPG7a9nJ3uMQza33E=;\n\tb=ObIftIuEvWdrcQZFkS5UT/Hd2xTqRFHZ3462dFq7iFlHrj8TEYfUZXmczydh8MVQr1Ps9Z\n\tuSAdi+asi4ORwDONLhHPvNUGDNhHevRPyfYkDlFlYe3Ds6AdACc5Opvn/AOXBeyCWlS3tT\n\t9C5OaUH/T+4PJ2TiOnL+PiG/Ffu5erc=","X-MC-Unique":"T5RTVPUEMQu4XA4ZJpObtQ-1","From":"Milan Zamazal ","To":"libcamera-devel@lists.libcamera.org","Cc":"Milan Zamazal ,\n\tKieran Bingham ","Subject":"[PATCH v3 00/14] Add global configuration file","Date":"Thu, 27 Jun 2024 16:51:37 +0200","Message-ID":"<20240627145156.1094127-1-mzamazal@redhat.com>","MIME-Version":"1.0","X-Scanned-By":"MIMEDefang 3.0 on 10.30.177.15","X-Mimecast-Spam-Score":"0","X-Mimecast-Originator":"redhat.com","Content-Type":"text/plain; charset=UTF-8","Content-Transfer-Encoding":"8bit","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"This patch series introduces global configuration file for libcamera, to\nprovide runtime configuration means other than environment variables.\nInstead of, or in addition to, the growing list of configuration\nenvironment variables, the whole configuration can be specified in a\nsingle configuration file. This is both simpler and more flexible.\n\nThis is not a replacement for specific configuration files already\npresent in libcamera.\n\nThe patches implement what is needed to introduce a configuration file\nthat can handle the current environment variables and software ISP\nTODOs. They demonstrate how to deal with the key points that must be\nconsidered. See commit messages for more details.\n\nThe configuration file is a YAML file. It is looked up in user’s home\ndirectory or, if not present, in system-wide libcamera directories.\nEnvironment variables, if set, still take precedence.\n\nThis patch series is not exhaustive, there can be future enhancements,\nmost notably configuration file validation to avoid confusions caused by\ntypos etc.\n\nNot everything has been tested because some of the patches are related\nto specific hardware.\n\nChanges in v3:\n- Added a configuration item for the newly introduced\n LIBCAMERA_PIPELINES_MATCH_LIST variable.\n- A minor indentation fix.\n- Fixed `pipelines.' x `pipeline.' configuration item naming mismatch.\n- Tuning files are looked up now by particular cameras attached rather than\n being specified for the whole pipeline.\n- Helpers use std::string& instead of char* for confPath arguments.\n- Protection against returning YamlObject::empty as a regular value (the\n problem has been probably exposed by addition of\n LIBCAMERA_PIPELINES_MATCH_LIST).\n\nChanges in v2:\n- Rebased on master.\n- Various cleanups, documentation improvements and minor fixes.\n- Configuration option for LIBCAMERA_RPI_TUNING_FILE added (Naush).\n- Two more patches for software ISP configuration added.\n\nMilan Zamazal (14):\n config: Introduce global runtime configuration\n config: Move global configuration to base\n config: Look up logging levels in the configuration file\n rconfig: Add configuration retrieval helpers\n config: Look up log file in configuration file\n config: Look up log color configuration in configuration file\n config: Look up rpi paths in configuration file\n config: Look up IPA configurables in configuration file\n config: Look up RkISP1 tuning file in configuration file\n config: Look up pipelines match list in configuration file\n config: Allow enabling software ISP in runtime\n config: Add global configuration file documentation\n libcamera: software_isp: Make input buffer copying configurable\n libcamera: software_isp: Make measurement configurable\n\n Documentation/index.rst | 2 +-\n Documentation/meson.build | 2 +-\n ...ariables.rst => runtime_configuration.rst} | 116 +++++++++-\n .../libcamera/internal/global_configuration.h | 67 ++++++\n include/libcamera/internal/meson.build | 1 +\n src/libcamera/base/global_configuration.cpp | 219 ++++++++++++++++++\n src/libcamera/base/log.cpp | 24 +-\n src/libcamera/base/meson.build | 15 ++\n src/libcamera/{ => base}/yaml_parser.cpp | 0\n src/libcamera/camera_manager.cpp | 18 +-\n src/libcamera/ipa_manager.cpp | 23 +-\n src/libcamera/ipa_proxy.cpp | 8 +-\n src/libcamera/meson.build | 14 --\n src/libcamera/pipeline/rkisp1/rkisp1.cpp | 11 +-\n .../pipeline/rpi/common/pipeline_base.cpp | 18 +-\n src/libcamera/pipeline/simple/simple.cpp | 12 +\n src/libcamera/process.cpp | 11 +-\n src/libcamera/software_isp/TODO | 36 ---\n src/libcamera/software_isp/debayer_cpu.cpp | 30 ++-\n src/libcamera/software_isp/debayer_cpu.h | 7 +-\n 20 files changed, 531 insertions(+), 103 deletions(-)\n rename Documentation/{environment_variables.rst => runtime_configuration.rst} (61%)\n create mode 100644 include/libcamera/internal/global_configuration.h\n create mode 100644 src/libcamera/base/global_configuration.cpp\n rename src/libcamera/{ => base}/yaml_parser.cpp (100%)"}