{"id":20430,"url":"https://patchwork.libcamera.org/api/1.1/covers/20430/?format=json","web_url":"https://patchwork.libcamera.org/cover/20430/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/1.1/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20240627134656.582462-1-umang.jain@ideasonboard.com>","date":"2024-06-27T13:46:51","name":"[v4,0/5] libcamera: rkisp1: Plumb the ConverterDW100 converter","submitter":{"id":86,"url":"https://patchwork.libcamera.org/api/1.1/people/86/?format=json","name":"Umang Jain","email":"umang.jain@ideasonboard.com"},"mbox":"https://patchwork.libcamera.org/cover/20430/mbox/","series":[{"id":4425,"url":"https://patchwork.libcamera.org/api/1.1/series/4425/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=4425","date":"2024-06-27T13:46:51","name":"libcamera: rkisp1: Plumb the ConverterDW100 converter","version":4,"mbox":"https://patchwork.libcamera.org/series/4425/mbox/"}],"comments":"https://patchwork.libcamera.org/api/covers/20430/comments/","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id A138ABDB1D\n\tfor ;\n\tThu, 27 Jun 2024 13:47:05 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 9DCD362CA0;\n\tThu, 27 Jun 2024 15:47:04 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 108B362C95\n\tfor ;\n\tThu, 27 Jun 2024 15:47:03 +0200 (CEST)","from fedora.local (unknown\n\t[IPv6:2405:201:2015:f873:c173:4b:4a04:3a21])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 484A0593;\n\tThu, 27 Jun 2024 15:46:38 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"DlYT+JMU\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1719495999;\n\tbh=/eHqrrypFunt1gXUa2bq5yKnlbLvtUdGyRjVm0T4VIg=;\n\th=From:To:Cc:Subject:Date:From;\n\tb=DlYT+JMUttuPdkWVOPVtpAb2MhbPs6kStVVtxDJ9iI1WeFgmb+jdSGS1HYDf1G245\n\tnXoT3XtZRh2R8PQdmkvm5PwG/wROiTWbmrMDSX107iEHChMww4IPI4guJIExoN44Yc\n\txB1oKYaU/Rq9L84pddF47xVKy6MB5A+PGq30Hc2U=","From":"Umang Jain ","To":"libcamera-devel@lists.libcamera.org","Cc":"Umang Jain ","Subject":"[PATCH v4 0/5] libcamera: rkisp1: Plumb the ConverterDW100 converter","Date":"Thu, 27 Jun 2024 19:16:51 +0530","Message-ID":"<20240627134656.582462-1-umang.jain@ideasonboard.com>","X-Mailer":"git-send-email 2.44.0","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"This series intends to support i.MX8MP DW100 dewarper in rkisp1 pipeline\nhandler. It is modelled as Converter (inherited from V4L2M2MConverter)\nand has a helper to support scaler crop control. The converter acts\nas a base for now, additional development around dewarping capabilites\nand support in simple pipeline-handler [1] can be added on top as\nfocused tasks.\n\nPatch 1/5 add ability to add features to the Converter interface.\nEach Converter can dictate its own features it can support\n\nPatch 2/5 adds crop feature and gets implemented in the V4L2 M2M\nconverter. \n\nPatch 3/5 prepares the rkisp1 pipeline handler to register controls\nfor the camera, outside of the IPA. The ConverterDW100 will let us support\nscaler crop - which will be registered as one of the camera controls.\n\nPatch 4/5 adds a ConverterDW100 class inheriting from\nconverter_v4l2_m2m. This provides a scaler crop setting helper.\nA \\todo is added here to handle the case when rectangles get modified\nwhile applying. This requires a bit of dicussion I think.\n\nPatch 5/5 plumbs the ConverterDW100 in the rkisp1 pipeline handler\n\nThis series is based on top of [2]\n\nTesting:\n--------\nThe series is tested on i.MX8MP and cam utility, by setting scaler crop\ncontrol via capture script with IMX283 attached to isp0.\n\nchanges in v4:\n- rework Converter Interface to expose Features\n- Add Crop Feature interface in Converter setCrop and setCropBound\n- Implement cropping in V4L2M2MConverter for V4L2 M2M based converters\n- Introduce useDewarper_ to denote when to use dewarper (simplied code\n reading).\n- Trivial typo fixing.\n\nChanges in v3:\n- Base on top of [2]\n- Model dewarper class as converter, so can be used with Simple\n pipeline-handler/ISI\n\nChanges in v2:\n- Fix raw capture configuration, disable dewarper in that case\n\n[1]: Supporting the ConverterDW100 is simple pipeline handler should be\neasy, adding the compatibles string and registering the converter with\nREGISTER_CONVERTER(). However, for testing the\ni.MX8MP -> ISI -> ConverterDW100 (dewarper) requires me to have a YUV\nsensor attached, which I have not abled to source it yet. Once I source\nit, I will test the ConverterDW100 on simple pipeline handler (I don't\nexpect any issues there but still..) and prepare a integration patch.\nI hope this doesn't act as blocker for the series.\n\n[2] [PATCH v4 0/4] libcamera: converter: Replace usage of stream index by Stream pointer\n\nUmang Jain (5):\n libcamera: converter: Add interface for feature flags\n libcamera: converter: Add interface to support cropping capability\n libcamera: rkisp1: Prepare for additional camera controls\n libcamera: converter: Add DW100 converter class\n libcamera: rkisp1: Plumb the ConverterDW100 converter\n\n include/libcamera/internal/converter.h | 18 +-\n .../internal/converter/converter_dw100.h | 26 +++\n .../internal/converter/converter_v4l2_m2m.h | 9 +-\n .../libcamera/internal/converter/meson.build | 1 +\n include/libcamera/internal/v4l2_videodevice.h | 1 +\n src/libcamera/converter.cpp | 57 +++++-\n src/libcamera/converter/converter_dw100.cpp | 64 +++++++\n .../converter/converter_v4l2_m2m.cpp | 90 ++++++++-\n src/libcamera/converter/meson.build | 1 +\n src/libcamera/pipeline/rkisp1/rkisp1.cpp | 172 +++++++++++++++++-\n src/libcamera/pipeline/rkisp1/rkisp1_path.cpp | 12 +-\n src/libcamera/pipeline/rkisp1/rkisp1_path.h | 14 ++\n src/libcamera/v4l2_videodevice.cpp | 32 ++++\n 13 files changed, 480 insertions(+), 17 deletions(-)\n create mode 100644 include/libcamera/internal/converter/converter_dw100.h\n create mode 100644 src/libcamera/converter/converter_dw100.cpp"}