{"id":20341,"url":"https://patchwork.libcamera.org/api/1.1/covers/20341/?format=json","web_url":"https://patchwork.libcamera.org/cover/20341/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/1.1/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20240616174541.10708-1-laurent.pinchart@ideasonboard.com>","date":"2024-06-16T17:45:37","name":"[v10,0/4] ipa: rkisp1: Add crosstalk algorithm","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/1.1/people/2/?format=json","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"mbox":"https://patchwork.libcamera.org/cover/20341/mbox/","series":[{"id":4401,"url":"https://patchwork.libcamera.org/api/1.1/series/4401/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=4401","date":"2024-06-16T17:45:37","name":"ipa: rkisp1: Add crosstalk algorithm","version":10,"mbox":"https://patchwork.libcamera.org/series/4401/mbox/"}],"comments":"https://patchwork.libcamera.org/api/covers/20341/comments/","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id B382BC3237\n\tfor ;\n\tSun, 16 Jun 2024 17:46:04 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id C32126548D;\n\tSun, 16 Jun 2024 19:46:03 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 2928465456\n\tfor ;\n\tSun, 16 Jun 2024 19:46:03 +0200 (CEST)","from pendragon.ideasonboard.com (81-175-209-231.bb.dnainternet.fi\n\t[81.175.209.231])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 88DDE2D5\n\tfor ;\n\tSun, 16 Jun 2024 19:45:46 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"QFzdj87K\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1718559946;\n\tbh=neRR1Kev7pSICTJM/l0VMmD2MYfn8PjXvgWG3BlDdmM=;\n\th=From:To:Subject:Date:From;\n\tb=QFzdj87KCvznPNbK4bI9G5m5E+VbVS8ZEZanc1mdkKXyWWGNXJCNIlqhG/xJY4Ls5\n\tAqWxNKhAeeLOFz0PClnB+VkejGm0dCYmBmm2J5ShW8THZyZjyMJv76o9B7vK/a4TXg\n\tFAcPiXgJVHahaCxcdZjwzZLUgepeM9wAAOGqzO88=","From":"Laurent Pinchart ","To":"libcamera-devel@lists.libcamera.org","Subject":"[PATCH v10 0/4] ipa: rkisp1: Add crosstalk algorithm","Date":"Sun, 16 Jun 2024 20:45:37 +0300","Message-ID":"<20240616174541.10708-1-laurent.pinchart@ideasonboard.com>","X-Mailer":"git-send-email 2.44.2","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"Hello,\n\nI'm posting a new version of Paul's \"[PATCH v9 0/3] ipa: rkisp1: Add\ncrosstalk algorithm\" and \"[PATCH v3] ipa: libipa: vector: Add\nmatrix-vector multiplication\" patches with small review comments\naddressed, to speed up merging.\n\nThis patch series adds the crosstalk / color correction algorithm to\nthe rkisp1 IPA.\n\nInterpolating matrices is likely to be a common functionaily, as lens\nshading correction also does it, and other IPAs will will want to do\nboth color correction and lens shading correction. Because of this, the\ncrosstalk is implemented using a generic matrix interpolator, which is\nadded to libipa, in addition to a Matrix class.\n\nv3 mainly adds ccm offsets, and some fixes some initialization and\nasserts.\n\nv4 cleans up / optimizes the Matrix class and supports the reorganized\ntuning file layout for color correction matrices.\n\nv5 mainly adds documentation, as well as a simple cache to the matrix\ninterpolator.\n\nv6 fixes documentation (again).\n\nv7 fixes offsets initialization and adds ccm to metadata, as well as\ncopyright and licenses, as these classes weren't actually copied.\n\nv8 cleans up a bunch of stuff, including yaml parsing, thus adding a new\ndependency on the aforementioned series.\n\nv9 fixes some compilation errors that fell through the cracks.\n\nv10 addresses small review comments\n\nPaul Elder (4):\n ipa: libipa: Add Matrix class\n ipa: libipa: Add MatrixInterpolator class\n ipa: rkisp1: algorithms: Add crosstalk algorithm\n ipa: libipa: vector: Add matrix-vector multiplication\n\n src/ipa/libipa/matrix.cpp | 149 ++++++++++++++++++\n src/ipa/libipa/matrix.h | 204 +++++++++++++++++++++++++\n src/ipa/libipa/matrix_interpolator.cpp | 110 +++++++++++++\n src/ipa/libipa/matrix_interpolator.h | 122 +++++++++++++++\n src/ipa/libipa/meson.build | 4 +\n src/ipa/libipa/vector.cpp | 11 ++\n src/ipa/libipa/vector.h | 17 +++\n src/ipa/rkisp1/algorithms/ccm.cpp | 147 ++++++++++++++++++\n src/ipa/rkisp1/algorithms/ccm.h | 49 ++++++\n src/ipa/rkisp1/algorithms/meson.build | 1 +\n src/ipa/rkisp1/ipa_context.h | 5 +\n 11 files changed, 819 insertions(+)\n create mode 100644 src/ipa/libipa/matrix.cpp\n create mode 100644 src/ipa/libipa/matrix.h\n create mode 100644 src/ipa/libipa/matrix_interpolator.cpp\n create mode 100644 src/ipa/libipa/matrix_interpolator.h\n create mode 100644 src/ipa/rkisp1/algorithms/ccm.cpp\n create mode 100644 src/ipa/rkisp1/algorithms/ccm.h\n\n\nbase-commit: d978832d9e987b555be7c0ee8eeda37981924515"}