{"id":1882,"url":"https://patchwork.libcamera.org/api/1.1/covers/1882/?format=json","web_url":"https://patchwork.libcamera.org/cover/1882/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/1.1/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20190829165311.29196-1-jacopo@jmondi.org>","date":"2019-08-29T16:53:07","name":"[libcamera-devel,v2,0/4] android: Rework metadata tags","submitter":{"id":3,"url":"https://patchwork.libcamera.org/api/1.1/people/3/?format=json","name":"Jacopo Mondi","email":"jacopo@jmondi.org"},"mbox":"https://patchwork.libcamera.org/cover/1882/mbox/","series":[{"id":474,"url":"https://patchwork.libcamera.org/api/1.1/series/474/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=474","date":"2019-08-29T16:53:07","name":"android: Rework metadata tags","version":2,"mbox":"https://patchwork.libcamera.org/series/474/mbox/"}],"comments":"https://patchwork.libcamera.org/api/covers/1882/comments/","headers":{"Return-Path":"","Received":["from relay12.mail.gandi.net (relay12.mail.gandi.net\n\t[217.70.178.232])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 75E8D60BE5\n\tfor ;\n\tThu, 29 Aug 2019 18:51:46 +0200 (CEST)","from uno.lan (2-224-242-101.ip172.fastwebnet.it [2.224.242.101])\n\t(Authenticated sender: jacopo@jmondi.org)\n\tby relay12.mail.gandi.net (Postfix) with ESMTPSA id 4D0B4200007;\n\tThu, 29 Aug 2019 16:51:45 +0000 (UTC)"],"From":"Jacopo Mondi ","To":"libcamera-devel@lists.libcamera.org","Cc":"Jacopo Mondi , kamesan@google.com, jcliang@google.com,\n\tshik@google.com, wtlee@google.com","Date":"Thu, 29 Aug 2019 18:53:07 +0200","Message-Id":"<20190829165311.29196-1-jacopo@jmondi.org>","X-Mailer":"git-send-email 2.23.0","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","Subject":"[libcamera-devel] [PATCH v2 0/4] android: Rework metadata tags","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.23","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","X-List-Received-Date":"Thu, 29 Aug 2019 16:51:46 -0000"},"content":"Hello,\n following a first simple patch\n\"[PATCH] android: camera_device: Add pipeline max depth static metadata\"\n\na discussion with Ren-Pei and Ricky made clear the current metadata support was\nbuggy, and since the ANDROID_REQUEST_AVAILABLE_CAPABILITIES tag was not\nreported, cros_camera_test failed to identify which static tags we were missing.\n\nAdding that tag opened a small pandora box, as the test reported -a lot- of tag\nwhere missing, and some of there were wrongly reported as part of the capture\nrequest template.\n\nThis series tries to address this, by reporting all tags marked as \"BC\" and so\nrequired by LIMITED hardware level devices, cleaning up and improving the\ngenerated request template, and using more opportune sized for each metadata\ntag.\n\ncros_camera_test seems now more happy, both in regard to static metadata and the\ngenerated request template:\n\n# cros_camera_test --gtest_filter=Camera3ModuleFixture.*\n[==========] 9 tests from 1 test case ran. (2 ms total)\n[ PASSED ] 9 tests.\n\n# cros_camera_test --gtest_filter=Camera3DeviceTest*\n[==========] 22 tests from 4 test cases ran. (1044 ms total)\n[ PASSED ] 18 tests.\n[ FAILED ] 4 tests, listed below:\n[ FAILED ] Camera3DeviceTest/Camera3AlgoSandboxIPCErrorTest.IPCErrorBeforeOpen/0, where GetParam() = 0\n[ FAILED ] Camera3DeviceTest/Camera3AlgoSandboxIPCErrorTest.IPCErrorBeforeOpen/1, where GetParam() = 1\n[ FAILED ] Camera3DeviceTest/Camera3AlgoSandboxIPCErrorTest.IPCErrorAfterOpen/0, where GetParam() = 0\n[ FAILED ] Camera3DeviceTest/Camera3AlgoSandboxIPCErrorTest.IPCErrorAfterOpen/1, where GetParam() = 1\n(I guess it's fine if we fail the IPC related tests)\n\nAs all of this has been triggered by a system crash with R78 I would ask Laurent\nto test the series with his environment. I tested with R77 and things seems\nfine.\n\nThanks\n j\n\nJacopo Mondi (4):\n android: camera_device: Add missing static metadata\n android: camera_device: Use correct sizes for static metadata\n android: camera_device: Report available keys\n android: camera_device: Rework template generation\n\n src/android/camera_device.cpp | 499 ++++++++++++++++++++++++++--------\n 1 file changed, 379 insertions(+), 120 deletions(-)\n\n--\n2.23.0"}