{"id":18336,"url":"https://patchwork.libcamera.org/api/1.1/covers/18336/?format=json","web_url":"https://patchwork.libcamera.org/cover/18336/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/1.1/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20230302190629.12506-1-suhrid.subramaniam@mediatek.com>","date":"2023-03-02T19:06:28","name":"[libcamera-devel,libcamera-devel,v3,0/1] libcamera: converter: Check converter validity","submitter":{"id":151,"url":"https://patchwork.libcamera.org/api/1.1/people/151/?format=json","name":"Suhrid Subramaniam","email":"suhridsubramaniam@gmail.com"},"mbox":"https://patchwork.libcamera.org/cover/18336/mbox/","series":[{"id":3786,"url":"https://patchwork.libcamera.org/api/1.1/series/3786/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=3786","date":"2023-03-02T19:06:28","name":"libcamera: converter: Check converter validity","version":3,"mbox":"https://patchwork.libcamera.org/series/3786/mbox/"}],"comments":"https://patchwork.libcamera.org/api/covers/18336/comments/","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 04D1ABF415\n\tfor ;\n\tThu, 2 Mar 2023 19:06:46 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 67DF46269C;\n\tThu, 2 Mar 2023 20:06:45 +0100 (CET)","from mail-pg1-x529.google.com (mail-pg1-x529.google.com\n\t[IPv6:2607:f8b0:4864:20::529])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 49D316267E\n\tfor ;\n\tThu, 2 Mar 2023 20:06:43 +0100 (CET)","by mail-pg1-x529.google.com with SMTP id q189so70046pga.9\n\tfor ;\n\tThu, 02 Mar 2023 11:06:43 -0800 (PST)","from localhost.localdomain (sfosm0151r356001-v22.wiline.com.\n\t[67.207.106.98]) by smtp.gmail.com with ESMTPSA id\n\tx26-20020aa784da000000b005d92c9afbd4sm63678pfn.33.2023.03.02.11.06.39\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tThu, 02 Mar 2023 11:06:40 -0800 (PST)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1677784005;\n\tbh=O6ftFmTGLwH/6SdZWXRQpbxFlpmGG7wMUd9sKa1O/gY=;\n\th=To:Date:Subject:List-Id:List-Unsubscribe:List-Archive:List-Post:\n\tList-Help:List-Subscribe:From:Reply-To:Cc:From;\n\tb=Rfk8TUVXbE44J0qvd37FpqDCn6LsPSZNwFB6/dwD9OKqQKYnGAlw5lbBYopmjj4HO\n\tSuHNMAXDEJV5I+vEDkukM8kMwvTVKCgS74SF+sKwUaYPOqHN1KPvUAhiMP7IzlcX6D\n\tgJNY/ltsKLCjDe6uwdk96brdoTcaF/3yTR6zdIaApFWisABRhQG/OTV+qSpBD+GGGC\n\tR517KaYlBmNUOtwUGRGHgvbbHc2P1PgkgxsSB8GVwEE0QQmVetEFvB9a7DeBX7fXyS\n\tuTrsu6QmiYQYXcYM05L/Xd96nDBC6YKfHtYFDb5M6DLyr9qIXce8dbalSLCuWSQPXA\n\tnuBMDf/q9uD0g==","v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=gmail.com; s=20210112; t=1677784001;\n\th=content-transfer-encoding:mime-version:message-id:date:subject:cc\n\t:to:from:from:to:cc:subject:date:message-id:reply-to;\n\tbh=XVwylwi2ms9XQ374sxPxUctERFVXhy8Sh7tu6Cdawzg=;\n\tb=RU52fJappFDtIv18y2K6sjWf9/R4LaR8uSwBLbilBPFFhjW9szVoTaoE0MfZVTiEZD\n\tm5Qj2FAqgeYTEQYiAG2M11YWtcUSOAH36D2icLtD00xfHrFPH3W7iI3gWuT57h9ft8YB\n\t05+nRVM/QyrW0a18PbpxeKo9RVaHfl0rBcyahvQ/wE5XCOKm1uyOnN+GHq9reJAbSslm\n\t/ONkScaFsmLTrRKYnLazsEovA+gqJ6t4+kcFfJ6hTI1JtzHKIFh1wha6KByLSDFGgPQx\n\tdLmkb1XNKoBEgzaNw+boaMU+/ge/aAzQuuNqe7GiFRQBLKj5i0asW619ZM5cH515DMj+\n\tUtBg=="],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (2048-bit key; \n\tunprotected) header.d=gmail.com header.i=@gmail.com\n\theader.b=\"RU52fJap\"; dkim-atps=neutral","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20210112; t=1677784001;\n\th=content-transfer-encoding:mime-version:message-id:date:subject:cc\n\t:to:from:x-gm-message-state:from:to:cc:subject:date:message-id\n\t:reply-to;\n\tbh=XVwylwi2ms9XQ374sxPxUctERFVXhy8Sh7tu6Cdawzg=;\n\tb=Lcv5LBi7u7WMHhruyhI9khaOgnfnsLipuIhjpM1qG/5O9yiinW0wO48HZVa+MHRehs\n\tBcdJ+cPUN/4IEiX1Dz7wKohXOHZbVX10b9FMbdKaXEXIuoZTZ6DvM0hwX7u0JUijq9+Z\n\tkII+6BiXo1IMTN9trDntH97QLyGICUOiWot4yElqqxrnRImWlgsAVfjhe0rkfDYKXE5X\n\tKYnVY9ahgAEvpVoXDK/+LJE48s4ypACzo3+OErVMFu3iN2sq+BsKjh5KiI6qLHgx74TW\n\t/3x2I+eazi54ME+Sds3Hpl54flyOkkraQOmA+CE1La6xUPxqjRi+wkg5phzTIgD/k4Ca\n\tCEtQ==","X-Gm-Message-State":"AO0yUKXOFyb9aaJTCHWXY6Scdozy34sq1rwlyj/uM8y3Xb1DKVOhkVte\n\t4K6hvvVD4W4I3unfve2KaW8XvyFHDRGrxw==","X-Google-Smtp-Source":"AK7set/j2Id1pMFtuE98ub6lGrC7DybehcMGxr2SU6+rEuAIZc24q1S/hepXcWWTc9sFF4ZafYV5KQ==","X-Received":"by 2002:a62:a518:0:b0:5e3:f20a:b670 with SMTP id\n\tv24-20020a62a518000000b005e3f20ab670mr11387442pfm.2.1677784001179; \n\tThu, 02 Mar 2023 11:06:41 -0800 (PST)","X-Google-Original-From":"Suhrid Subramaniam ","To":"libcamera-devel@lists.libcamera.org","Date":"Thu, 2 Mar 2023 11:06:28 -0800","Message-Id":"<20230302190629.12506-1-suhrid.subramaniam@mediatek.com>","X-Mailer":"git-send-email 2.39.0","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","Subject":"[libcamera-devel] [libcamera-devel, v3,\n\t0/1] libcamera: converter: Check converter validity","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","From":"Suhrid Subramaniam via libcamera-devel\n\t","Reply-To":"Suhrid Subramaniam ","Cc":"Suhrid Subramaniam ","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"- In cases where ConverterFactoryBase::create returns a nullptr,\n converter_->isValid() causes a segmentation fault.\n\n- Solve this by checking if converter_ is a nullptr.\n\n- Additionally, check for converter validity in the create function itself\n and return a nullptr if the converter is invalid.\n\nSuhrid Subramaniam (1):\n libcamera: converter: Check converter validity\n\n src/libcamera/converter.cpp | 3 ++-\n src/libcamera/pipeline/simple/simple.cpp | 2 +-\n 2 files changed, 3 insertions(+), 2 deletions(-)"}