{"id":18289,"url":"https://patchwork.libcamera.org/api/1.1/covers/18289/?format=json","web_url":"https://patchwork.libcamera.org/cover/18289/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/1.1/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20230221164504.120738-1-jacopo.mondi@ideasonboard.com>","date":"2023-02-21T16:45:01","name":"[libcamera-devel,0/3] libcamera: rkisp1: Fix generateConfiguration","submitter":{"id":143,"url":"https://patchwork.libcamera.org/api/1.1/people/143/?format=json","name":"Jacopo Mondi","email":"jacopo.mondi@ideasonboard.com"},"mbox":"https://patchwork.libcamera.org/cover/18289/mbox/","series":[{"id":3760,"url":"https://patchwork.libcamera.org/api/1.1/series/3760/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=3760","date":"2023-02-21T16:45:01","name":"libcamera: rkisp1: Fix generateConfiguration","version":1,"mbox":"https://patchwork.libcamera.org/series/3760/mbox/"}],"comments":"https://patchwork.libcamera.org/api/covers/18289/comments/","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 56807BDCBF\n\tfor ;\n\tTue, 21 Feb 2023 16:45:23 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 95EEA6264A;\n\tTue, 21 Feb 2023 17:45:22 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 2569562636\n\tfor ;\n\tTue, 21 Feb 2023 17:45:21 +0100 (CET)","from uno.homenet.telecomitalia.it\n\t(host-87-16-53-160.retail.telecomitalia.it [87.16.53.160])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 588E3519;\n\tTue, 21 Feb 2023 17:45:20 +0100 (CET)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1676997922;\n\tbh=Vp2UCtISiEP6gpWdmM5+D4c1vjRIH5/iZS1oalkW1P0=;\n\th=To:Date:Subject:List-Id:List-Unsubscribe:List-Archive:List-Post:\n\tList-Help:List-Subscribe:From:Reply-To:Cc:From;\n\tb=u3rqdFDcl9fEwLr/Prl/NX1EguB9K2SIOo1JnRvZB1q9S/etH2cj7kS3nBx9JwFqv\n\tXwn/kBHYTL7UesFwT4nwwRrjTKiBtn7dqlSUPv/kDopFhRhBeLzReDk/r9QiPDxfxe\n\tDljjffu9TxfoHH9IL9N0/lxliVasAUNAdj3qgzkgtg0KRNGnkQ+/0cqlkldEzL7Lhz\n\t35B9yenDdrLn9k2c5wn+kp+UKTb4g1iQrDsDyLZMiE6rdBA4E1NkiWBWwrPK4LCNTw\n\tGJO3TTfVLh3cenrLYxl9B39fB41lLbAYt43fioUl0WjLWbf0ECVuo3JCW/2QOaBZj2\n\tAdMGX46NuTsxw==","v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1676997920;\n\tbh=Vp2UCtISiEP6gpWdmM5+D4c1vjRIH5/iZS1oalkW1P0=;\n\th=From:To:Cc:Subject:Date:From;\n\tb=aKZgz7fcAJLdQcjkc07iqzrK7ayJL3B0SVGAwdGRQa0ZifhN/AcxUdj23KZReTNy0\n\tY1gIft5aC2pJV5zc6Ezqn2XRfRIPe8X2Um9+HTRHxnJZYLtFdpp4oll3myzc6ILI1q\n\tkutiPYeSNPp6MThq2fktLtJctdcnQ3QBG4nRQX64="],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=ideasonboard.com\n\theader.i=@ideasonboard.com\n\theader.b=\"aKZgz7fc\"; dkim-atps=neutral","To":"libcamera-devel@lists.libcamera.org","Date":"Tue, 21 Feb 2023 17:45:01 +0100","Message-Id":"<20230221164504.120738-1-jacopo.mondi@ideasonboard.com>","X-Mailer":"git-send-email 2.39.0","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","Subject":"[libcamera-devel] [PATCH 0/3] libcamera: rkisp1: Fix\n\tgenerateConfiguration","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","From":"Jacopo Mondi via libcamera-devel ","Reply-To":"Jacopo Mondi ","Cc":"Jacopo Mondi , libcamera@luigi311.com","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"The series started with bug 180:\nhttps://bugs.libcamera.org/show_bug.cgi?id=180\n\nwhich reports how using the self-path for generating a configuration\nfor a single stream results in only StreamFormats up to 1920x1920\nto be produced.\n\nI have then noticed how the current implementation of\nRkISP1Path::generateConfiguration() could produce unusual sizes, such as\n1920x1432 in case the sensor's resolution is larger than the maximum supported\n1920x1920 output.\n\nFinally, if StillCapture is requested, make sure it is assigned to the main\npath in RkISP1::generateConfiguration() to make sure it can produce images\nin full resolution.\n\nTested on Pinephone Pro with imx258 camera.\n\nJacopo Mondi (3):\n libcamera: rkisp1: Generate config using main path\n libcamera: rkisp1: Assign sizes to roles\n libcamera: rkisp1: Reserve main path for StillCapture\n\n src/libcamera/pipeline/rkisp1/rkisp1.cpp | 36 +++++++++++++------\n src/libcamera/pipeline/rkisp1/rkisp1_path.cpp | 11 +++---\n src/libcamera/pipeline/rkisp1/rkisp1_path.h | 1 +\n 3 files changed, 33 insertions(+), 15 deletions(-)\n\n--\n2.39.0"}