{"id":18261,"url":"https://patchwork.libcamera.org/api/1.1/covers/18261/?format=json","web_url":"https://patchwork.libcamera.org/cover/18261/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/1.1/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20230208033319.1361109-1-chenghaoyang@google.com>","date":"2023-02-08T03:33:14","name":"[libcamera-devel,v10,0/5] Add CrOS JEA implementation","submitter":{"id":117,"url":"https://patchwork.libcamera.org/api/1.1/people/117/?format=json","name":"Cheng-Hao Yang","email":"chenghaoyang@chromium.org"},"mbox":"https://patchwork.libcamera.org/cover/18261/mbox/","series":[{"id":3743,"url":"https://patchwork.libcamera.org/api/1.1/series/3743/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=3743","date":"2023-02-08T03:33:14","name":"Add CrOS JEA implementation","version":10,"mbox":"https://patchwork.libcamera.org/series/3743/mbox/"}],"comments":"https://patchwork.libcamera.org/api/covers/18261/comments/","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 9C04DBEFBE\n\tfor ;\n\tWed, 8 Feb 2023 03:33:29 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id E3869625E6;\n\tWed, 8 Feb 2023 04:33:28 +0100 (CET)","from mail-pl1-x630.google.com (mail-pl1-x630.google.com\n\t[IPv6:2607:f8b0:4864:20::630])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 62348603B8\n\tfor ;\n\tWed, 8 Feb 2023 04:33:26 +0100 (CET)","by mail-pl1-x630.google.com with SMTP id u9so13588966plf.3\n\tfor ;\n\tTue, 07 Feb 2023 19:33:26 -0800 (PST)","from chenghaoyang-low.c.googlers.com.com\n\t(46.165.189.35.bc.googleusercontent.com. [35.189.165.46])\n\tby smtp.gmail.com with ESMTPSA id\n\te9-20020a170902784900b00194c82c2a7bsm9621963pln.224.2023.02.07.19.33.23\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tTue, 07 Feb 2023 19:33:24 -0800 (PST)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1675827208;\n\tbh=/84sfY9/+iASnHsDq5SAg5am7H7TiAau4Ftol2C41no=;\n\th=To:Date:Subject:List-Id:List-Unsubscribe:List-Archive:List-Post:\n\tList-Help:List-Subscribe:From:Reply-To:Cc:From;\n\tb=IXcKAPiAnBCKSY9nDrJYRUXxVuNWDzaXU/WVRfe198qbza5EPigg0MMUnY1IrRKX+\n\t+4WyyuI8/2d8Zqskeqs2lFC6qEEtuWe3ph2kRIS9llaO3twwqOqe0ap34X2QJq+9q7\n\t8HYHK5Mi/zNNiWdeOOjHoJ+fPYR9a1S1Bd8OYGvtPJxOI16e9LtBS6iazVIoJbMUSV\n\tnzBmtsXTvmv6cHk3e8ML3fhR9q9nZ2ILY4Nx9UAa81cAsVwDs9p2aBHITUdGfIFnnz\n\tLaZef7FXrsZ6ibxB0wJ8Ry0zDGapMoCuIGItSBzn+BLezbZFKBPBmnmera7ag6Bi+b\n\tHgsunIhUS8ywQ==","v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org;\n\ts=google; \n\th=content-transfer-encoding:mime-version:message-id:date:subject:cc\n\t:to:from:from:to:cc:subject:date:message-id:reply-to;\n\tbh=OYLvxaD3ENdabMNIHtDiCC7ENySsPtRy3dXkXl5JHdE=;\n\tb=KHWtnd1kH8k2x7GPNd4P09fx0DBOrnOtbAUxqQrwnCMZY4bzF1HBcxE5byTUWYTeIf\n\tVhW2byF4LOZxIdpdbGzLnpuFG+aV+dA60MDhbNd5VGtjtfDvHavd21KBCSOOM4GxOQ8K\n\tyrYbxUPDGX7L05qPXzqaGl7evUgNaffsVirMs="],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=chromium.org\n\theader.i=@chromium.org header.b=\"KHWtnd1k\"; \n\tdkim-atps=neutral","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20210112;\n\th=content-transfer-encoding:mime-version:message-id:date:subject:cc\n\t:to:from:x-gm-message-state:from:to:cc:subject:date:message-id\n\t:reply-to;\n\tbh=OYLvxaD3ENdabMNIHtDiCC7ENySsPtRy3dXkXl5JHdE=;\n\tb=mAvCL8id7/R5wi3R54Cl6UKEYC9gQuQotTsIz/O9M/vW75ZqdYBlLpQnim2IMw9PRQ\n\thA3PRpT54U1acnOLv/rKj3W3yyBQc7gn5a4saoNa7dYNaNQ7yuVIwf98OhYki7Nr5RaQ\n\tA3KP0nBCSeeyBt8FiZ8L2KWKyfnI/dx002ZCBI14Q8qThLmndnjCCEgTnSbCeZobt/BD\n\tJ7Bg4wZxXUmFI2mPwMfSxXXLGznbuCEH5qATRlc7vb4AkR0bbjbYZOa5zXkYyvXrvu1v\n\tD7kID4UeoUN/WhBWNeJNYueEsWGPEDwcUtJIuebRJXi50SyXRE7NVFA+JWC/+Wa3onka\n\tV5jg==","X-Gm-Message-State":"AO0yUKXDhZu/2YeN19jOI2bRwiGTxlX56qCf4c8EiklJu7VYMY1WYE16\n\thaeuQP4JbK0CenyMVpfP4UwGpwC/W4zcGlSO","X-Google-Smtp-Source":"AK7set+wEWv+Z4Q8A4oft72zmPbD53eu2ttqyQV/YgYRHUk/DZBG2F/f3vUwohCA8tJiWaQXjPM3DQ==","X-Received":"by 2002:a17:902:d4cc:b0:198:9bf8:298e with SMTP id\n\to12-20020a170902d4cc00b001989bf8298emr6154952plg.60.1675827204453; \n\tTue, 07 Feb 2023 19:33:24 -0800 (PST)","X-Google-Original-From":"Harvey Yang ","To":"libcamera-devel@lists.libcamera.org","Date":"Wed, 8 Feb 2023 03:33:14 +0000","Message-Id":"<20230208033319.1361109-1-chenghaoyang@google.com>","X-Mailer":"git-send-email 2.39.1.519.gcb327c4b5f-goog","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","Subject":"[libcamera-devel] [PATCH v10 0/5] Add CrOS JEA implementation","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","From":"Harvey Yang via libcamera-devel ","Reply-To":"Harvey Yang ","Cc":"Harvey Yang ","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"Hi Laurent and all,\n\nAs discussed offline, I think it's better to keep the generateThumbnail\nas is. In other words, don't let `Encoder` have a different function to\ngenerate thumbnails. In both implementations, an EncoderLibJpeg instance\nwill be used to generate thumbnails.\n\nThis means the previous 4/8, 5/8, 6/8 patches are no longer needed.\nPlease check if the new series make sense. Thanks!\n\nBR,\nHarvey\n\nHarvey Yang (5):\n libcamera: framebuffer: Allow inheritance of FrameBuffer\n android: framebuffer: Add HALFrameBuffer and replace FrameBuffer\n android: jpeg: Add meson.build in src/android/jpeg\n android: jpeg: Pass StreamBuffer to Encoder::encoder\n android: jpeg: Add JEA implementation\n\n include/libcamera/framebuffer.h | 3 +-\n src/android/camera_device.cpp | 5 +-\n src/android/camera_device.h | 3 +-\n src/android/camera_request.h | 3 +-\n src/android/cros/camera3_hal.cpp | 4 +-\n src/android/cros_mojo_token.h | 12 ++++\n src/android/frame_buffer_allocator.h | 7 ++-\n src/android/hal_framebuffer.cpp | 22 ++++++++\n src/android/hal_framebuffer.h | 26 +++++++++\n src/android/jpeg/encoder.h | 5 +-\n src/android/jpeg/encoder_jea.cpp | 56 +++++++++++++++++++\n src/android/jpeg/encoder_jea.h | 31 ++++++++++\n src/android/jpeg/encoder_libjpeg.cpp | 13 +++--\n src/android/jpeg/encoder_libjpeg.h | 3 +-\n src/android/jpeg/meson.build | 14 +++++\n src/android/jpeg/post_processor_jpeg.cpp | 11 +++-\n src/android/meson.build | 6 +-\n .../mm/cros_frame_buffer_allocator.cpp | 9 +--\n .../mm/generic_frame_buffer_allocator.cpp | 11 ++--\n 19 files changed, 213 insertions(+), 31 deletions(-)\n create mode 100644 src/android/cros_mojo_token.h\n create mode 100644 src/android/hal_framebuffer.cpp\n create mode 100644 src/android/hal_framebuffer.h\n create mode 100644 src/android/jpeg/encoder_jea.cpp\n create mode 100644 src/android/jpeg/encoder_jea.h\n create mode 100644 src/android/jpeg/meson.build"}