{"id":18224,"url":"https://patchwork.libcamera.org/api/1.1/covers/18224/?format=json","web_url":"https://patchwork.libcamera.org/cover/18224/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/1.1/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20230130180244.2150205-1-kieran.bingham@ideasonboard.com>","date":"2023-01-30T18:02:42","name":"[libcamera-devel,0/2] Camera/Request reliability","submitter":{"id":4,"url":"https://patchwork.libcamera.org/api/1.1/people/4/?format=json","name":"Kieran Bingham","email":"kieran.bingham@ideasonboard.com"},"mbox":"https://patchwork.libcamera.org/cover/18224/mbox/","series":[{"id":3732,"url":"https://patchwork.libcamera.org/api/1.1/series/3732/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=3732","date":"2023-01-30T18:02:42","name":"Camera/Request reliability","version":1,"mbox":"https://patchwork.libcamera.org/series/3732/mbox/"}],"comments":"https://patchwork.libcamera.org/api/covers/18224/comments/","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 0E840BDC71\n\tfor ;\n\tMon, 30 Jan 2023 18:02:51 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 6C6CB625D8;\n\tMon, 30 Jan 2023 19:02:50 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 542D760482\n\tfor ;\n\tMon, 30 Jan 2023 19:02:48 +0100 (CET)","from Monstersaurus.local\n\t(cpc89244-aztw30-2-0-cust3082.18-1.cable.virginm.net [86.31.172.11])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id BBC9E8B8;\n\tMon, 30 Jan 2023 19:02:47 +0100 (CET)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1675101770;\n\tbh=9MZvYK1i/Afi5dutkzSJME9jxiYHly0SP0Fi3oVw/Y8=;\n\th=To:Date:Subject:List-Id:List-Unsubscribe:List-Archive:List-Post:\n\tList-Help:List-Subscribe:From:Reply-To:From;\n\tb=nTOCdmu85sPdEwENyFD7HdXZiP+8Glc5TX1FqtK6nr9f9k8zSuIwblq35apaMjRuR\n\td+Lf1e4VEr45TjvkWDPziERZeLbFdw1am8+B+nnjMpr1Uu7U8EBaHQSeshqKXg3tag\n\tg5oo9ANXyA6Z34lx2q6m2SegKWsK6Dy4+r5YK1AwyHjj93l/x6Zx+jJ2sRIddPxolL\n\tMTUqC1dV7+U7I8dOnYssPtgH7WXLtetWGQkVgyHPBTfqpA8s+YJGM68kaSsHd5lu7i\n\tva37bUw0F7d7waLbzI0d1epx7xPtRvjro9KDORCuq+tmOhhtSxd5YNcd38MOQgkvfO\n\tKggHbmyrBBg+Q==","v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1675101767;\n\tbh=9MZvYK1i/Afi5dutkzSJME9jxiYHly0SP0Fi3oVw/Y8=;\n\th=From:To:Cc:Subject:Date:From;\n\tb=VZ+mvMfi4a+lUccuXvPx+ZuAbWNf6gsATAk4f9v08/BW56J8BfheJHu3K4mcDvYdD\n\tYgsNlSVJ/OOZoR/kg5Wjd0nKozI/wV+TY8vaFG4MPNgJxbzAzNju4Qtrg8XxGVnzcC\n\tQegpaKX6hBnAqX/cIaLskQhDmhx8ljZ7wPWjCuPo="],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=ideasonboard.com\n\theader.i=@ideasonboard.com\n\theader.b=\"VZ+mvMfi\"; dkim-atps=neutral","To":"libcamera devel ","Date":"Mon, 30 Jan 2023 18:02:42 +0000","Message-Id":"<20230130180244.2150205-1-kieran.bingham@ideasonboard.com>","X-Mailer":"git-send-email 2.34.1","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","Subject":"[libcamera-devel] [PATCH 0/2] Camera/Request reliability","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","From":"Kieran Bingham via libcamera-devel\n\t","Reply-To":"Kieran Bingham ","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"While supporting the development of Adam Pigg's Harbour-Pinhole\napplication, it was clear that it's too easy to submit incorrect\nrequests to libcamera - resulting in somewhat undefined behaviour and\nthen rather confusing crashes and assertions internally.\n\nThese two patches add protection to the submission of Requests objects\nto a Camera.\n\n\nKieran Bingham (2):\n libcamera: camera: Ensure queued requests are prepared\n libcamera: request: A request canary\n\n include/libcamera/internal/request.h | 2 ++\n include/libcamera/request.h | 4 +++\n src/libcamera/camera.cpp | 10 ++++++\n src/libcamera/request.cpp | 54 ++++++++++++++++++++++++++--\n 4 files changed, 68 insertions(+), 2 deletions(-)"}