{"id":18170,"url":"https://patchwork.libcamera.org/api/1.1/covers/18170/?format=json","web_url":"https://patchwork.libcamera.org/cover/18170/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/1.1/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20230123140619.177878-1-mike.rudenko@gmail.com>","date":"2023-01-23T14:06:15","name":"[libcamera-devel,v2,0/4] Add Omnivision OV4689 support","submitter":{"id":146,"url":"https://patchwork.libcamera.org/api/1.1/people/146/?format=json","name":"Mikhail Rudenko","email":"mike.rudenko@gmail.com"},"mbox":"https://patchwork.libcamera.org/cover/18170/mbox/","series":[{"id":3718,"url":"https://patchwork.libcamera.org/api/1.1/series/3718/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=3718","date":"2023-01-23T14:06:15","name":"Add Omnivision OV4689 support","version":2,"mbox":"https://patchwork.libcamera.org/series/3718/mbox/"}],"comments":"https://patchwork.libcamera.org/api/covers/18170/comments/","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 47FF5BEFBE\n\tfor ;\n\tMon, 23 Jan 2023 14:06:34 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 834B7625DF;\n\tMon, 23 Jan 2023 15:06:33 +0100 (CET)","from mail-lf1-x134.google.com (mail-lf1-x134.google.com\n\t[IPv6:2a00:1450:4864:20::134])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 74807603C7\n\tfor ;\n\tMon, 23 Jan 2023 15:06:31 +0100 (CET)","by mail-lf1-x134.google.com with SMTP id cf42so18369442lfb.1\n\tfor ;\n\tMon, 23 Jan 2023 06:06:31 -0800 (PST)","from localhost (93-80-66-125.broadband.corbina.ru. [93.80.66.125])\n\tby smtp.gmail.com with ESMTPSA id\n\tu15-20020a05651c130f00b0028b756197d1sm2983095lja.17.2023.01.23.06.06.28\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tMon, 23 Jan 2023 06:06:29 -0800 (PST)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1674482793;\n\tbh=8xt7OALZsy0JxqBamJRcBSUsrkVyFxG06M5Sr62G21Y=;\n\th=To:Date:Subject:List-Id:List-Unsubscribe:List-Archive:List-Post:\n\tList-Help:List-Subscribe:From:Reply-To:Cc:From;\n\tb=323Vf4JE7cr4Wtkr5MfTTYeTjx7lImlPRpb67+v9PkkQDuj2oFHo2oVJyj5Zmwfmj\n\ttz9/KBQbBR3hKqcjpHKRJDsk7j7AefBtpqk1xpSsH8CHjfh0w/UxDTIBu0Oqq67XRs\n\to5MoNLePGgkFsjml62kHk5C8qa1h1ixXN3WEUBaaPbCJNHcTr9/xhCEpnrerh2Wam9\n\toE5JEgU/mANSGxVoqBLQ6HlZsYDySnYRGjDSEQr0oqkGnKAEi/U/7LD4dB9YEqNDQD\n\tA18sAqg1WUwfJAn4VKyPsJn/2tSA1rGuWgGq1GyGPD5NJc7TsqJYzr3OaAk8a6HZx7\n\tCRRg+4PXoNCDA==","v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112;\n\th=content-transfer-encoding:mime-version:message-id:date:subject:cc\n\t:to:from:from:to:cc:subject:date:message-id:reply-to;\n\tbh=2k+n3ZopC4qF6yHHkrucbsHaQtBAdY4Ln+AdHoKDKH0=;\n\tb=P+fFficVz1eqRyMTgMbWEyorC/0fHHq4MTQPi3jeQgyjPXCJm4zDCupwwMusCwAhns\n\te3264aGaGxWuXSV2AkMox+rLgCd0r6Cb14R3KWA9b+xCnmRNpjza3DBpqfNPqzYEQdaS\n\t2nxVRXqzWNiDX8zHcgVjmn38qeXXBCLlzZtebcL3t1vFZqcA3k2fzdJNkciw0jr9KZVY\n\t4PGAAAUvlhV1PCTQIEAFqfqxxiX4IgLKE2hMnSJXUedR9WIeDuTUAv7MQdBG8KSFrTVb\n\tZ2d5us8DdfpOwNoxwzMrZmkNOHVmUEhjcT27g1QNKM3mdNuodhLLoVQLzEc2Xu401Bct\n\tM2vA=="],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (2048-bit key; \n\tunprotected) header.d=gmail.com header.i=@gmail.com\n\theader.b=\"P+fFficV\"; dkim-atps=neutral","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20210112;\n\th=content-transfer-encoding:mime-version:message-id:date:subject:cc\n\t:to:from:x-gm-message-state:from:to:cc:subject:date:message-id\n\t:reply-to;\n\tbh=2k+n3ZopC4qF6yHHkrucbsHaQtBAdY4Ln+AdHoKDKH0=;\n\tb=XC5YGc8TI9QO8Ez0rohUXFZjDatd/zRuhdF1zoqcJ8ulSAnPCWDRVFCL4J0w9P4NEQ\n\t0OTfkJsOMHM1yPbSY79VQYsxMjhN7/REuXyrtSlwGsbhVO102bls90CVnzTaixHzSoZa\n\tP/6L6FuRwwrQp8sbgnR6NI7caOTWmvBgZcqBscqRQkI7udiurXSKU4SbzPVRHOPeWjyE\n\t9v7Gvtq0ORiIVyoWCpP493XcIRYthfp7Pg6SxXR6yQ1q1D4gTjTNRZ1XZJ9fa1MSE8h9\n\twGQMowQrfOXl6gkhfBEaozU7KVSjr+c9QLGhwmsAKVclEPNUuAlt/d+TIRGyWeCBNkcc\n\tBmqg==","X-Gm-Message-State":"AFqh2koLqcknjoCK57cTahG0TVaSSbV51ynYAbnw0Q2UsUtaYbo5JTuv\n\tCztfewiAv1FV4QN3T5Gj8sSaYoCCAQg=","X-Google-Smtp-Source":"AMrXdXuKZZRPM6mbfTVB4sDcn2nrWSww22hU/AGmWuz4/V6JiLUykCufGIqvuGhCvg4OfVRwHGoapg==","X-Received":"by 2002:a05:6512:2216:b0:4cd:47e:47a9 with SMTP id\n\th22-20020a056512221600b004cd047e47a9mr7577549lfu.58.1674482789883; \n\tMon, 23 Jan 2023 06:06:29 -0800 (PST)","To":"libcamera-devel@lists.libcamera.org","Date":"Mon, 23 Jan 2023 17:06:15 +0300","Message-Id":"<20230123140619.177878-1-mike.rudenko@gmail.com>","X-Mailer":"git-send-email 2.39.1","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","Subject":"[libcamera-devel] [PATCH v2 0/4] Add Omnivision OV4689 support","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","From":"Mikhail Rudenko via libcamera-devel\n\t","Reply-To":"Mikhail Rudenko ","Cc":"Mikhail Rudenko ","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"Hi,\n\nthis is second revision of OV4689 support series. In this revision\nI've tried to adress all of Jacopo's comments. Specifically, I've done some\nexperimentation concerning the black level.\n\nWhen capturing raw SBGGR10 frames with exposition and gain manually\nset to minimum and the lens lid closed, pixel values randomly\nfluctuate between 16 and 17. This corrsponds to 64-68 for\nBlackLevelCorrection. I have also found that setting it to 66 is right\nenough to have all zeros in XRGB8888 frames, so I've updated the\ntuning file accordingly.\n\nChanges in v2:\n- collect R-b for [1/4]\n- expose TestPatternModeColorBarsFadeToGray to libcamera\n- use black level correction value of 66 (found experimentally)\n\nMikhail Rudenko (4):\n ipa: camera_sensor_helper: Add OV4689 support\n libcamera: camera_sensor: Add OV4689 sensor properties\n ipa: rkisp1: Add OV4689 tuning file\n ipa: rkisp1: Raise maximum analogue gain\n\n src/ipa/libipa/camera_sensor_helper.cpp | 11 +++++++++++\n src/ipa/rkisp1/algorithms/agc.cpp | 2 +-\n src/ipa/rkisp1/data/meson.build | 1 +\n src/ipa/rkisp1/data/ov4689.yaml | 13 +++++++++++++\n src/libcamera/camera_sensor_properties.cpp | 13 +++++++++++++\n 5 files changed, 39 insertions(+), 1 deletion(-)\n create mode 100644 src/ipa/rkisp1/data/ov4689.yaml\n\n--\n2.39.1"}