{"id":18117,"url":"https://patchwork.libcamera.org/api/1.1/covers/18117/?format=json","web_url":"https://patchwork.libcamera.org/cover/18117/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/1.1/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20230116002808.16014-1-laurent.pinchart@ideasonboard.com>","date":"2023-01-16T00:28:00","name":"[libcamera-devel,v9,0/8] Add CrOS JEA implementation","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/1.1/people/2/?format=json","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"mbox":"https://patchwork.libcamera.org/cover/18117/mbox/","series":[{"id":3712,"url":"https://patchwork.libcamera.org/api/1.1/series/3712/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=3712","date":"2023-01-16T00:28:00","name":"Add CrOS JEA implementation","version":9,"mbox":"https://patchwork.libcamera.org/series/3712/mbox/"}],"comments":"https://patchwork.libcamera.org/api/covers/18117/comments/","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id CFC16BD87C\n\tfor ;\n\tMon, 16 Jan 2023 00:28:10 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 14767625D8;\n\tMon, 16 Jan 2023 01:28:10 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id D8B1F625D0\n\tfor ;\n\tMon, 16 Jan 2023 01:28:08 +0100 (CET)","from pendragon.ideasonboard.com (213-243-189-158.bb.dnainternet.fi\n\t[213.243.189.158])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 3BC70997;\n\tMon, 16 Jan 2023 01:28:08 +0100 (CET)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1673828890;\n\tbh=zmck68BBi0tjwKKuZsAvhs+IXirm/XJJuydgKrGYsnI=;\n\th=To:Date:Subject:List-Id:List-Unsubscribe:List-Archive:List-Post:\n\tList-Help:List-Subscribe:From:Reply-To:Cc:From;\n\tb=Bn4AXzBh6Hd0/zGgjzF8lfHd1VPC8nHquQmbcaLKFcGcTZ7CTmP8aGWUcvA7FH6AF\n\tAg+dw5A5p5cF++FcghF8uGxnl9P+l1PcboKgpv3aUxJ9Z00hWexeJ2OFL58qccWV1q\n\tVs/QqUPJOtV2is1CyngHzW9+Zx5zkFUxIDUvpmBtNQ6oeBmX9NeJgpu15ms4nq7Kq8\n\taPRx9nZyAUdvfeVj5bPVByuOmUOaMWgYNHPGnwLPdYrHPIM2I5Mvs1smk1aScUdGXL\n\tWY7QOAmqt04NpAG1J884MIlCA13xfJJrn3bzQuEsQ4ATTlYdqiZMaKh0d1Osz8om7f\n\tNkY4e8dX2b8zQ==","v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1673828888;\n\tbh=zmck68BBi0tjwKKuZsAvhs+IXirm/XJJuydgKrGYsnI=;\n\th=From:To:Cc:Subject:Date:From;\n\tb=v+gvd9KsbesZDUo0EJPTvwgzBD8UnmFVbfI1TjnVtqwUyHDaoSOABbsL7IkamSS+b\n\t8cvw06FRPH6GWrSVAnRVqIVW/uQjwh6qqb05jtsp0Pm5UYmzwYA9fNFdAP9g0kAudl\n\tI8kflBFfDUqFEFH3InA8Dn2rZ0sQyJVPC2W+Qp0M="],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=ideasonboard.com\n\theader.i=@ideasonboard.com\n\theader.b=\"v+gvd9Ks\"; dkim-atps=neutral","To":"libcamera-devel@lists.libcamera.org","Date":"Mon, 16 Jan 2023 02:28:00 +0200","Message-Id":"<20230116002808.16014-1-laurent.pinchart@ideasonboard.com>","X-Mailer":"git-send-email 2.38.2","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","Subject":"[libcamera-devel] [PATCH v9 0/8] Add CrOS JEA implementation","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","From":"Laurent Pinchart via libcamera-devel\n\t","Reply-To":"Laurent Pinchart ","Cc":"Harvey Yang ","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"Hello,\n\nHere's a new version of Harvey's JEA series, with all the comments I've\nsent during review of v8 addressed. Up to the last patch in v8 I thought\nI would address all comments when applying, so I folded them in my tree,\nand it seemed a waste of effort to delete it all and let Harvey do the\nsame.\n\nCompared to v8, I've also added patch 6/8 that returns an int error code\nfrom the generateThumbnail() function.\n\nHarvey, patch 8/8 may be ready, but I didn't add a Reviewed-by tag as\nI've asked a few questions in the review of v8. Depending on the answer,\nI could push v9 as-is. Your review of 6/8 would be appreciated (and feel\nfree to push back if you don't think it's a good idea), as well as a\ntest of the whole series to make sure I didn't break anything (I've only\ncompile-tested this).\n\nHarvey Yang (7):\n libcamera: framebuffer: Allow inheritance of FrameBuffer\n android: framebuffer: Add HALFrameBuffer and replace FrameBuffer\n android: jpeg: Add meson.build in src/android/jpeg\n android: jpeg: Add an internal Encoder class in EncoderLibJpeg\n android: jpeg: Move generateThumbnail from PostProcessorJpeg to\n Encoder\n android: jpeg: Pass StreamBuffer to Encoder::encoder\n android: jpeg: Add JEA implementation\n\nLaurent Pinchart (1):\n android: jpeg: Return an error code from generateThumbnail()\n\n include/libcamera/framebuffer.h | 3 +-\n src/android/camera_device.cpp | 5 +-\n src/android/camera_device.h | 3 +-\n src/android/camera_request.h | 3 +-\n src/android/cros/camera3_hal.cpp | 4 +-\n src/android/cros_mojo_token.h | 12 ++\n src/android/frame_buffer_allocator.h | 7 +-\n src/android/hal_framebuffer.cpp | 22 ++++\n src/android/hal_framebuffer.h | 26 +++++\n src/android/jpeg/encoder.h | 9 +-\n src/android/jpeg/encoder_jea.cpp | 103 +++++++++++++++++\n src/android/jpeg/encoder_jea.h | 35 ++++++\n src/android/jpeg/encoder_libjpeg.cpp | 108 ++++++++++++++----\n src/android/jpeg/encoder_libjpeg.h | 46 +++++---\n src/android/jpeg/meson.build | 17 +++\n src/android/jpeg/post_processor_jpeg.cpp | 65 ++---------\n src/android/jpeg/post_processor_jpeg.h | 10 +-\n src/android/meson.build | 6 +-\n .../mm/cros_frame_buffer_allocator.cpp | 9 +-\n .../mm/generic_frame_buffer_allocator.cpp | 11 +-\n 20 files changed, 385 insertions(+), 119 deletions(-)\n create mode 100644 src/android/cros_mojo_token.h\n create mode 100644 src/android/hal_framebuffer.cpp\n create mode 100644 src/android/hal_framebuffer.h\n create mode 100644 src/android/jpeg/encoder_jea.cpp\n create mode 100644 src/android/jpeg/encoder_jea.h\n create mode 100644 src/android/jpeg/meson.build\n\n\nbase-commit: aed615e1730d17a3da77ea22d5af43440cc4d873"}