{"id":17935,"url":"https://patchwork.libcamera.org/api/1.1/covers/17935/?format=json","web_url":"https://patchwork.libcamera.org/cover/17935/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/1.1/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20221202124005.3643-1-naush@raspberrypi.com>","date":"2022-12-02T12:40:03","name":"[libcamera-devel,v2,0/2] Add read-only flag to ControlInfo","submitter":{"id":34,"url":"https://patchwork.libcamera.org/api/1.1/people/34/?format=json","name":"Naushir Patuck","email":"naush@raspberrypi.com"},"mbox":"https://patchwork.libcamera.org/cover/17935/mbox/","series":[{"id":3654,"url":"https://patchwork.libcamera.org/api/1.1/series/3654/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=3654","date":"2022-12-02T12:40:03","name":"Add read-only flag to ControlInfo","version":2,"mbox":"https://patchwork.libcamera.org/series/3654/mbox/"}],"comments":"https://patchwork.libcamera.org/api/covers/17935/comments/","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 317C2BE08B\n\tfor ;\n\tFri, 2 Dec 2022 12:40:09 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id B4DEA63342;\n\tFri, 2 Dec 2022 13:40:08 +0100 (CET)","from mail-wr1-x434.google.com (mail-wr1-x434.google.com\n\t[IPv6:2a00:1450:4864:20::434])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id F39BB60483\n\tfor ;\n\tFri, 2 Dec 2022 13:40:06 +0100 (CET)","by mail-wr1-x434.google.com with SMTP id q7so7611502wrr.8\n\tfor ;\n\tFri, 02 Dec 2022 04:40:06 -0800 (PST)","from naush-laptop.localdomain ([93.93.133.154])\n\tby smtp.gmail.com with ESMTPSA id\n\ty15-20020a5d4acf000000b00241e5b917d0sm8276484wrs.36.2022.12.02.04.40.05\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tFri, 02 Dec 2022 04:40:06 -0800 (PST)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1669984808;\n\tbh=WgfTMgiT2h2koTink5AMK2cgVpdEvH8xZGc0F4d9smU=;\n\th=To:Date:Subject:List-Id:List-Unsubscribe:List-Archive:List-Post:\n\tList-Help:List-Subscribe:From:Reply-To:From;\n\tb=v8D5AmfO8CqZ538bLq9TdbB1tyif1uQbzqg7PdN+sq81MHxcZ+zcKPQu2pr0r9zUF\n\tcnWUT21Y4Ghjr5ceFyeVqUMrSuT9xcS3pJf0W1+bsyeHpo/Bs3jw765MeWViuqvKvB\n\tuIK3GVnf+srFRCDyCEmZ76GqjR0Ah40VQJjemx+/Ld5zmDVAHIITH+P/Xo5gFJDi7z\n\tc4fNArKi+w1LB3RD4GOiLoMYYDVhY2lWLgokdPKx/g4B8CEI1nfSlRvIRZUXv3BxeW\n\tZdiCQWOVooaETsN8dGuxqWfpNNmo4hudTozuizF7oytFuJGJr83s3zpwxE2tYMRbGo\n\tIjpI8/iwP/2kw==","v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=raspberrypi.com; s=google;\n\th=content-transfer-encoding:mime-version:message-id:date:subject:cc\n\t:to:from:from:to:cc:subject:date:message-id:reply-to;\n\tbh=n7JfvoyjZ9CisCwQzlYuffIN31sk4BLuhg6sZHP9pqk=;\n\tb=lk5ngN9fghf8eN4Tji/PhsLsGAwZV/G6wuoY0GqDuQXmWl7LplR0oZXE1+7G37oJ+9\n\tjofpoji7y68Bs8tZBCk2uVBqJDNBbWoSxFWbbnjj+ILSYI2Ht+Go6UkFaTqcR7Dzi52A\n\tKU8c/9ci+lDLFoC3/X7olfvSCAGL6Pg2LRKXb5A6ubDCqnblln8CWy7aM6Qoklz/byKw\n\tNj6om7iRiPhpiBMqPphCVmfxVdgkw9hwLnbjSyttl2gW6e1vqR6ogro67zWeK5QULgnD\n\tJKGQgSc8Y/2F5ttJPMQ+ruIQBbULQZGU1Ut5FlFDGp+vtJX/90yqA3Bew2YX2pTq383o\n\tasYA=="],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (2048-bit key; \n\tunprotected) header.d=raspberrypi.com\n\theader.i=@raspberrypi.com\n\theader.b=\"lk5ngN9f\"; dkim-atps=neutral","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20210112;\n\th=content-transfer-encoding:mime-version:message-id:date:subject:cc\n\t:to:from:x-gm-message-state:from:to:cc:subject:date:message-id\n\t:reply-to;\n\tbh=n7JfvoyjZ9CisCwQzlYuffIN31sk4BLuhg6sZHP9pqk=;\n\tb=wPFoX1Re1n1a+j0HUp6v1zKuXIxcj+VasqoyM0zxyoweGhnd3jnjAtseiRyRFK8Ou8\n\tokUstre1mT2xj7a8o4uU5busCmY72PlR0ljxKMwbj36/mWnLqhPjtwoFx6Qd3AZ6FQZt\n\tdu55PRIZNUnit2vCqeVXx5h+QeUbGLva55bJqYEMYcT0dMBAdzzJhs1FyHkSCstBpctt\n\tWQlmlF5spCkx0h1BcVWOHqns4HakJNaTqaP4se7rpUJ7quJq06efeTaGKsOytjDjhgOm\n\tEUZulpOeC8l1v05/FHJre+PfezTCpOfqYqR4qMd4ubR88pMHL8iL054BtX8u7QKBIoAq\n\tknkw==","X-Gm-Message-State":"ANoB5pk11Mf8dSiWK7/MnzBX94UcNZotqsRjGDfFQ/RPyRc3+IHuEAzY\n\tD1G/AJOb0fLpF0tDqGCq5INS4ITt1tywPLKU","X-Google-Smtp-Source":"AA0mqf4rKA+5XOpEtymijSRrBM3AvC0DKkuYk45lUbW41bpQsdvnDmKCa0tdFKUHnq65qiI/w1MN0g==","X-Received":"by 2002:adf:fc48:0:b0:236:e0d:9ad with SMTP id\n\te8-20020adffc48000000b002360e0d09admr33849951wrs.692.1669984806398; \n\tFri, 02 Dec 2022 04:40:06 -0800 (PST)","To":"libcamera-devel@lists.libcamera.org","Date":"Fri, 2 Dec 2022 12:40:03 +0000","Message-Id":"<20221202124005.3643-1-naush@raspberrypi.com>","X-Mailer":"git-send-email 2.25.1","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","Subject":"[libcamera-devel] [PATCH v2 0/2] Add read-only flag to ControlInfo","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","From":"Naushir Patuck via libcamera-devel\n\t","Reply-To":"Naushir Patuck ","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"Hi,\n\nThis small patch series adds a read-only flag to ControlInfo. This is used\nto test if a control, in particular V4L2_CID_HBLANK, can be written to by\nuserland. It replaces the slightly fragile workaround we have right now where\nwe test if the min and max values of a control are the same to determine if\na control is read-only.\n\nI've only modified the one ControlInfo constructor signature used by the\nV4L2Device class to allow this flag to be set, as setting it for a non-v4l2\ncontrol probably does not make sense at this point. If folks think this is\nincorrect, please let me know.\n\nRegards,\nNaush\n\nNaushir Patuck (2):\n libcamera: controls: Add read-only flag to ControlInfo\n libcamera:camera_sensor, ipa: raspberrypi: Test readOnly() for HBLANK\n control\n\n include/libcamera/controls.h | 5 ++++-\n src/ipa/raspberrypi/raspberrypi.cpp | 12 +-----------\n src/libcamera/camera_sensor.cpp | 14 ++------------\n src/libcamera/controls.cpp | 17 +++++++++++++----\n src/libcamera/v4l2_device.cpp | 12 ++++++++----\n 5 files changed, 28 insertions(+), 32 deletions(-)"}