{"id":17625,"url":"https://patchwork.libcamera.org/api/1.1/covers/17625/?format=json","web_url":"https://patchwork.libcamera.org/cover/17625/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/1.1/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20221019090107.19975-1-naush@raspberrypi.com>","date":"2022-10-19T09:01:00","name":"[libcamera-devel,v4,0/7] Raspberry Pi AGC digital gain fixes","submitter":{"id":34,"url":"https://patchwork.libcamera.org/api/1.1/people/34/?format=json","name":"Naushir Patuck","email":"naush@raspberrypi.com"},"mbox":"https://patchwork.libcamera.org/cover/17625/mbox/","series":[{"id":3566,"url":"https://patchwork.libcamera.org/api/1.1/series/3566/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=3566","date":"2022-10-19T09:01:00","name":"Raspberry Pi AGC digital gain fixes","version":4,"mbox":"https://patchwork.libcamera.org/series/3566/mbox/"}],"comments":"https://patchwork.libcamera.org/api/covers/17625/comments/","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 755E9C0DA4\n\tfor ;\n\tWed, 19 Oct 2022 09:01:18 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 31E3662E3F;\n\tWed, 19 Oct 2022 11:01:18 +0200 (CEST)","from mail-wm1-x332.google.com (mail-wm1-x332.google.com\n\t[IPv6:2a00:1450:4864:20::332])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id CC3AC62DD7\n\tfor ;\n\tWed, 19 Oct 2022 11:01:16 +0200 (CEST)","by mail-wm1-x332.google.com with SMTP id\n\tc3-20020a1c3503000000b003bd21e3dd7aso17050059wma.1\n\tfor ;\n\tWed, 19 Oct 2022 02:01:16 -0700 (PDT)","from naush-laptop.localdomain ([93.93.133.154])\n\tby smtp.gmail.com with ESMTPSA id\n\tr9-20020a05600c458900b003b47b913901sm1017595wmo.1.2022.10.19.02.01.15\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tWed, 19 Oct 2022 02:01:15 -0700 (PDT)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1666170078;\n\tbh=TpykLQOJ9Y22AzmL02sFIPOAdOnb2uo0Tt69aguWdtI=;\n\th=To:Date:Subject:List-Id:List-Unsubscribe:List-Archive:List-Post:\n\tList-Help:List-Subscribe:From:Reply-To:From;\n\tb=uDLuSJ96WmYpZ+O91l3ozIBE/U2ZsA9agLFV4YfW/FfxvbA1Ettu7INHN633HULGO\n\tfmYaujCRje06OU8sHQlUzj0FgrRFkQfAsijoutaScf98VQ0jrFiH6HoX8dKaVKtmyg\n\tMIc1wBbNIaYihpbtZRPo0Mz7C1DLFrXACxBV1BQc+aaDM5jOdnJz7XOOkSH/YXF8uZ\n\to5jiwAbAHgP9xmC/XhXkaZweYmQja3kvz4Uqu21PsUAzs7JP71kNQmT+myz9Tsmggy\n\tEtEq7jLJm58rTXEdswQxz1XAvKhnPcQVl19pvWlGrfmtP6CNn4AdExi3+IjDlK4L2/\n\tPYPqTBxCaFBHQ==","v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=raspberrypi.com; s=google;\n\th=content-transfer-encoding:mime-version:message-id:date:subject:cc\n\t:to:from:from:to:cc:subject:date:message-id:reply-to;\n\tbh=MSsFH8R3o7HyZ7WUGnSNlTmNjjVh+2/7YxpRZtUAVEY=;\n\tb=VDm9A3owweaNn3zpOh75q3B4k5KRbi+7MwKDba18kk5u0ORlWzyBE1X3CjFdn0wsUN\n\txUTrMBIoLrwIqPeUZ++Zra2sKfuj3kY07Fj2hxFrYzNOZZAcKh4w9dmtVRrv4qXgpQ5u\n\tG0WQPNqyloPY4qAKUpcCzlyz/0gFrWXGyJ5agcPsdT8MUm8taYU8q5LAYSH6hW3rS2+4\n\thAkVj192rnafMyMQbK/DpgD39/eyxBXoBOwtSBIja2VmWFaimcN+kAkuEdS8F13Qfpai\n\tfV34xjDS/vCiDCeDpYF9kDFJCiuZe44qEO6EK5NpLUvx0kekZOHkSLEMqpC/fu5A9NbT\n\tqqSg=="],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (2048-bit key; \n\tunprotected) header.d=raspberrypi.com\n\theader.i=@raspberrypi.com\n\theader.b=\"VDm9A3ow\"; dkim-atps=neutral","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20210112;\n\th=content-transfer-encoding:mime-version:message-id:date:subject:cc\n\t:to:from:x-gm-message-state:from:to:cc:subject:date:message-id\n\t:reply-to;\n\tbh=MSsFH8R3o7HyZ7WUGnSNlTmNjjVh+2/7YxpRZtUAVEY=;\n\tb=D5iFv2k2ZQPhJ+q1SElNVEdX0cjymgQAAjJkL+4IiFRnStt1X9kcSVzgVzKqqTO/p3\n\toCWfZkfxKMEUKn3GYXkesybzALL+mNJHuz+FQqQ2hXiPRRjCgmp7wGtQ1k8668Scfh3u\n\tveXtYiJAGVTryUF2c9kazQhJcSB/malp/GinoQ1aFjIS7yA56cQiY5EBkVIq4GNIddQJ\n\tthTuVk13pnbQNMbP5AwvVDlS33qJZ+a8eVD4JnXaDOVaCFPmibyelKmEhbo6/89/Xm3B\n\tZRIe/e8A1kRtuB6kpx/LUYuujCfUczV9cFFS8eHC4MfmKuiXpCeVaeTTq595hqwgxn46\n\tORyQ==","X-Gm-Message-State":"ACrzQf2Kxu2JEDZLK4Y1vEbLvSWi1GHWffOX5/pjyQa39B8RRFl375at\n\tjW8iKJn/P4q7v2IC5QzxhakEzdyiu3qwgg==","X-Google-Smtp-Source":"AMsMyM4/XsKEwHQ8uMtxYtq2JkyIswE6J8tLRaXrbqq0b1RBsK1fz5SrWNQ6gtbwi2gr/F3pZ76OXA==","X-Received":"by 2002:a1c:f60d:0:b0:3be:708b:c96c with SMTP id\n\tw13-20020a1cf60d000000b003be708bc96cmr26218984wmc.168.1666170076190; \n\tWed, 19 Oct 2022 02:01:16 -0700 (PDT)","To":"libcamera-devel@lists.libcamera.org","Date":"Wed, 19 Oct 2022 10:01:00 +0100","Message-Id":"<20221019090107.19975-1-naush@raspberrypi.com>","X-Mailer":"git-send-email 2.25.1","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","Subject":"[libcamera-devel] [PATCH v4 0/7] Raspberry Pi AGC digital gain fixes","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","From":"Naushir Patuck via libcamera-devel\n\t","Reply-To":"Naushir Patuck ","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"Hi,\n\nVersion 4 of this series only has one change from the previous versions:\n\nIn patch 6/7, the IPA cookie (index into the RPiMetadata array) is passed from\nthe pipeline handler into the IPA rather than the other way around. This helps\nsimplify some of our future work on per-frame-control.\n\nThere is still lots of discussion on this series to be had, particularly for\npatch 1/7 where we add a cookie to DelayedControls, so feel free to provide some\nfeedback.\n\nRegards,\nNaush\n\nNaushir Patuck (7):\n delayed_controls: Template the ControlRingBuffer class\n delayed_controls: Add user cookie to DelayedControls\n tests: delayed_controls: Add cookie value test\n ipa: raspberrypi: Add RPiController::Metadata::mergeCopy\n ipa: raspberrypi: Use an array of RPiController::Metadata objects\n pipeline: ipa: raspberrypi: Use IPA cookies\n ipa: raspberrypi: agc: Fix digital gain calculation for manual mode\n\n include/libcamera/internal/delayed_controls.h | 21 +++--\n include/libcamera/ipa/raspberrypi.mojom | 4 +-\n src/ipa/raspberrypi/controller/metadata.h | 10 +++\n src/ipa/raspberrypi/controller/rpi/agc.cpp | 10 ++-\n src/ipa/raspberrypi/raspberrypi.cpp | 82 ++++++++++++-------\n src/libcamera/delayed_controls.cpp | 20 +++--\n src/libcamera/pipeline/ipu3/ipu3.cpp | 3 +-\n .../pipeline/raspberrypi/raspberrypi.cpp | 19 +++--\n src/libcamera/pipeline/rkisp1/rkisp1.cpp | 3 +-\n test/delayed_controls.cpp | 52 +++++++++++-\n 10 files changed, 163 insertions(+), 61 deletions(-)"}