{"id":16926,"url":"https://patchwork.libcamera.org/api/1.1/covers/16926/?format=json","web_url":"https://patchwork.libcamera.org/cover/16926/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/1.1/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20220803103849.26144-1-jacopo@jmondi.org>","date":"2022-08-03T10:38:42","name":"[libcamera-devel,v5,0/7] libcamera: Map multiple V4L2 formats to a single libcamera::format","submitter":{"id":3,"url":"https://patchwork.libcamera.org/api/1.1/people/3/?format=json","name":"Jacopo Mondi","email":"jacopo@jmondi.org"},"mbox":"https://patchwork.libcamera.org/cover/16926/mbox/","series":[{"id":3365,"url":"https://patchwork.libcamera.org/api/1.1/series/3365/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=3365","date":"2022-08-03T10:38:42","name":"libcamera: Map multiple V4L2 formats to a single libcamera::format","version":5,"mbox":"https://patchwork.libcamera.org/series/3365/mbox/"}],"comments":"https://patchwork.libcamera.org/api/covers/16926/comments/","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 1D714BE173\n\tfor ;\n\tWed, 3 Aug 2022 10:38:59 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 41FA363310;\n\tWed, 3 Aug 2022 12:38:58 +0200 (CEST)","from relay5-d.mail.gandi.net (relay5-d.mail.gandi.net\n\t[217.70.183.197])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 4542C603E6\n\tfor ;\n\tWed, 3 Aug 2022 12:38:57 +0200 (CEST)","(Authenticated sender: jacopo@jmondi.org)\n\tby mail.gandi.net (Postfix) with ESMTPSA id 3BAE01C0002;\n\tWed, 3 Aug 2022 10:38:54 +0000 (UTC)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1659523138;\n\tbh=IquhD3DaBZ3HABENPUiNSYR+Ht87AA9rS8cyqHVxfNs=;\n\th=To:Date:Subject:List-Id:List-Unsubscribe:List-Archive:List-Post:\n\tList-Help:List-Subscribe:From:Reply-To:Cc:From;\n\tb=SX403EiIL5grsL6uc2XYKC1YOdrOCrrlvockWCn2Ujxe4imFPidD8DhS7KwX7FBhO\n\thbSsdW9qBvKD/CB9O0dW6Hkjq4M54bQm7dvAKzeXINQgVnCTluVkKLZjNTuTtQyfHu\n\t2WaPyy/mJkgEGYNOatjn5YMwcdZ9FnLzHrg52RzmVkovWhXBLJRjWRQJLcXGB6HFop\n\tW7p2XOS4rjKb1IfuLcjQWAy4z7yggc/e1NXz3NfxY83Cgeo2x72Gg+OUdxtyEdh1vI\n\t3ypjWSIsLVqfL8+KEBNhC4oq9ROMjmgXTTHusGLIaJ57vbl4r0o6VGsi+Q8GKdeKYc\n\tRQPTQBJomv0XQ==","To":"libcamera-devel@lists.libcamera.org","Date":"Wed, 3 Aug 2022 12:38:42 +0200","Message-Id":"<20220803103849.26144-1-jacopo@jmondi.org>","X-Mailer":"git-send-email 2.37.1","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","Subject":"[libcamera-devel] [PATCH v5 0/7] libcamera: Map multiple V4L2\n\tformats to a single libcamera::format","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","From":"Jacopo Mondi via libcamera-devel ","Reply-To":"Jacopo Mondi ","Cc":"jozef@mlich.cz, Pavel Machek ","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"This series addresses the requirement of mapping multiple V4L2 pixel formats\nto a single libcamera format. Specifically, it allows to map V4L2_PIX_FMT_JPEG\nand V4L2_PIX_FMT_MJPEG to libcamera::formats::MJPEG.\n\nWhen testing on Pinephone I was able to capture JPEG (but not to inspect images)\nand YUYV. This time the sensor didn't fail me, and I was able to run a preview\nstream on the pinephone using the SDL backend.\n\nv4->v5:\n- Use std::hash specialization\n- Address Laurent's comment on 5/6\n- Add a tiny patch for the developer guide\n\nv3->v4:\n- Move 2/6 at the beginning and simplify it\n- Biggest change is in V4L2VideoDevice where formats are now collected in an\n unordered_set<> requiring V4L2PixelFormat to be instrumented with an Hash\n function object to allow it to be stored in an unordered STL container\n- Minor changes in comments/wording and Laurent's tags\n\nv2->v3:\n- Resorted patches as suggested by Laurent\n- Remove 'multiplanar' argument in the call chain\n- Cache the V4L2VideoDevice formats at open() time\n\nv1->v2:\n- Add a missing conversion using the video device in Simple converter\n- Map formats::MJPEG to V4L2_PIX_FMT_JPEG in v4l2 formats enumeration\n\nJacopo Mondi (7):\n libcamera: formats: Reimplement V4L2 PixelFormatInfo::info()\n libcamera: formats: Merge V4L2 single and multi formats\n guides: pipeline handler: Remove rogue spaces\n libcamera: v4l2_videodevice: Reintroduce toV4L2PixelFormat()\n libcamera: v4l2_pixelformat: Return the list of V4L2 formats\n libcamera: v4l2_videodevice: Match formats supported by the device\n libcamera: formats: Map V4L2_PIX_FMT_JPEG to formats::MJPEG\n\n Documentation/guides/pipeline-handler.rst | 9 +-\n include/libcamera/internal/formats.h | 5 +-\n include/libcamera/internal/v4l2_pixelformat.h | 18 +-\n include/libcamera/internal/v4l2_videodevice.h | 6 +\n src/libcamera/formats.cpp | 318 ++++--------------\n src/libcamera/pipeline/ipu3/cio2.cpp | 2 +-\n src/libcamera/pipeline/ipu3/imgu.cpp | 2 +-\n .../pipeline/raspberrypi/raspberrypi.cpp | 34 +-\n src/libcamera/pipeline/rkisp1/rkisp1_path.cpp | 6 +-\n src/libcamera/pipeline/simple/converter.cpp | 10 +-\n src/libcamera/pipeline/simple/simple.cpp | 4 +-\n src/libcamera/pipeline/uvcvideo/uvcvideo.cpp | 6 +-\n src/libcamera/pipeline/vimc/vimc.cpp | 8 +-\n src/libcamera/v4l2_pixelformat.cpp | 24 +-\n src/libcamera/v4l2_videodevice.cpp | 61 +++-\n src/v4l2/v4l2_camera_proxy.cpp | 6 +-\n test/libtest/buffer_source.cpp | 2 +-\n 17 files changed, 211 insertions(+), 310 deletions(-)\n\n--\n2.37.1"}