{"id":16137,"url":"https://patchwork.libcamera.org/api/1.1/covers/16137/?format=json","web_url":"https://patchwork.libcamera.org/cover/16137/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/1.1/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20220603132259.188845-1-umang.jain@ideasonboard.com>","date":"2022-06-03T13:22:55","name":"[libcamera-devel,v1,0/4] Move frame contexts queue to separate class","submitter":{"id":86,"url":"https://patchwork.libcamera.org/api/1.1/people/86/?format=json","name":"Umang Jain","email":"umang.jain@ideasonboard.com"},"mbox":"https://patchwork.libcamera.org/cover/16137/mbox/","series":[{"id":3157,"url":"https://patchwork.libcamera.org/api/1.1/series/3157/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=3157","date":"2022-06-03T13:22:55","name":"Move frame contexts queue to separate class","version":1,"mbox":"https://patchwork.libcamera.org/series/3157/mbox/"}],"comments":"https://patchwork.libcamera.org/api/covers/16137/comments/","headers":{"Return-Path":"<libcamera-devel-bounces@lists.libcamera.org>","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 42D16BD160\n\tfor <parsemail@patchwork.libcamera.org>;\n\tFri,  3 Jun 2022 13:23:06 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 76BA365633;\n\tFri,  3 Jun 2022 15:23:05 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 4D2D960105\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tFri,  3 Jun 2022 15:23:04 +0200 (CEST)","from perceval.ideasonboard.com\n\t(static-127-186-62-95.ipcom.comunitel.net [95.62.186.127])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 884BA10DD;\n\tFri,  3 Jun 2022 15:23:03 +0200 (CEST)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1654262585;\n\tbh=euQiaSclFF+kv+068n4/2cyL2WydO2fiMk8CT33ZksM=;\n\th=To:Date:Subject:List-Id:List-Unsubscribe:List-Archive:List-Post:\n\tList-Help:List-Subscribe:From:Reply-To:From;\n\tb=xphcew2WjQC75NAibBlag1kkgyFLiyvRk+JcqY0kT7pFPkbr+pGvUsmQ2QTw1ibo6\n\tAkNUobBpmbZLnZ23gp+GeWDl/HZCZow8Dq6ZnGRNhv9RBSKMYqTuhtp+PrYomeFcLr\n\tGv1oAGPbQN/tC/uf3IJ5iWAljN2uGDdi/1KpZsJedzBOQnBi1X2nfzWoFO9d2vRZdP\n\tB/slO+Zar2ZmzR4JT/fTx8ga9GEFhk+P36lsJx0/wb41qwI0zrIf6f0RF87SLnMsvC\n\tmfMe/GQJr3wf3wlSplco7BsHybHZWZu2O0W/ll4HOx5rRb2GPYa+DY4yulCdbwK6Y+\n\t5UxWCx+bnynkA==","v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1654262583;\n\tbh=euQiaSclFF+kv+068n4/2cyL2WydO2fiMk8CT33ZksM=;\n\th=From:To:Cc:Subject:Date:From;\n\tb=AHSXJ1dWg2Wy0QBql93BfB7SeO8KSiBnpss/WMflbdu1uyzR2raQlsWJvbYy+lcq1\n\tBe0fIH30Otn10o6EvdrvHzu1VRQXhAN8MavwevFLFyuQorDoEJQgoQAtA/5Tevq3ey\n\tWHZADUGsCazNNwWCsQTGd1lv5NbPldFuKSjrFoqs="],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=ideasonboard.com\n\theader.i=@ideasonboard.com\n\theader.b=\"AHSXJ1dW\"; dkim-atps=neutral","To":"libcamera-devel@lists.libcamera.org","Date":"Fri,  3 Jun 2022 15:22:55 +0200","Message-Id":"<20220603132259.188845-1-umang.jain@ideasonboard.com>","X-Mailer":"git-send-email 2.31.1","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","Subject":"[libcamera-devel] [PATCH v1 0/4] Move frame contexts queue to\n\tseparate class","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"<libcamera-devel.lists.libcamera.org>","List-Unsubscribe":"<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>","List-Archive":"<https://lists.libcamera.org/pipermail/libcamera-devel/>","List-Post":"<mailto:libcamera-devel@lists.libcamera.org>","List-Help":"<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>","List-Subscribe":"<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>","From":"Umang Jain via libcamera-devel <libcamera-devel@lists.libcamera.org>","Reply-To":"Umang Jain <umang.jain@ideasonboard.com>","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>"},"content":"Changes in v1 (from RFCv2):\n- Implement a proper mechanism to prevent FCQueue oveflow\n- Docs fixes\n- Minor &reference => *pointer conversions.\n\nSummary:\nThis patch series moves the frame contexts ring buffer to a separate\nclass. Minimialistic implementation in 1/4 to keep things run same.\n\nPatch 2/4 extends the .get() function to handle cases as :\n- Return same IPAFrameContext if previously created\n- Assign a new IPAFrameContext if the frame contexts for frame didn't\n  exists\n- isFull() detection\n\nPatch 3/4 implements a mechanism to prevent overflowing the FCQueue\n\nPatch 4/4 removes IPAFrameContext pointer requirement from\nAlgorithm::process() and use a frame number instead.\n\nSmoke tested briefly by running on nautilus.\n\nUmang Jain (4):\n  ipa: ipu3: Separate out frame context queue as a distinct class\n  ipa: ipu3: ipa_context: Extend FCQueue::get()\n  ipa: ipu3: Prevent over queuing of requests\n  ipa: algorithm: process() should take in frame number instead of\n    context\n\n include/libcamera/ipa/ipu3.mojom         |   2 +-\n src/ipa/ipu3/algorithms/af.cpp           |   4 +-\n src/ipa/ipu3/algorithms/af.h             |   2 +-\n src/ipa/ipu3/algorithms/agc.cpp          |  13 ++-\n src/ipa/ipu3/algorithms/agc.h            |   4 +-\n src/ipa/ipu3/algorithms/algorithm.h      |   4 +-\n src/ipa/ipu3/algorithms/awb.cpp          |   2 +-\n src/ipa/ipu3/algorithms/awb.h            |   2 +-\n src/ipa/ipu3/algorithms/tone_mapping.cpp |   4 +-\n src/ipa/ipu3/algorithms/tone_mapping.h   |   2 +-\n src/ipa/ipu3/ipa_context.cpp             | 138 ++++++++++++++++++++++-\n src/ipa/ipu3/ipa_context.h               |  20 +++-\n src/ipa/ipu3/ipu3.cpp                    |  33 ++++--\n src/ipa/libipa/algorithm.cpp             |   2 +-\n src/ipa/libipa/algorithm.h               |   6 +-\n src/ipa/rkisp1/algorithms/agc.cpp        |   3 +-\n src/ipa/rkisp1/algorithms/agc.h          |   2 +-\n src/ipa/rkisp1/algorithms/algorithm.h    |   5 +-\n src/ipa/rkisp1/algorithms/awb.cpp        |   2 +-\n src/ipa/rkisp1/algorithms/awb.h          |   2 +-\n src/ipa/rkisp1/rkisp1.cpp                |   2 +-\n src/libcamera/pipeline/ipu3/ipu3.cpp     |  10 +-\n 22 files changed, 216 insertions(+), 48 deletions(-)"}